Message ID | 1523285990-37457-1-git-send-email-pbonzini@redhat.com |
---|---|
State | New |
Headers | show |
On 9 April 2018 at 15:59, Paolo Bonzini <pbonzini@redhat.com> wrote: > The following changes since commit 0e87fdc966d05f4e5ad868034fcd8ee2a08ca62d: > > Update version for v2.12.0-rc2 release (2018-04-04 20:37:20 +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to e0014d4b3a955cfd8d517674703bfa87f340290a: > > Add missing bit for SSE instr in VEX decoding (2018-04-09 16:36:40 +0200) > > ---------------------------------------------------------------- > Miscellaneous bugfixes, including crash fixes from Alexey, Peter M. and > Thomas. > > ---------------------------------------------------------------- SPARC guest boottest, SPARC host: TEST: tests/boot-serial-test... (pid=99658) /sparc/boot-serial/LX: ** ERROR:/srv/pm215/qemu/tests/boot-serial-test.c:139:check_guest_output: assertion failed: (output_ok) FAIL GTester: last random seed: R02Sec8351c4b01f899a24e5f71f6615a712 (pid=100565) /sparc/boot-serial/SS-4: ** ERROR:/srv/pm215/qemu/tests/boot-serial-test.c:139:check_guest_output: assertion failed: (output_ok) FAIL GTester: last random seed: R02Scdc4c1568274a87c76f6e37e7c72f44b (pid=101395) /sparc/boot-serial/SS-600MP: OK FAIL: tests/boot-serial-test Apparently intermittent, I did a couple of by-hand reruns of that test case and they were fine... Applied to master. thanks -- PMM
On 09/04/2018 19:21, Peter Maydell wrote: > On 9 April 2018 at 15:59, Paolo Bonzini <pbonzini@redhat.com> wrote: >> The following changes since commit 0e87fdc966d05f4e5ad868034fcd8ee2a08ca62d: >> >> Update version for v2.12.0-rc2 release (2018-04-04 20:37:20 +0100) >> >> are available in the git repository at: >> >> git://github.com/bonzini/qemu.git tags/for-upstream >> >> for you to fetch changes up to e0014d4b3a955cfd8d517674703bfa87f340290a: >> >> Add missing bit for SSE instr in VEX decoding (2018-04-09 16:36:40 +0200) >> >> ---------------------------------------------------------------- >> Miscellaneous bugfixes, including crash fixes from Alexey, Peter M. and >> Thomas. >> >> ---------------------------------------------------------------- > > SPARC guest boottest, SPARC host: > > TEST: tests/boot-serial-test... (pid=99658) > /sparc/boot-serial/LX: ** > ERROR:/srv/pm215/qemu/tests/boot-serial-test.c:139:check_guest_output: > assertion failed: (output_ok) > FAIL > GTester: last random seed: R02Sec8351c4b01f899a24e5f71f6615a712 > (pid=100565) > /sparc/boot-serial/SS-4: ** > ERROR:/srv/pm215/qemu/tests/boot-serial-test.c:139:check_guest_output: > assertion failed: (output_ok) > FAIL > GTester: last random seed: R02Scdc4c1568274a87c76f6e37e7c72f44b > (pid=101395) > /sparc/boot-serial/SS-600MP: OK > FAIL: tests/boot-serial-test > > Apparently intermittent, I did a couple of by-hand reruns of > that test case and they were fine... What about before my patch? Paolo
On 9 April 2018 at 18:38, Paolo Bonzini <pbonzini@redhat.com> wrote: > On 09/04/2018 19:21, Peter Maydell wrote: >> On 9 April 2018 at 15:59, Paolo Bonzini <pbonzini@redhat.com> wrote: >>> The following changes since commit 0e87fdc966d05f4e5ad868034fcd8ee2a08ca62d: >>> >>> Update version for v2.12.0-rc2 release (2018-04-04 20:37:20 +0100) >>> >>> are available in the git repository at: >>> >>> git://github.com/bonzini/qemu.git tags/for-upstream >>> >>> for you to fetch changes up to e0014d4b3a955cfd8d517674703bfa87f340290a: >>> >>> Add missing bit for SSE instr in VEX decoding (2018-04-09 16:36:40 +0200) >>> >>> ---------------------------------------------------------------- >>> Miscellaneous bugfixes, including crash fixes from Alexey, Peter M. and >>> Thomas. >>> >>> ---------------------------------------------------------------- >> >> SPARC guest boottest, SPARC host: >> >> TEST: tests/boot-serial-test... (pid=99658) >> /sparc/boot-serial/LX: ** >> ERROR:/srv/pm215/qemu/tests/boot-serial-test.c:139:check_guest_output: >> assertion failed: (output_ok) >> FAIL >> GTester: last random seed: R02Sec8351c4b01f899a24e5f71f6615a712 >> (pid=100565) >> /sparc/boot-serial/SS-4: ** >> ERROR:/srv/pm215/qemu/tests/boot-serial-test.c:139:check_guest_output: >> assertion failed: (output_ok) >> FAIL >> GTester: last random seed: R02Scdc4c1568274a87c76f6e37e7c72f44b >> (pid=101395) >> /sparc/boot-serial/SS-600MP: OK >> FAIL: tests/boot-serial-test >> >> Apparently intermittent, I did a couple of by-hand reruns of >> that test case and they were fine... > > What about before my patch? Yes, I think we've seen this particular intermittent before; eg https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg04003.html though that was on a different host. thanks -- PMM
diff --git a/util/memfd.c b/util/memfd.c index 277f721..b3ecbac 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -202,6 +202,7 @@ bool qemu_memfd_alloc_check(void) */ bool qemu_memfd_check(void) { +#ifdef CONFIG_LINUX static int memfd_check = MEMFD_TODO; if (memfd_check == MEMFD_TODO) { @@ -215,4 +216,7 @@ bool qemu_memfd_check(void) } return memfd_check == MEMFD_OK; +#else + return false; +#endif }