[PULL,bionic] Add new linux-tools-host package with kvm_stat tool

Message ID 20180409125155.GL25803@ubuntu-xps13
State New
Headers show
Series
  • [PULL,bionic] Add new linux-tools-host package with kvm_stat tool
Related show

Pull-request

git://git.launchpad.net/~sforshee/+git/ubuntu-bionic lp1734130

Message

Seth Forshee April 9, 2018, 12:51 p.m.
BugLink: http://bugs.launchpad.net/bugs/1734130

IBM has requested that we package the kvm_stat tool from the krenel's
tools directory. This is different from other tools that we ship in
linux-tools packages in a couple of ways: it is written in pyhon and our
tools packages currently do not have a phyton dependency, and it is not
kernel version specific and can therefore be placed into a common tools
package.

To avoid adding a python dependency to our existing tools-common
package, kvm_stat is put into a new package, linux-tools-host. This
package could in the future contain additional tools useful for VM
hosts and currently has no version-speicific tools (but could support
version-specific tools later if needed).

This pull request also contains cherry picks from upstream and
linux-next to bring kvm_stat up to date and fix phyton 3 compatibility.

Thanks,
Seth


The following changes since commit be1171dce6c7dec2bae35061963f08a0e4d5b7f9:

  UBUNTU: [Config] CONFIG_BLK_DEV_NMVE=m (2018-04-05 08:30:29 -0500)

are available in the Git repository at:

  git://git.launchpad.net/~sforshee/+git/ubuntu-bionic lp1734130

for you to fetch changes up to 95b7a5dcf1489cd6b1cb4796fdf15828eb32b781:

  UBUNTU: [Config] do_tools_host=true for amd64 (2018-04-06 15:10:23 -0500)

----------------------------------------------------------------
Cole Robinson (3):
      tools/kvm_stat: Fix python3 syntax
      tools/kvm_stat: Don't use deprecated file()
      tools/kvm_stat: Remove unused function

Marc Hartmayer (4):
      tools/kvm_stat: simplify the sortkey function
      tools/kvm_stat: use a namedtuple for storing the values
      tools/kvm_stat: use a more pythonic way to iterate over dictionaries
      tools/kvm_stat: avoid 'is' for equality checks

Seth Forshee (2):
      UBUNTU: [Packaging] Add linux-tools-host package for VM host tools
      UBUNTU: [Config] do_tools_host=true for amd64

Stefan Raspl (8):
      tools/kvm_stat: fix crash when filtering out all non-child trace events
      tools/kvm_stat: print error on invalid regex
      tools/kvm_stat: fix debugfs handling
      tools/kvm_stat: mark private methods as such
      tools/kvm_stat: eliminate extra guest/pid selection dialog
      tools/kvm_stat: separate drilldown and fields filtering
      tools/kvm_stat: group child events indented after parent
      tools/kvm_stat: print 'Total' line for multiple events only

 debian.master/control.stub.in    |  10 +
 debian.master/rules.d/amd64.mk   |   1 +
 debian/rules                     |   2 +
 debian/rules.d/0-common-vars.mk  |   1 +
 debian/rules.d/1-maintainer.mk   |   1 +
 debian/rules.d/3-binary-indep.mk |  14 ++
 tools/kvm/kvm_stat/kvm_stat      | 502 ++++++++++++++++++++++-----------------
 tools/kvm/kvm_stat/kvm_stat.txt  |   4 +-
 8 files changed, 315 insertions(+), 220 deletions(-)

Comments

Thadeu Lima de Souza Cascardo April 12, 2018, 1:43 p.m. | #1
On Mon, Apr 09, 2018 at 07:51:55AM -0500, Seth Forshee wrote:
> BugLink: http://bugs.launchpad.net/bugs/1734130
> 
> IBM has requested that we package the kvm_stat tool from the krenel's
> tools directory. This is different from other tools that we ship in
> linux-tools packages in a couple of ways: it is written in pyhon and our
> tools packages currently do not have a phyton dependency, and it is not
> kernel version specific and can therefore be placed into a common tools
> package.
> 
> To avoid adding a python dependency to our existing tools-common
> package, kvm_stat is put into a new package, linux-tools-host. This
> package could in the future contain additional tools useful for VM
> hosts and currently has no version-speicific tools (but could support
> version-specific tools later if needed).
> 
> This pull request also contains cherry picks from upstream and
> linux-next to bring kvm_stat up to date and fix phyton 3 compatibility.
> 
> Thanks,
> Seth

Looks sensible. Will apply with my ACK.

Acked-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

> 
> 
> The following changes since commit be1171dce6c7dec2bae35061963f08a0e4d5b7f9:
> 
>   UBUNTU: [Config] CONFIG_BLK_DEV_NMVE=m (2018-04-05 08:30:29 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.launchpad.net/~sforshee/+git/ubuntu-bionic lp1734130
> 
> for you to fetch changes up to 95b7a5dcf1489cd6b1cb4796fdf15828eb32b781:
> 
>   UBUNTU: [Config] do_tools_host=true for amd64 (2018-04-06 15:10:23 -0500)
> 
> ----------------------------------------------------------------
> Cole Robinson (3):
>       tools/kvm_stat: Fix python3 syntax
>       tools/kvm_stat: Don't use deprecated file()
>       tools/kvm_stat: Remove unused function
> 
> Marc Hartmayer (4):
>       tools/kvm_stat: simplify the sortkey function
>       tools/kvm_stat: use a namedtuple for storing the values
>       tools/kvm_stat: use a more pythonic way to iterate over dictionaries
>       tools/kvm_stat: avoid 'is' for equality checks
> 
> Seth Forshee (2):
>       UBUNTU: [Packaging] Add linux-tools-host package for VM host tools
>       UBUNTU: [Config] do_tools_host=true for amd64
> 
> Stefan Raspl (8):
>       tools/kvm_stat: fix crash when filtering out all non-child trace events
>       tools/kvm_stat: print error on invalid regex
>       tools/kvm_stat: fix debugfs handling
>       tools/kvm_stat: mark private methods as such
>       tools/kvm_stat: eliminate extra guest/pid selection dialog
>       tools/kvm_stat: separate drilldown and fields filtering
>       tools/kvm_stat: group child events indented after parent
>       tools/kvm_stat: print 'Total' line for multiple events only
> 
>  debian.master/control.stub.in    |  10 +
>  debian.master/rules.d/amd64.mk   |   1 +
>  debian/rules                     |   2 +
>  debian/rules.d/0-common-vars.mk  |   1 +
>  debian/rules.d/1-maintainer.mk   |   1 +
>  debian/rules.d/3-binary-indep.mk |  14 ++
>  tools/kvm/kvm_stat/kvm_stat      | 502 ++++++++++++++++++++++-----------------
>  tools/kvm/kvm_stat/kvm_stat.txt  |   4 +-
>  8 files changed, 315 insertions(+), 220 deletions(-)
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team