[OEM-B,v2] UBUNTU: SAUCE: (no-up): ASoC: Intel: bytcr-rt5660: fix frame polarity

Message ID 20180409115643.21925-1-shrirang.bagul@canonical.com
State New
Headers show
Series
  • [OEM-B,v2] UBUNTU: SAUCE: (no-up): ASoC: Intel: bytcr-rt5660: fix frame polarity
Related show

Commit Message

Shrirang Bagul April 9, 2018, 11:56 a.m.
BugLink: http://bugs.launchpad.net/bugs/1675327

The current frame sync polarity definition in RT5660 machine driver is
inconsistent with the Atom/DPCM driver, fix to align with regular ASoC
definitions.
This patch fixes the noise heard during playback on line-out.

Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com>
---
 sound/soc/intel/boards/bytcr_rt5660.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kai Heng Feng April 11, 2018, 5:58 a.m. | #1
> On Apr 9, 2018, at 7:56 PM, Shrirang Bagul <shrirang.bagul@canonical.com>  
> wrote:
>
> BugLink: http://bugs.launchpad.net/bugs/1675327
>
> The current frame sync polarity definition in RT5660 machine driver is
> inconsistent with the Atom/DPCM driver, fix to align with regular ASoC
> definitions.
> This patch fixes the noise heard during playback on line-out.
>
> Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com>

Acked-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

> ---
>  sound/soc/intel/boards/bytcr_rt5660.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5660.c  
> b/sound/soc/intel/boards/bytcr_rt5660.c
> index aee6bcf66f34..f0e3e4125f07 100644
> --- a/sound/soc/intel/boards/bytcr_rt5660.c
> +++ b/sound/soc/intel/boards/bytcr_rt5660.c
> @@ -270,7 +270,7 @@ static int byt_rt5660_codec_fixup(struct  
> snd_soc_pcm_runtime *rtd,
>  	 */
>  	ret = snd_soc_dai_set_fmt(rtd->cpu_dai,
>  			SND_SOC_DAIFMT_I2S     |
> -			SND_SOC_DAIFMT_NB_IF   |
> +			SND_SOC_DAIFMT_NB_NF   |
>  			SND_SOC_DAIFMT_CBS_CFS
>  			);
>  	if (ret < 0) {
> -- 
> 2.14.1
>
>
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Timo Aaltonen April 11, 2018, 7:25 a.m. | #2
On 09.04.2018 14:56, Shrirang Bagul wrote:
> BugLink: http://bugs.launchpad.net/bugs/1675327
> 
> The current frame sync polarity definition in RT5660 machine driver is
> inconsistent with the Atom/DPCM driver, fix to align with regular ASoC
> definitions.
> This patch fixes the noise heard during playback on line-out.
> 
> Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com>
> ---
>  sound/soc/intel/boards/bytcr_rt5660.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/boards/bytcr_rt5660.c b/sound/soc/intel/boards/bytcr_rt5660.c
> index aee6bcf66f34..f0e3e4125f07 100644
> --- a/sound/soc/intel/boards/bytcr_rt5660.c
> +++ b/sound/soc/intel/boards/bytcr_rt5660.c
> @@ -270,7 +270,7 @@ static int byt_rt5660_codec_fixup(struct snd_soc_pcm_runtime *rtd,
>  	 */
>  	ret = snd_soc_dai_set_fmt(rtd->cpu_dai,
>  			SND_SOC_DAIFMT_I2S     |
> -			SND_SOC_DAIFMT_NB_IF   |
> +			SND_SOC_DAIFMT_NB_NF   |
>  			SND_SOC_DAIFMT_CBS_CFS
>  			);
>  	if (ret < 0) {

Applied to bionic oem-next, thanks

Patch

diff --git a/sound/soc/intel/boards/bytcr_rt5660.c b/sound/soc/intel/boards/bytcr_rt5660.c
index aee6bcf66f34..f0e3e4125f07 100644
--- a/sound/soc/intel/boards/bytcr_rt5660.c
+++ b/sound/soc/intel/boards/bytcr_rt5660.c
@@ -270,7 +270,7 @@  static int byt_rt5660_codec_fixup(struct snd_soc_pcm_runtime *rtd,
 	 */
 	ret = snd_soc_dai_set_fmt(rtd->cpu_dai,
 			SND_SOC_DAIFMT_I2S     |
-			SND_SOC_DAIFMT_NB_IF   |
+			SND_SOC_DAIFMT_NB_NF   |
 			SND_SOC_DAIFMT_CBS_CFS
 			);
 	if (ret < 0) {