[OEM-B] UBUNTU: SAUCE: (no-up): ASoC: Intel: bytcr-rt5660: fix frame polarity

Message ID 20180409114650.21376-1-shrirang.bagul@canonical.com
State New
Headers show
Series
  • [OEM-B] UBUNTU: SAUCE: (no-up): ASoC: Intel: bytcr-rt5660: fix frame polarity
Related show

Commit Message

Shrirang Bagul April 9, 2018, 11:46 a.m.
The current frame sync polarity definition in RT5660 machine driver is
inconsistent with the Atom/DPCM driver, fix to align with regular ASoC
definitions.
This patch fixes the noise heard during playback on line-out.

Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com>
---
 sound/soc/intel/boards/bytcr_rt5660.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shrirang Bagul April 9, 2018, 11:51 a.m. | #1
On Mon, 2018-04-09 at 19:46 +0800, Shrirang Bagul wrote:
> The current frame sync polarity definition in RT5660 machine driver is
> inconsistent with the Atom/DPCM driver, fix to align with regular ASoC
> definitions.
> This patch fixes the noise heard during playback on line-out.
> 
> Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com>
> ---
>  sound/soc/intel/boards/bytcr_rt5660.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/boards/bytcr_rt5660.c b/sound/soc/intel/boards/bytcr_rt5660.c
> index aee6bcf66f34..f0e3e4125f07 100644
> --- a/sound/soc/intel/boards/bytcr_rt5660.c
> +++ b/sound/soc/intel/boards/bytcr_rt5660.c
> @@ -270,7 +270,7 @@ static int byt_rt5660_codec_fixup(struct snd_soc_pcm_runtime *rtd,
>  	 */
>  	ret = snd_soc_dai_set_fmt(rtd->cpu_dai,
>  			SND_SOC_DAIFMT_I2S     |
> -			SND_SOC_DAIFMT_NB_IF   |
> +			SND_SOC_DAIFMT_NB_NF   |
>  			SND_SOC_DAIFMT_CBS_CFS
>  			);
>  	if (ret < 0) {
> -- 
> 2.14.1

Strange, BugLink is missing. Will resend.

/Shrirang
> 
>

Patch

diff --git a/sound/soc/intel/boards/bytcr_rt5660.c b/sound/soc/intel/boards/bytcr_rt5660.c
index aee6bcf66f34..f0e3e4125f07 100644
--- a/sound/soc/intel/boards/bytcr_rt5660.c
+++ b/sound/soc/intel/boards/bytcr_rt5660.c
@@ -270,7 +270,7 @@  static int byt_rt5660_codec_fixup(struct snd_soc_pcm_runtime *rtd,
 	 */
 	ret = snd_soc_dai_set_fmt(rtd->cpu_dai,
 			SND_SOC_DAIFMT_I2S     |
-			SND_SOC_DAIFMT_NB_IF   |
+			SND_SOC_DAIFMT_NB_NF   |
 			SND_SOC_DAIFMT_CBS_CFS
 			);
 	if (ret < 0) {