UBUNTU: kvm: [config] Enable ACPI NVDIMM

Message ID 20180406195253.9014-1-julio.montes@intel.com
State New
Headers show
Series
  • UBUNTU: kvm: [config] Enable ACPI NVDIMM
Related show

Commit Message

Julio Montes April 6, 2018, 7:52 p.m.
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-kvm/+bug/1761854

Enable ACPI NVDIMM Firmware Interface Table to allow kata containers mount
the rootfs from persistent memory (pmemX)

Next configs are needed:
* CONFIG_ACPI_NFIT
* CONFIG_BLK_DEV_PMEM
* CONFIG_LIBNVDIMM

Signed-off-by: Julio Montes <julio.montes@intel.com>
---
 debian.kvm/config/config.common.ubuntu | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comments

Kleber Souza April 23, 2018, 1:42 p.m. | #1
Hi Julio,

On 04/06/18 21:52, Julio Montes wrote:
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-kvm/+bug/1761854
> 
> Enable ACPI NVDIMM Firmware Interface Table to allow kata containers mount
> the rootfs from persistent memory (pmemX)
> 
> Next configs are needed:
> * CONFIG_ACPI_NFIT
> * CONFIG_BLK_DEV_PMEM
> * CONFIG_LIBNVDIMM
> 
> Signed-off-by: Julio Montes <julio.montes@intel.com>
> ---
>  debian.kvm/config/config.common.ubuntu | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
> index 43739c7..93532e3 100644
> --- a/debian.kvm/config/config.common.ubuntu
> +++ b/debian.kvm/config/config.common.ubuntu
> @@ -29,7 +29,7 @@ CONFIG_ACPI_HOTPLUG_CPU=y
>  CONFIG_ACPI_HOTPLUG_IOAPIC=y
>  # CONFIG_ACPI_INITRD_TABLE_OVERRIDE is not set
>  CONFIG_ACPI_LEGACY_TABLES_LOOKUP=y
> -# CONFIG_ACPI_NFIT is not set
> +CONFIG_ACPI_NFIT=y

Could this option be =m instead to keep it in sync with xenial/linux config?

>  CONFIG_ACPI_NUMA=y
>  # CONFIG_ACPI_PCI_SLOT is not set
>  CONFIG_ACPI_PROCESSOR=y
> @@ -194,6 +194,7 @@ CONFIG_BLK_DEV_MD=m
>  # CONFIG_BLK_DEV_NVME is not set
>  # CONFIG_BLK_DEV_OSD is not set
>  # CONFIG_BLK_DEV_PCIESSD_MTIP32XX is not set
> +CONFIG_BLK_DEV_PMEM=y

Also =m here.

>  CONFIG_BLK_DEV_RAM=y
>  CONFIG_BLK_DEV_RAM_COUNT=16
>  CONFIG_BLK_DEV_RAM_DAX=y
> @@ -249,6 +250,7 @@ CONFIG_BTRFS_FS=m
>  # CONFIG_BTRFS_FS_CHECK_INTEGRITY is not set
>  # CONFIG_BTRFS_FS_POSIX_ACL is not set
>  # CONFIG_BTRFS_FS_RUN_SANITY_TESTS is not set
> +CONFIG_BTT=y
>  # CONFIG_BUG is not set
>  CONFIG_BUILDTIME_EXTABLE_SORT=y
>  CONFIG_BUILD_BIN2C=y
> @@ -1117,7 +1119,7 @@ CONFIG_LEGACY_VSYSCALL_EMULATE=y
>  # CONFIG_LEGACY_VSYSCALL_NATIVE is not set
>  # CONFIG_LEGACY_VSYSCALL_NONE is not set
>  CONFIG_LIBCRC32C=m
> -# CONFIG_LIBNVDIMM is not set
> +CONFIG_LIBNVDIMM=y
>  # CONFIG_LKDTM is not set
>  CONFIG_LLC=y
>  # CONFIG_LLC2 is not set
> @@ -1280,6 +1282,9 @@ CONFIG_NAMESPACES=y
>  # CONFIG_NCPFS_SMALLDOS is not set
>  # CONFIG_NCPFS_STRONG is not set
>  CONFIG_NCP_FS=m
> +CONFIG_ND_BLK=y
> +CONFIG_ND_BTT=y

The above two options are also =m on the master kernel.

> +CONFIG_ND_CLAIM=y
>  CONFIG_NEED_DMA_MAP_STATE=y
>  CONFIG_NEED_MULTIPLE_NODES=y
>  CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
> 

Apart from that I don't have any objection in enabling these config options.

Thanks,
Kleber

Patch

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index 43739c7..93532e3 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -29,7 +29,7 @@  CONFIG_ACPI_HOTPLUG_CPU=y
 CONFIG_ACPI_HOTPLUG_IOAPIC=y
 # CONFIG_ACPI_INITRD_TABLE_OVERRIDE is not set
 CONFIG_ACPI_LEGACY_TABLES_LOOKUP=y
-# CONFIG_ACPI_NFIT is not set
+CONFIG_ACPI_NFIT=y
 CONFIG_ACPI_NUMA=y
 # CONFIG_ACPI_PCI_SLOT is not set
 CONFIG_ACPI_PROCESSOR=y
@@ -194,6 +194,7 @@  CONFIG_BLK_DEV_MD=m
 # CONFIG_BLK_DEV_NVME is not set
 # CONFIG_BLK_DEV_OSD is not set
 # CONFIG_BLK_DEV_PCIESSD_MTIP32XX is not set
+CONFIG_BLK_DEV_PMEM=y
 CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_COUNT=16
 CONFIG_BLK_DEV_RAM_DAX=y
@@ -249,6 +250,7 @@  CONFIG_BTRFS_FS=m
 # CONFIG_BTRFS_FS_CHECK_INTEGRITY is not set
 # CONFIG_BTRFS_FS_POSIX_ACL is not set
 # CONFIG_BTRFS_FS_RUN_SANITY_TESTS is not set
+CONFIG_BTT=y
 # CONFIG_BUG is not set
 CONFIG_BUILDTIME_EXTABLE_SORT=y
 CONFIG_BUILD_BIN2C=y
@@ -1117,7 +1119,7 @@  CONFIG_LEGACY_VSYSCALL_EMULATE=y
 # CONFIG_LEGACY_VSYSCALL_NATIVE is not set
 # CONFIG_LEGACY_VSYSCALL_NONE is not set
 CONFIG_LIBCRC32C=m
-# CONFIG_LIBNVDIMM is not set
+CONFIG_LIBNVDIMM=y
 # CONFIG_LKDTM is not set
 CONFIG_LLC=y
 # CONFIG_LLC2 is not set
@@ -1280,6 +1282,9 @@  CONFIG_NAMESPACES=y
 # CONFIG_NCPFS_SMALLDOS is not set
 # CONFIG_NCPFS_STRONG is not set
 CONFIG_NCP_FS=m
+CONFIG_ND_BLK=y
+CONFIG_ND_BTT=y
+CONFIG_ND_CLAIM=y
 CONFIG_NEED_DMA_MAP_STATE=y
 CONFIG_NEED_MULTIPLE_NODES=y
 CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y