Patchwork Fix build error in usb-ccid code

login
register
mail settings
Submitter Dmitry Eremin-Solenikov
Date April 4, 2011, 12:31 p.m.
Message ID <1301920281-16372-1-git-send-email-dbaryshkov@gmail.com>
Download mbox | patch
Permalink /patch/89619/
State New
Headers show

Comments

Dmitry Eremin-Solenikov - April 4, 2011, 12:31 p.m.
W/o this fix I'm getting the following error:
cc1: warnings being treated as errors
hw/usb-ccid.c: In function ‘ccid_card_card_error’:
hw/usb-ccid.c:1202:5: error: format ‘%lX’ expects type ‘long unsigned int’, but argument 2 has type ‘uint64_t’

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 hw/usb-ccid.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Peter Maydell - April 4, 2011, 12:34 p.m.
On 4 April 2011 13:31, Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> wrote:
> W/o this fix I'm getting the following error:
> cc1: warnings being treated as errors
> hw/usb-ccid.c: In function ‘ccid_card_card_error’:
> hw/usb-ccid.c:1202:5: error: format ‘%lX’ expects type ‘long unsigned int’, but argument 2 has type ‘uint64_t’

David Gibson posted a patch for that earlier this morning:
http://patchwork.ozlabs.org/patch/89577/

-- PMM
Dmitry Eremin-Solenikov - April 4, 2011, 1:15 p.m.
On 4/4/11, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 4 April 2011 13:31, Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> wrote:
>> W/o this fix I'm getting the following error:
>> cc1: warnings being treated as errors
>> hw/usb-ccid.c: In function ‘ccid_card_card_error’:
>> hw/usb-ccid.c:1202:5: error: format ‘%lX’ expects type ‘long unsigned
>> int’, but argument 2 has type ‘uint64_t’
>
> David Gibson posted a patch for that earlier this morning:
> http://patchwork.ozlabs.org/patch/89577/

Sorry for the noise then.

Patch

diff --git a/hw/usb-ccid.c b/hw/usb-ccid.c
index 723b2e3..5c80cbd 100644
--- a/hw/usb-ccid.c
+++ b/hw/usb-ccid.c
@@ -1199,7 +1199,7 @@  void ccid_card_card_error(CCIDCardState *card, uint64_t error)
 
     s->bmCommandStatus = COMMAND_STATUS_FAILED;
     s->last_answer_error = error;
-    DPRINTF(s, 1, "VSC_Error: %lX\n", s->last_answer_error);
+    DPRINTF(s, 1, "VSC_Error: %LX\n", s->last_answer_error);
     /* TODO: these error's should be more verbose and propogated to the guest.*/
     /*
      * We flush all pending answers on CardRemove message in ccid-card-passthru,