Patchwork mtd: onenand: add ecclayout and subpage_sft for none-flex 4kb page onenand

login
register
mail settings
Submitter Roman Tereshonkov
Date April 4, 2011, 11:07 a.m.
Message ID <1301915224-7571-1-git-send-email-roman.tereshonkov@nokia.com>
Download mbox | patch
Permalink /patch/89612/
State New
Headers show

Comments

Roman Tereshonkov - April 4, 2011, 11:07 a.m.
So as the ecclayout and suppage size for 4kb page
Flex- and none-Flex OneNAND are different
the new values for none-Flex 4kb page OneNAND memory are added.

The introduced ecclayout and suppage size are based on specification
4Gb M-die OneNAND Flash (KFM4G16Q4M, KFN8G16Q4M). Rev. 1.3, Apr. 2010

Signed-off-by: Roman Tereshonkov <roman.tereshonkov@nokia.com>
---
 drivers/mtd/onenand/onenand_base.c |   33 +++++++++++++++++++++++++++++++--
 1 files changed, 31 insertions(+), 2 deletions(-)
Artem Bityutskiy - April 4, 2011, 11:56 a.m.
Hi,

just few minor nit-picks.

Please, try to make the commit subject shorted and less detailed, but
more readable.

On Mon, 2011-04-04 at 14:07 +0300, Roman Tereshonkov wrote: 
>  /**
> + *  onenand_oob_128 - oob info for OneNAND with 4KB page
> + *  and using reserved bytes as free bytes instead of
> + *  free bytes that are managed by ECC.
> + *  For now, we expose only 64 out of 72 ecc bytes
> + */

Do not use /** since this is not a proper kerneldoc comment. Use /*
instead.

Also, make the lines longer - we have 80 characters per line for
comments.

Also, why you use expression "for now" - does it mean you are going to
change this soon? If not, please, amend the comment.

> +static struct nand_ecclayout onenand_oob_128_none_flex = {

none_flex sounds a bit strange. I think it is better to:

1. Re-name onenand_oob_128 into flexonenand_oob_128 (in a separate
patch)
2. Introduce onenand_oob_128

Patch

diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index 56a8b20..9b53feb 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -87,6 +87,30 @@  static struct nand_ecclayout onenand_oob_128 = {
 };
 
 /**
+ *  onenand_oob_128 - oob info for OneNAND with 4KB page
+ *  and using reserved bytes as free bytes instead of
+ *  free bytes that are managed by ECC.
+ *  For now, we expose only 64 out of 72 ecc bytes
+ */
+static struct nand_ecclayout onenand_oob_128_none_flex = {
+	.eccbytes	= 64,
+	.eccpos		= {
+		7, 8, 9, 10, 11, 12, 13, 14, 15,
+		23, 24, 25, 26, 27, 28, 29, 30, 31,
+		39, 40, 41, 42, 43, 44, 45, 46, 47,
+		55, 56, 57, 58, 59, 60, 61, 62, 63,
+		71, 72, 73, 74, 75, 76, 77, 78, 79,
+		87, 88, 89, 90, 91, 92, 93, 94, 95,
+		103, 104, 105, 106, 107, 108, 109, 110, 111,
+		119
+	},
+	.oobfree	= {
+		{5, 2}, {21, 2}, {37, 2}, {53, 2},
+		{69, 2}, {85, 2}, {101, 2}, {117, 2}
+	}
+};
+
+/**
  * onenand_oob_64 - oob info for large (2KB) page
  */
 static struct nand_ecclayout onenand_oob_64 = {
@@ -4018,8 +4042,13 @@  int onenand_scan(struct mtd_info *mtd, int maxchips)
 	 */
 	switch (mtd->oobsize) {
 	case 128:
-		this->ecclayout = &onenand_oob_128;
-		mtd->subpage_sft = 0;
+		if (FLEXONENAND(this)) {
+			this->ecclayout = &onenand_oob_128;
+			mtd->subpage_sft = 0;
+		} else {
+			this->ecclayout = &onenand_oob_128_none_flex;
+			mtd->subpage_sft = 2;
+		}
 		break;
 	case 64:
 		this->ecclayout = &onenand_oob_64;