Message ID | 1301909548-20031-1-git-send-email-wanlong.gao@gmail.com |
---|---|
State | Rejected, archived |
Delegated to: | David Miller |
Headers | show |
On Mon, Apr 04, 2011 at 05:32:28PM +0800, wanlong.gao@gmail.com wrote: > From: Wanlong Gao <wanlong.gao@gmail.com> > > kernel_warning: pcmcia_request_exclusive_irq is deprecated . NACK. This papers over the issue, instead of fixing it. To properly fix it, one needs to verify that the IRQ handler used in this driver is capable of handling a shared IRQ line. Best, Dominik > Signed-off-by: Wanlong Gao <wanlong.gao@gmail.com> > --- > drivers/net/pcmcia/nmclan_cs.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/pcmcia/nmclan_cs.c b/drivers/net/pcmcia/nmclan_cs.c > index 76683d9..bf97231 > --- a/drivers/net/pcmcia/nmclan_cs.c > +++ b/drivers/net/pcmcia/nmclan_cs.c > @@ -625,7 +625,7 @@ static int nmclan_config(struct pcmcia_device *link) > ret = pcmcia_request_io(link); > if (ret) > goto failed; > - ret = pcmcia_request_exclusive_irq(link, mace_interrupt); > + ret = __pcmcia_request_exclusive_irq(link, mace_interrupt); > if (ret) > goto failed; > ret = pcmcia_enable_device(link); > -- > 1.7.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
You means that some drivers still not capable of IRQF_SHARED? Thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Apr 04, 2011 at 05:44:00PM +0800, wanlong.gao wrote:
> You means that some drivers still not capable of IRQF_SHARED?
That's the issue. I do not know whether this driver is capable of
IRQF_SHARED as it should be. If it is, you may replace the
pcmcia_request_exclusive_irq() with pcmcia_request_irq(), and the warning
will be gone.
Best,
Dominik
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
I see the issue , but it is sorry that I don't know whether it is capable, yes . So just ignore my stupid patch . Thanks for your comments, and benefited a lot. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/pcmcia/nmclan_cs.c b/drivers/net/pcmcia/nmclan_cs.c index 76683d9..bf97231 --- a/drivers/net/pcmcia/nmclan_cs.c +++ b/drivers/net/pcmcia/nmclan_cs.c @@ -625,7 +625,7 @@ static int nmclan_config(struct pcmcia_device *link) ret = pcmcia_request_io(link); if (ret) goto failed; - ret = pcmcia_request_exclusive_irq(link, mace_interrupt); + ret = __pcmcia_request_exclusive_irq(link, mace_interrupt); if (ret) goto failed; ret = pcmcia_enable_device(link);