| Message ID | 1523141843-15207-1-git-send-email-debmc@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3] devicetree: dt_base: Make dtc warnings not failures | expand |
On 07/04/18 23:57, Deb McLemore wrote: > Most dtc warnings are not issues so mark as warning > and available for review. > > Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com> > --- > src/devicetree/dt_base/dt_base.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/src/devicetree/dt_base/dt_base.c b/src/devicetree/dt_base/dt_base.c > index ead965f..6ce4122 100644 > --- a/src/devicetree/dt_base/dt_base.c > +++ b/src/devicetree/dt_base/dt_base.c > @@ -109,10 +109,11 @@ static int dt_base_check_warnings(fwts_framework *fw) > } > > if (out_len > 0) { > - fwts_failed(fw, LOG_LEVEL_MEDIUM, > - "DeviceTreeBaseDTCWarnings", > - "dtc reports warnings from device tree:%s", > - output); > + fwts_warning(fw, "Some warnings from dtc. " > + "Run command \"dtc -I fs -O dts -o my.dts " > + "/sys/firmware/devicetree/base\" for " > + "further review: %s", output); > + ret = FWTS_OK; > goto err; > } > > Acked-by: Colin Ian King <colin.king@canonical.com>
On 2018-04-07 03:57 PM, Deb McLemore wrote: > Most dtc warnings are not issues so mark as warning > and available for review. > > Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com> > --- > src/devicetree/dt_base/dt_base.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/src/devicetree/dt_base/dt_base.c b/src/devicetree/dt_base/dt_base.c > index ead965f..6ce4122 100644 > --- a/src/devicetree/dt_base/dt_base.c > +++ b/src/devicetree/dt_base/dt_base.c > @@ -109,10 +109,11 @@ static int dt_base_check_warnings(fwts_framework *fw) > } > > if (out_len > 0) { > - fwts_failed(fw, LOG_LEVEL_MEDIUM, > - "DeviceTreeBaseDTCWarnings", > - "dtc reports warnings from device tree:%s", > - output); > + fwts_warning(fw, "Some warnings from dtc. " > + "Run command \"dtc -I fs -O dts -o my.dts " > + "/sys/firmware/devicetree/base\" for " > + "further review: %s", output); > + ret = FWTS_OK; > goto err; > } > > Acked-by: Alex Hung <alex.hung@canonical.com>
diff --git a/src/devicetree/dt_base/dt_base.c b/src/devicetree/dt_base/dt_base.c index ead965f..6ce4122 100644 --- a/src/devicetree/dt_base/dt_base.c +++ b/src/devicetree/dt_base/dt_base.c @@ -109,10 +109,11 @@ static int dt_base_check_warnings(fwts_framework *fw) } if (out_len > 0) { - fwts_failed(fw, LOG_LEVEL_MEDIUM, - "DeviceTreeBaseDTCWarnings", - "dtc reports warnings from device tree:%s", - output); + fwts_warning(fw, "Some warnings from dtc. " + "Run command \"dtc -I fs -O dts -o my.dts " + "/sys/firmware/devicetree/base\" for " + "further review: %s", output); + ret = FWTS_OK; goto err; }
Most dtc warnings are not issues so mark as warning and available for review. Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com> --- src/devicetree/dt_base/dt_base.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)