[1/1] mpd: add mms support

Message ID 20180407115230.22559-1-fontaine.fabrice@gmail.com
State New
Headers show
Series
  • [1/1] mpd: add mms support
Related show

Commit Message

Fabrice Fontaine April 7, 2018, 11:52 a.m.
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/mpd/Config.in | 6 ++++++
 package/mpd/mpd.mk    | 7 +++++++
 2 files changed, 13 insertions(+)

Comments

Thomas Petazzoni April 9, 2018, 9:15 a.m. | #1
Hello,

On Sat,  7 Apr 2018 13:52:30 +0200, Fabrice Fontaine wrote:
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/mpd/Config.in | 6 ++++++
>  package/mpd/mpd.mk    | 7 +++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/package/mpd/Config.in b/package/mpd/Config.in
> index 6c7468e173..831e4ab0d7 100644
> --- a/package/mpd/Config.in
> +++ b/package/mpd/Config.in
> @@ -180,6 +180,12 @@ config BR2_PACKAGE_MPD_CURL
>  	help
>  	  Enable curl streaming (http) support.
>  
> +config BR2_PACKAGE_MPD_LIBMMS
> +	bool "mms"
> +	select BR2_PACKAGE_LIBMMS
> +	help
> +	  Enable MMS support.

Shouldn't we propagate the dependencies of the libmms package ?

I suppose most (all ?) of them are already covered by the
BR2_PACKAGE_MPD option, but shouldn't we propagate them anyway, in case
we change the dependencies of BR2_PACKAGE_MPD in the future ?

Do we a clear policy on this ?

Thomas
Fabrice Fontaine April 17, 2018, 5:25 p.m. | #2
Dear Thomas,

2018-04-09 11:15 GMT+02:00 Thomas Petazzoni <thomas.petazzoni@bootlin.com>:

> Hello,
>
> On Sat,  7 Apr 2018 13:52:30 +0200, Fabrice Fontaine wrote:
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/mpd/Config.in | 6 ++++++
> >  package/mpd/mpd.mk    | 7 +++++++
> >  2 files changed, 13 insertions(+)
> >
> > diff --git a/package/mpd/Config.in b/package/mpd/Config.in
> > index 6c7468e173..831e4ab0d7 100644
> > --- a/package/mpd/Config.in
> > +++ b/package/mpd/Config.in
> > @@ -180,6 +180,12 @@ config BR2_PACKAGE_MPD_CURL
> >       help
> >         Enable curl streaming (http) support.
> >
> > +config BR2_PACKAGE_MPD_LIBMMS
> > +     bool "mms"
> > +     select BR2_PACKAGE_LIBMMS
> > +     help
> > +       Enable MMS support.
>
> Shouldn't we propagate the dependencies of the libmms package ?
>
> I suppose most (all ?) of them are already covered by the
> BR2_PACKAGE_MPD option, but shouldn't we propagate them anyway, in case
> we change the dependencies of BR2_PACKAGE_MPD in the future ?
>
> Do we a clear policy on this ?
>
All libmms dependencies are already covered by mpd package.
It don't know if we have a clear policy for all packages.
However, for samba support, BR2_USE_MMU, BR2_USE_WCHAR and
BR2_TOOLCHAIN_HAS_THREADS_NPTL have not been propagated to mpd.
Same thing for jack support and BR2_USE_MMU / BR2_TOOLCHAIN_HAS_THREADS.

>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
>

Best Regards,

Fabrice
<div dir="ltr">Dear Thomas,<br><div class="gmail_extra"><br><div class="gmail_quote">2018-04-09 11:15 GMT+02:00 Thomas Petazzoni <span dir="ltr">&lt;<a href="mailto:thomas.petazzoni@bootlin.com" target="_blank">thomas.petazzoni@bootlin.com</a>&gt;</span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br>
<span class="gmail-"><br>
On Sat,  7 Apr 2018 13:52:30 +0200, Fabrice Fontaine wrote:<br>
&gt; Signed-off-by: Fabrice Fontaine &lt;<a href="mailto:fontaine.fabrice@gmail.com">fontaine.fabrice@gmail.com</a>&gt;<br>
&gt; ---<br>
&gt;  package/mpd/Config.in | 6 ++++++<br>
&gt;  package/mpd/<a href="http://mpd.mk" rel="noreferrer" target="_blank">mpd.mk</a>    | 7 +++++++<br>
&gt;  2 files changed, 13 insertions(+)<br>
&gt; <br>
&gt; diff --git a/package/mpd/Config.in b/package/mpd/Config.in<br>
&gt; index 6c7468e173..831e4ab0d7 100644<br>
&gt; --- a/package/mpd/Config.in<br>
&gt; +++ b/package/mpd/Config.in<br>
&gt; @@ -180,6 +180,12 @@ config BR2_PACKAGE_MPD_CURL<br>
&gt;       help<br>
&gt;         Enable curl streaming (http) support.<br>
&gt;  <br>
&gt; +config BR2_PACKAGE_MPD_LIBMMS<br>
&gt; +     bool &quot;mms&quot;<br>
&gt; +     select BR2_PACKAGE_LIBMMS<br>
&gt; +     help<br>
&gt; +       Enable MMS support.<br>
<br>
</span>Shouldn&#39;t we propagate the dependencies of the libmms package ?<br>
<br>
I suppose most (all ?) of them are already covered by the<br>
BR2_PACKAGE_MPD option, but shouldn&#39;t we propagate them anyway, in case<br>
we change the dependencies of BR2_PACKAGE_MPD in the future ?<br>
<br>
Do we a clear policy on this ?<br></blockquote><div>All libmms dependencies are already covered by mpd package.<br>It don&#39;t know if we have a clear policy for all packages.<br>However, for samba support, BR2_USE_MMU, BR2_USE_WCHAR and BR2_TOOLCHAIN_HAS_THREADS_NPTL have not been propagated to mpd.<br></div><div>Same thing for jack support and BR2_USE_MMU / BR2_TOOLCHAIN_HAS_THREADS.<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="gmail-HOEnZb"><font color="#888888"><br>
Thomas<br>
-- <br>
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)<br>
Embedded Linux and Kernel engineering<br>
<a href="https://bootlin.com" rel="noreferrer" target="_blank">https://bootlin.com</a><br>
</font></span></blockquote></div><br></div><div class="gmail_extra">Best Regards,<br><br></div><div class="gmail_extra">Fabrice<br></div></div>

Patch

diff --git a/package/mpd/Config.in b/package/mpd/Config.in
index 6c7468e173..831e4ab0d7 100644
--- a/package/mpd/Config.in
+++ b/package/mpd/Config.in
@@ -180,6 +180,12 @@  config BR2_PACKAGE_MPD_CURL
 	help
 	  Enable curl streaming (http) support.
 
+config BR2_PACKAGE_MPD_LIBMMS
+	bool "mms"
+	select BR2_PACKAGE_LIBMMS
+	help
+	  Enable MMS support.
+
 config BR2_PACKAGE_MPD_LIBNFS
 	bool "nfs"
 	# libnfs -> libtirpc
diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
index 639c8c1981..64471d4da5 100644
--- a/package/mpd/mpd.mk
+++ b/package/mpd/mpd.mk
@@ -120,6 +120,13 @@  else
 MPD_CONF_OPTS += --disable-libmpdclient
 endif
 
+ifeq ($(BR2_PACKAGE_MPD_LIBMMS),y)
+MPD_DEPENDENCIES += libmms
+MPD_CONF_OPTS += --enable-mms
+else
+MPD_CONF_OPTS += --disable-mms
+endif
+
 ifeq ($(BR2_PACKAGE_MPD_LIBNFS),y)
 MPD_DEPENDENCIES += libnfs
 MPD_CONF_OPTS += --enable-nfs