diff mbox series

verify_type_variant diagnostic tweak (PR tree-optimization/80021)

Message ID 20180407081840.GO8577@tucnak
State New
Headers show
Series verify_type_variant diagnostic tweak (PR tree-optimization/80021) | expand

Commit Message

Jakub Jelinek April 7, 2018, 8:18 a.m. UTC 
Hi!

While it doesn't make much sense to translate these ICE messages (we
unfortunately don't have variants of the diagnostic functions used for ICE
reporting that wouldn't translate), changing the macro also results in
smaller object, before:
   text	   data	    bss	    dec	    hex	filename
 300332	      4	  25672	 326008	  4f978	tree.o
after:
   text	   data	    bss	    dec	    hex	filename
 299759	      4	  25672	 325435	  4f73b	tree.o
as we save (25-1)x the "type variant differs by " string.  Ok for trunk?

2018-04-07  Jakub Jelinek  <jakub@redhat.com>

	PR tree-optimization/80021
	* tree.c (verify_type_variant): Make error call in verify_variant_match
	translatable and remove final full stop.


	Jakub

Comments

Richard Biener April 7, 2018, 10:53 a.m. UTC | #1 
On April 7, 2018 10:18:40 AM GMT+02:00, Jakub Jelinek <jakub@redhat.com> wrote:
>Hi!
>
>While it doesn't make much sense to translate these ICE messages (we
>unfortunately don't have variants of the diagnostic functions used for
>ICE
>reporting that wouldn't translate), changing the macro also results in
>smaller object, before:
>   text	   data	    bss	    dec	    hex	filename
> 300332	      4	  25672	 326008	  4f978	tree.o
>after:
>   text	   data	    bss	    dec	    hex	filename
> 299759	      4	  25672	 325435	  4f73b	tree.o
>as we save (25-1)x the "type variant differs by " string.  Ok for
>trunk?

OK. 

Richard. 

>2018-04-07  Jakub Jelinek  <jakub@redhat.com>
>
>	PR tree-optimization/80021
>	* tree.c (verify_type_variant): Make error call in
>verify_variant_match
>	translatable and remove final full stop.
>
>--- gcc/tree.c.jj	2018-03-14 17:34:23.693315228 +0100
>+++ gcc/tree.c	2018-04-07 10:05:57.000901421 +0200
>@@ -13035,7 +13035,7 @@ verify_type_variant (const_tree t, tree
>   do {									    \
>     if (flag (tv) != flag (t))						    \
>       {									    \
>-	error ("type variant differs by " #flag ".");			    \
>+	error ("type variant differs by %s", #flag);			    \
> 	debug_tree (tv);						    \
> 	return false;							    \
>       }									    \
>
>	Jakub
diff mbox series

Patch

--- gcc/tree.c.jj	2018-03-14 17:34:23.693315228 +0100
+++ gcc/tree.c	2018-04-07 10:05:57.000901421 +0200
@@ -13035,7 +13035,7 @@  verify_type_variant (const_tree t, tree
   do {									    \
     if (flag (tv) != flag (t))						    \
       {									    \
-	error ("type variant differs by " #flag ".");			    \
+	error ("type variant differs by %s", #flag);			    \
 	debug_tree (tv);						    \
 	return false;							    \
       }									    \