| Message ID | 1523052678-5715-1-git-send-email-debmc@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | opal: mem_info: Designate property optional | expand |
On 2018-04-06 03:11 PM, Deb McLemore wrote: > Some properties do not apply per platform. > > Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com> > --- > src/opal/mem_info.c | 19 ++++++------------- > 1 file changed, 6 insertions(+), 13 deletions(-) > > diff --git a/src/opal/mem_info.c b/src/opal/mem_info.c > index 47b26ca..498449d 100644 > --- a/src/opal/mem_info.c > +++ b/src/opal/mem_info.c > @@ -406,24 +406,17 @@ static int get_linux_mem_devices(fwts_framework *fw) > fwts_log_nl(fw); > > if (!found) { > - failures++; > - fwts_failed(fw, LOG_LEVEL_CRITICAL, > - "OPAL MEM Info", > - "No MEM devices (memory-buffer@X) were found" > - " in \"%s\". Check the system for setup" > - " issues.", > + fwts_skipped(fw, "OPAL MEM Info MEM devices " > + "(memory-buffer@X) found in \"%s\"," > + " not applicable for version.", > DT_FS_PATH); > } > > if (!found_dimm) { > - failures++; > fwts_log_nl(fw); > - fwts_failed(fw, LOG_LEVEL_CRITICAL, > - "OPAL MEM Info", > - "No MEM DIMM devices (memory-buffer) were found" > - " in \"%s\" with a status of \"okay\" or \"ok\"." > - " This is unexpected so please check your" > - " system setup for issues.", > + fwts_skipped(fw, "OPAL MEM Info MEM DIMM devices " > + "(memory-buffer@X) found in \"%s\"," > + " not applicable for version.", > DT_FS_PATH); > } > > Acked-by: Alex Hung <alex.hung@canonical.com>
On 04/07/2018 06:11 AM, Deb McLemore wrote: > Some properties do not apply per platform. > > Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com> > --- > src/opal/mem_info.c | 19 ++++++------------- > 1 file changed, 6 insertions(+), 13 deletions(-) > > diff --git a/src/opal/mem_info.c b/src/opal/mem_info.c > index 47b26ca..498449d 100644 > --- a/src/opal/mem_info.c > +++ b/src/opal/mem_info.c > @@ -406,24 +406,17 @@ static int get_linux_mem_devices(fwts_framework *fw) > fwts_log_nl(fw); > > if (!found) { > - failures++; > - fwts_failed(fw, LOG_LEVEL_CRITICAL, > - "OPAL MEM Info", > - "No MEM devices (memory-buffer@X) were found" > - " in \"%s\". Check the system for setup" > - " issues.", > + fwts_skipped(fw, "OPAL MEM Info MEM devices " > + "(memory-buffer@X) found in \"%s\"," > + " not applicable for version.", > DT_FS_PATH); > } > > if (!found_dimm) { > - failures++; > fwts_log_nl(fw); > - fwts_failed(fw, LOG_LEVEL_CRITICAL, > - "OPAL MEM Info", > - "No MEM DIMM devices (memory-buffer) were found" > - " in \"%s\" with a status of \"okay\" or \"ok\"." > - " This is unexpected so please check your" > - " system setup for issues.", > + fwts_skipped(fw, "OPAL MEM Info MEM DIMM devices " > + "(memory-buffer@X) found in \"%s\"," > + " not applicable for version.", > DT_FS_PATH); > } > > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/opal/mem_info.c b/src/opal/mem_info.c index 47b26ca..498449d 100644 --- a/src/opal/mem_info.c +++ b/src/opal/mem_info.c @@ -406,24 +406,17 @@ static int get_linux_mem_devices(fwts_framework *fw) fwts_log_nl(fw); if (!found) { - failures++; - fwts_failed(fw, LOG_LEVEL_CRITICAL, - "OPAL MEM Info", - "No MEM devices (memory-buffer@X) were found" - " in \"%s\". Check the system for setup" - " issues.", + fwts_skipped(fw, "OPAL MEM Info MEM devices " + "(memory-buffer@X) found in \"%s\"," + " not applicable for version.", DT_FS_PATH); } if (!found_dimm) { - failures++; fwts_log_nl(fw); - fwts_failed(fw, LOG_LEVEL_CRITICAL, - "OPAL MEM Info", - "No MEM DIMM devices (memory-buffer) were found" - " in \"%s\" with a status of \"okay\" or \"ok\"." - " This is unexpected so please check your" - " system setup for issues.", + fwts_skipped(fw, "OPAL MEM Info MEM DIMM devices " + "(memory-buffer@X) found in \"%s\"," + " not applicable for version.", DT_FS_PATH); }
Some properties do not apply per platform. Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com> --- src/opal/mem_info.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-)