| Message ID | 1523045994-14189-1-git-send-email-debmc@linux.vnet.ibm.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | devicetree: dt_base: Make dtc warnings informational | expand |
On 2018-04-06 01:19 PM, Deb McLemore wrote: > Most dtc warnings are not issues so make the information > available for review. > > Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com> > --- > src/devicetree/dt_base/dt_base.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/devicetree/dt_base/dt_base.c b/src/devicetree/dt_base/dt_base.c > index ead965f..666c1b0 100644 > --- a/src/devicetree/dt_base/dt_base.c > +++ b/src/devicetree/dt_base/dt_base.c > @@ -109,10 +109,13 @@ static int dt_base_check_warnings(fwts_framework *fw) > } > > if (out_len > 0) { > - fwts_failed(fw, LOG_LEVEL_MEDIUM, > - "DeviceTreeBaseDTCWarnings", > - "dtc reports warnings from device tree:%s", > + fwts_passed(fw, "Some warnings from dtc. " > + "Run comand \"dtc -I fs -O dts -o my.dts " > + "/sys/firmware/devicetree/base\" for " > + "further review"); Putting a warning messages as parts of pass is somehow awkward. Will fwts_warning(fw, "Some warning ...) be more suitable here? > + fwts_advice(fw, "Review dtc findings: %s", > output); > + ret = FWTS_OK; > goto err; > } > >
<div class="socmaildefaultfont" dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div dir="ltr" >It seems that calling out the dtc warnings as "warnings" alarms most consumers and since we advise no action necessary then the question is then why are they warnings ?</div>
<div dir="ltr" > </div>
<div dir="ltr" >Valid concern, however to try to "quiet" them we thought this may be best.</div>
<div dir="ltr" >=====================================<br>Deb McLemore<br>IBM OpenPower - IBM Systems<br>(512) 286 9980<br><br>debmc@us.ibm.com<br>debmc@linux.vnet.ibm.com - (plain text)<br>=====================================</div>
<div dir="ltr" > </div>
<div dir="ltr" > </div>
<blockquote data-history-content-modified="1" dir="ltr" style="border-left:solid #aaaaaa 2px; margin-left:5px; padding-left:5px; direction:ltr; margin-right:0px" >----- Original message -----<br>From: Alex Hung <alex.hung@canonical.com><br>Sent by: "fwts-devel" <fwts-devel-bounces@lists.ubuntu.com><br>To: fwts-devel@lists.ubuntu.com<br>Cc:<br>Subject: Re: [PATCH] devicetree: dt_base: Make dtc warnings informational<br>Date: Fri, Apr 6, 2018 3:43 PM<br>
<div><font size="2" face="Default Monospace,Courier New,Courier,monospace" >On 2018-04-06 01:19 PM, Deb McLemore wrote:<br>> Most dtc warnings are not issues so make the information<br>> available for review.<br>><br>> Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com><br>> ---<br>> src/devicetree/dt_base/dt_base.c | 9 ++++++---<br>> 1 file changed, 6 insertions(+), 3 deletions(-)<br>><br>> diff --git a/src/devicetree/dt_base/dt_base.c b/src/devicetree/dt_base/dt_base.c<br>> index ead965f..666c1b0 100644<br>> --- a/src/devicetree/dt_base/dt_base.c<br>> +++ b/src/devicetree/dt_base/dt_base.c<br>> @@ -109,10 +109,13 @@ static int dt_base_check_warnings(fwts_framework *fw)<br>> }<br>> <br>> if (out_len > 0) {<br>> - fwts_failed(fw, LOG_LEVEL_MEDIUM,<br>> - "DeviceTreeBaseDTCWarnings",<br>> - "dtc reports warnings from device tree:%s",<br>> + fwts_passed(fw, "Some warnings from dtc. "<br>> + "Run comand \"dtc -I fs -O dts -o my.dts "<br>> + "/sys/firmware/devicetree/base\" for "<br>> + "further review");<br><br>Putting a warning messages as parts of pass is somehow awkward. Will<br>fwts_warning(fw, "Some warning ...) be more suitable here?<br><br><br>> + fwts_advice(fw, "Review dtc findings: %s",<br>> output);<br>> + ret = FWTS_OK;<br>> goto err;<br>> }<br>> <br>><br><br><br>--<br>Cheers,<br>Alex Hung<br><br>--<br>fwts-devel mailing list<br>fwts-devel@lists.ubuntu.com<br>Modify settings or unsubscribe at: <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ubuntu.com_mailman_listinfo_fwts-2Ddevel&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=V3KRDPsp3yMosW9R4elWYg&m=HDEEqh-nQRIzTXZ1JPaziP17ARgzZyvyvKBhSrCkVH0&s=soGqrb_vb61U9OExM-s4pgRtIKh5hzgHl-ds4n_lkyI&e=" target="_blank" >https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ubuntu.com_mailman_listinfo_fwts-2Ddevel&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=V3KRDPsp3yMosW9R4elWYg&m=HDEEqh-nQRIzTXZ1JPaziP17ARgzZyvyvKBhSrCkVH0&s=soGqrb_vb61U9OExM-s4pgRtIKh5hzgHl-ds4n_lkyI&e=</a></font><br> </div></blockquote>
<div dir="ltr" > </div></div><BR>
On 2018-04-07 03:45, Deborah McLemore wrote: > It seems that calling out the dtc warnings as "warnings" alarms most > consumers and since we advise no action necessary then the question is > then why are they warnings ? > > Valid concern, however to try to "quiet" them we thought this may be > best. I agree with alex here, a dtc warning should report as fwts warning, as we want the device tree should be according to the spec standards. It will help developers to catch these warnings and fix them in early stage. Thanks Pridhiviraj > ===================================== > Deb McLemore > IBM OpenPower - IBM Systems > (512) 286 9980 > > debmc@us.ibm.com > debmc@linux.vnet.ibm.com - (plain text) > ===================================== > >> ----- Original message ----- >> From: Alex Hung <alex.hung@canonical.com> >> Sent by: "fwts-devel" <fwts-devel-bounces@lists.ubuntu.com> >> To: fwts-devel@lists.ubuntu.com >> Cc: >> Subject: Re: [PATCH] devicetree: dt_base: Make dtc warnings >> informational >> Date: Fri, Apr 6, 2018 3:43 PM >> >> On 2018-04-06 01:19 PM, Deb McLemore wrote: >>> Most dtc warnings are not issues so make the information >>> available for review. >>> >>> Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com> >>> --- >>> src/devicetree/dt_base/dt_base.c | 9 ++++++--- >>> 1 file changed, 6 insertions(+), 3 deletions(-) >>> >>> diff --git a/src/devicetree/dt_base/dt_base.c >> b/src/devicetree/dt_base/dt_base.c >>> index ead965f..666c1b0 100644 >>> --- a/src/devicetree/dt_base/dt_base.c >>> +++ b/src/devicetree/dt_base/dt_base.c >>> @@ -109,10 +109,13 @@ static int >> dt_base_check_warnings(fwts_framework *fw) >>> } >>> >>> if (out_len > 0) { >>> - fwts_failed(fw, LOG_LEVEL_MEDIUM, >>> - "DeviceTreeBaseDTCWarnings", >>> - "dtc reports warnings from device tree:%s", >>> + fwts_passed(fw, "Some warnings from dtc. " >>> + "Run comand "dtc -I fs -O dts -o my.dts " >>> + "/sys/firmware/devicetree/base" for " >>> + "further review"); >> >> Putting a warning messages as parts of pass is somehow awkward. Will >> fwts_warning(fw, "Some warning ...) be more suitable here? >> >>> + fwts_advice(fw, "Review dtc findings: %s", >>> output); >>> + ret = FWTS_OK; >>> goto err; >>> } >>> >>> >> >> -- >> Cheers, >> Alex Hung >> >> -- >> fwts-devel mailing list >> fwts-devel@lists.ubuntu.com >> Modify settings or unsubscribe at: >> > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ubuntu.com_mailman_listinfo_fwts-2Ddevel&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=V3KRDPsp3yMosW9R4elWYg&m=HDEEqh-nQRIzTXZ1JPaziP17ARgzZyvyvKBhSrCkVH0&s=soGqrb_vb61U9OExM-s4pgRtIKh5hzgHl-ds4n_lkyI&e= >> [1] > > > > Links: > ------ > [1] > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ubuntu.com_mailman_listinfo_fwts-2Ddevel&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=V3KRDPsp3yMosW9R4elWYg&m=HDEEqh-nQRIzTXZ1JPaziP17ARgzZyvyvKBhSrCkVH0&s=soGqrb_vb61U9OExM-s4pgRtIKh5hzgHl-ds4n_lkyI&e=
<div class="socmaildefaultfont" dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div dir="ltr" >Agree on fixing what are real issues, its the warnings we flag that we have to respond to individually to say "yeah, ignore that" since</div>
<div dir="ltr" >for various reasons the developers do not make changes or are functionally trying to keep for some compatibility reasons.</div>
<div dir="ltr" > </div>
<div dir="ltr" >But yes, I can change it to warning message, that will improve it.</div>
<div dir="ltr" > </div>
<div dir="ltr" >New patch will be sent.</div>
<div dir="ltr" >=====================================<br>Deb McLemore<br>IBM OpenPower - IBM Systems<br>(512) 286 9980<br><br>debmc@us.ibm.com<br>debmc@linux.vnet.ibm.com - (plain text)<br>=====================================</div>
<div dir="ltr" > </div>
<div dir="ltr" > </div>
<blockquote data-history-content-modified="1" dir="ltr" style="border-left:solid #aaaaaa 2px; margin-left:5px; padding-left:5px; direction:ltr; margin-right:0px" >----- Original message -----<br>From: ppaidipe <ppaidipe@linux.vnet.ibm.com><br>To: Deborah McLemore/Austin/IBM@IBMUS<br>Cc: alex.hung@canonical.com, fwts-devel@lists.ubuntu.com<br>Subject: Re: [PATCH] devicetree: dt_base: Make dtc warnings informational<br>Date: Sat, Apr 7, 2018 12:18 PM<br>
<div><font size="2" face="Default Monospace,Courier New,Courier,monospace" >On 2018-04-07 03:45, Deborah McLemore wrote:<br>> It seems that calling out the dtc warnings as "warnings" alarms most<br>> consumers and since we advise no action necessary then the question is<br>> then why are they warnings ?<br>><br>> Valid concern, however to try to "quiet" them we thought this may be<br>> best.<br><br>I agree with alex here, a dtc warning should report as fwts warning, as<br>we want the device tree<br>should be according to the spec standards. It will help developers to<br>catch these warnings and<br>fix them in early stage.<br><br>Thanks<br>Pridhiviraj<br><br>> =====================================<br>> Deb McLemore<br>> IBM OpenPower - IBM Systems<br>> (512) 286 9980<br>><br>> debmc@us.ibm.com<br>> debmc@linux.vnet.ibm.com - (plain text)<br>> =====================================<br>><br>>> ----- Original message -----<br>>> From: Alex Hung <alex.hung@canonical.com><br>>> Sent by: "fwts-devel" <fwts-devel-bounces@lists.ubuntu.com><br>>> To: fwts-devel@lists.ubuntu.com<br>>> Cc:<br>>> Subject: Re: [PATCH] devicetree: dt_base: Make dtc warnings<br>>> informational<br>>> Date: Fri, Apr 6, 2018 3:43 PM<br>>><br>>> On 2018-04-06 01:19 PM, Deb McLemore wrote:<br>>>> Most dtc warnings are not issues so make the information<br>>>> available for review.<br>>>><br>>>> Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com><br>>>> ---<br>>>> src/devicetree/dt_base/dt_base.c | 9 ++++++---<br>>>> 1 file changed, 6 insertions(+), 3 deletions(-)<br>>>><br>>>> diff --git a/src/devicetree/dt_base/dt_base.c<br>>> b/src/devicetree/dt_base/dt_base.c<br>>>> index ead965f..666c1b0 100644<br>>>> --- a/src/devicetree/dt_base/dt_base.c<br>>>> +++ b/src/devicetree/dt_base/dt_base.c<br>>>> @@ -109,10 +109,13 @@ static int<br>>> dt_base_check_warnings(fwts_framework *fw)<br>>>> }<br>>>><br>>>> if (out_len > 0) {<br>>>> - fwts_failed(fw, LOG_LEVEL_MEDIUM,<br>>>> - "DeviceTreeBaseDTCWarnings",<br>>>> - "dtc reports warnings from device tree:%s",<br>>>> + fwts_passed(fw, "Some warnings from dtc. "<br>>>> + "Run comand "dtc -I fs -O dts -o my.dts "<br>>>> + "/sys/firmware/devicetree/base" for "<br>>>> + "further review");<br>>><br>>> Putting a warning messages as parts of pass is somehow awkward. Will<br>>> fwts_warning(fw, "Some warning ...) be more suitable here?<br>>><br>>>> + fwts_advice(fw, "Review dtc findings: %s",<br>>>> output);<br>>>> + ret = FWTS_OK;<br>>>> goto err;<br>>>> }<br>>>><br>>>><br>>><br>>> --<br>>> Cheers,<br>>> Alex Hung<br>>><br>>> --<br>>> fwts-devel mailing list<br>>> fwts-devel@lists.ubuntu.com<br>>> Modify settings or unsubscribe at:<br>>><br>> <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ubuntu.com_mailman_listinfo_fwts-2Ddevel&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=V3KRDPsp3yMosW9R4elWYg&m=HDEEqh-nQRIzTXZ1JPaziP17ARgzZyvyvKBhSrCkVH0&s=soGqrb_vb61U9OExM-s4pgRtIKh5hzgHl-ds4n_lkyI&e=" target="_blank" >https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ubuntu.com_mailman_listinfo_fwts-2Ddevel&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=V3KRDPsp3yMosW9R4elWYg&m=HDEEqh-nQRIzTXZ1JPaziP17ARgzZyvyvKBhSrCkVH0&s=soGqrb_vb61U9OExM-s4pgRtIKh5hzgHl-ds4n_lkyI&e=</a><br>>> [1]<br>><br>><br>><br>> Links:<br>> ------<br>> [1]<br>> <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ubuntu.com_mailman_listinfo_fwts-2Ddevel&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=V3KRDPsp3yMosW9R4elWYg&m=HDEEqh-nQRIzTXZ1JPaziP17ARgzZyvyvKBhSrCkVH0&s=soGqrb_vb61U9OExM-s4pgRtIKh5hzgHl-ds4n_lkyI&e=" target="_blank" >https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ubuntu.com_mailman_listinfo_fwts-2Ddevel&amp;d=DwIGaQ&amp;c=jf_iaSHvJObTbx-siA1ZOg&amp;r=V3KRDPsp3yMosW9R4elWYg&amp;m=HDEEqh-nQRIzTXZ1JPaziP17ARgzZyvyvKBhSrCkVH0&amp;s=soGqrb_vb61U9OExM-s4pgRtIKh5hzgHl-ds4n_lkyI&amp;e=</a></font></div></blockquote>
<div dir="ltr" > </div></div><BR>
diff --git a/src/devicetree/dt_base/dt_base.c b/src/devicetree/dt_base/dt_base.c index ead965f..666c1b0 100644 --- a/src/devicetree/dt_base/dt_base.c +++ b/src/devicetree/dt_base/dt_base.c @@ -109,10 +109,13 @@ static int dt_base_check_warnings(fwts_framework *fw) } if (out_len > 0) { - fwts_failed(fw, LOG_LEVEL_MEDIUM, - "DeviceTreeBaseDTCWarnings", - "dtc reports warnings from device tree:%s", + fwts_passed(fw, "Some warnings from dtc. " + "Run comand \"dtc -I fs -O dts -o my.dts " + "/sys/firmware/devicetree/base\" for " + "further review"); + fwts_advice(fw, "Review dtc findings: %s", output); + ret = FWTS_OK; goto err; }
Most dtc warnings are not issues so make the information available for review. Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com> --- src/devicetree/dt_base/dt_base.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)