Message ID | 1523034681-33787-1-git-send-email-pbonzini@redhat.com |
---|---|
State | New |
Headers | show |
On 6 April 2018 at 18:11, Paolo Bonzini <pbonzini@redhat.com> wrote: > The following changes since commit 0e87fdc966d05f4e5ad868034fcd8ee2a08ca62d: > > Update version for v2.12.0-rc2 release (2018-04-04 20:37:20 +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to 0af74e1178c1f4ba495b499b2ba2a8c7c453b72a: > > Add missing bit for SSE instr in VEX decoding (2018-04-06 18:42:49 +0200) > > ---------------------------------------------------------------- > Miscellaneous bugfixes, including crash fixes from Alexey, Peter M. and > Thomas. > > ---------------------------------------------------------------- This fails to compile on OSX and the BSDs: /Users/pm215/src/qemu-for-merges/util/memfd.c:208:19: error: implicit declaration of function 'memfd_create' is invalid in C99 [-Werror,-Wimplicit-function-declaration] int mfd = memfd_create("test", 0); ^ I also got TEST: tests/boot-serial-test... (pid=15159) /sparc64/boot-serial/sun4u: ** ERROR:/home/petmay01/linaro/qemu-for-merges/tests/boot-serial-test.c:139:check_guest_output: assertion failed: (output_ok) FAIL on an x86-64/linux host, but I have a feeling that's one of our intermittents rather than anything in this patch. thanks -- PMM
On 09/04/2018 11:20, Peter Maydell wrote: > This fails to compile on OSX and the BSDs: > /Users/pm215/src/qemu-for-merges/util/memfd.c:208:19: error: implicit > declaration of function 'memfd_create' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > int mfd = memfd_create("test", 0); > ^ Will fix like this in v2: diff --git a/util/memfd.c b/util/memfd.c index 277f721..b3ecbac 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -202,6 +202,7 @@ bool qemu_memfd_alloc_check(void) */ bool qemu_memfd_check(void) { +#ifdef CONFIG_LINUX static int memfd_check = MEMFD_TODO; if (memfd_check == MEMFD_TODO) { Stage this hunk [y,n,q,a,d,/,j,J,g,e,?]? y @@ -215,4 +216,7 @@ bool qemu_memfd_check(void) } return memfd_check == MEMFD_OK; +#else + return false; +#endif } > > I also got > TEST: tests/boot-serial-test... (pid=15159) > /sparc64/boot-serial/sun4u: ** > ERROR:/home/petmay01/linaro/qemu-for-merges/tests/boot-serial-test.c:139:check_guest_output: > assertion failed: (output_ok) > FAIL > > on an x86-64/linux host, but I have a feeling that's one of > our intermittents rather than anything in this patch.