Patchwork Fix non-portable format string in usb-ccid.c

login
register
mail settings
Submitter David Gibson
Date April 4, 2011, 4:48 a.m.
Message ID <1301892488-15114-1-git-send-email-david@gibson.dropbear.id.au>
Download mbox | patch
Permalink /patch/89577/
State New
Headers show

Comments

David Gibson - April 4, 2011, 4:48 a.m.
At one point, usb-ccid.c attempts to use a %lX format specifier to print
a uint64_t, which is only correct on some host platforms.  This patch
corrects the statement to use the stdint specified PRIX64 constant instead.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/usb-ccid.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Aurelien Jarno - April 4, 2011, 12:43 p.m.
On Mon, Apr 04, 2011 at 02:48:08PM +1000, David Gibson wrote:
> At one point, usb-ccid.c attempts to use a %lX format specifier to print
> a uint64_t, which is only correct on some host platforms.  This patch
> corrects the statement to use the stdint specified PRIX64 constant instead.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>  hw/usb-ccid.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, applied.

> diff --git a/hw/usb-ccid.c b/hw/usb-ccid.c
> index 723b2e3..44156cc 100644
> --- a/hw/usb-ccid.c
> +++ b/hw/usb-ccid.c
> @@ -1199,7 +1199,7 @@ void ccid_card_card_error(CCIDCardState *card, uint64_t error)
>  
>      s->bmCommandStatus = COMMAND_STATUS_FAILED;
>      s->last_answer_error = error;
> -    DPRINTF(s, 1, "VSC_Error: %lX\n", s->last_answer_error);
> +    DPRINTF(s, 1, "VSC_Error: %" PRIX64 "\n", s->last_answer_error);
>      /* TODO: these error's should be more verbose and propogated to the guest.*/
>      /*
>       * We flush all pending answers on CardRemove message in ccid-card-passthru,
> -- 
> 1.7.1
> 
> 
>

Patch

diff --git a/hw/usb-ccid.c b/hw/usb-ccid.c
index 723b2e3..44156cc 100644
--- a/hw/usb-ccid.c
+++ b/hw/usb-ccid.c
@@ -1199,7 +1199,7 @@  void ccid_card_card_error(CCIDCardState *card, uint64_t error)
 
     s->bmCommandStatus = COMMAND_STATUS_FAILED;
     s->last_answer_error = error;
-    DPRINTF(s, 1, "VSC_Error: %lX\n", s->last_answer_error);
+    DPRINTF(s, 1, "VSC_Error: %" PRIX64 "\n", s->last_answer_error);
     /* TODO: these error's should be more verbose and propogated to the guest.*/
     /*
      * We flush all pending answers on CardRemove message in ccid-card-passthru,