[v6,2/2] resolve ihandle and xt handle in the input command (like for the output)

Message ID 20180406084704.29048-3-lvivier@redhat.com
State New
Headers show
Series
  • Fix output word
Related show

Commit Message

Laurent Vivier April 6, 2018, 8:47 a.m.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 slof/fs/term-io.fs | 35 ++++++++++++++++++++++-------------
 1 file changed, 22 insertions(+), 13 deletions(-)

Comments

Thomas Huth April 6, 2018, 10:04 a.m. | #1
On 06.04.2018 10:47, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>  slof/fs/term-io.fs | 35 ++++++++++++++++++++++-------------
>  1 file changed, 22 insertions(+), 13 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>

Patch

diff --git a/slof/fs/term-io.fs b/slof/fs/term-io.fs
index d247b09..f32acdd 100644
--- a/slof/fs/term-io.fs
+++ b/slof/fs/term-io.fs
@@ -10,10 +10,20 @@ 
 \ *     IBM Corporation - initial implementation
 \ ****************************************************************************/
 
+0 VALUE read-xt
 0 VALUE write-xt
 
+VARIABLE stdin
 VARIABLE stdout
 
+: set-stdin ( ihandle -- )
+   \ Close old stdin:
+   stdin @ ?dup IF close-dev THEN
+   \ Now set the new stdin:
+   dup stdin !
+   encode-int s" stdin"  set-chosen
+;
+
 : set-stdout ( ihandle -- )
    \ Close old stdout:
    stdout @ ?dup IF close-dev THEN
@@ -24,12 +34,15 @@  VARIABLE stdout
 
 : input  ( dev-str dev-len -- )
    open-dev ?dup IF
-      \ Close old stdin:
-      s" stdin" get-chosen IF
-         decode-int nip nip ?dup IF close-dev THEN
+      \ find new ihandle and xt handle
+      dup s" read" rot ihandle>phandle find-method
+      0= IF
+         drop
+         cr ." Cannot find the read method for the given input console " cr
+         EXIT
       THEN
-      \ Now set the new stdin:
-      encode-int s" stdin"  set-chosen
+      to read-xt
+      set-stdin
    THEN
 ;
 
@@ -51,7 +64,6 @@  VARIABLE stdout
    2dup input output
 ;
 
-
 1 BUFFER: (term-io-char-buf)
 
 : term-io-emit ( char -- )
@@ -67,14 +79,12 @@  VARIABLE stdout
 ' term-io-emit to emit
 
 : term-io-key  ( -- char )
-   s" stdin" get-chosen IF
-      decode-int nip nip dup 0= IF 0 EXIT THEN
-      >r BEGIN
-         (term-io-char-buf) 1 s" read" r@ $call-method
+   read-xt IF
+      BEGIN
+         (term-io-char-buf) 1 read-xt stdin @ call-package
          0 >
       UNTIL
       (term-io-char-buf) c@
-      r> drop
    ELSE
       [ ' key behavior compile, ]
    THEN
@@ -88,8 +98,7 @@  VARIABLE stdout
 \ - if it's an hv console, use hvterm-key?
 \ otherwise it will always return false
 : term-io-key?  ( -- true|false )
-   s" stdin" get-chosen IF
-      decode-int nip nip dup 0= IF drop 0 EXIT THEN \ return false and exit if no stdin set
+  stdin @ ?dup IF
       >r \ store ihandle on return stack
       s" device_type" r@ ihandle>phandle ( propstr len phandle )
       get-property ( true | data dlen false )