From patchwork Thu Apr 5 14:50:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cyril Hrubis X-Patchwork-Id: 895422 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=213.254.12.146; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40H5QY55KSz9s0y for ; Fri, 6 Apr 2018 00:52:21 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 009C63E792C for ; Thu, 5 Apr 2018 16:52:16 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) by picard.linux.it (Postfix) with ESMTP id 0D0943E7809 for ; Thu, 5 Apr 2018 16:52:02 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 266241A01163 for ; Thu, 5 Apr 2018 16:51:52 +0200 (CEST) Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B7CABAF31 for ; Thu, 5 Apr 2018 14:51:51 +0000 (UTC) From: Cyril Hrubis To: ltp@lists.linux.it Date: Thu, 5 Apr 2018 16:50:13 +0200 Message-Id: <20180405145015.7633-5-chrubis@suse.cz> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180405145015.7633-1-chrubis@suse.cz> References: <20180405145015.7633-1-chrubis@suse.cz> X-Virus-Scanned: clamav-milter 0.99.2 at in-3.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.2 required=7.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS,T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-3.smtp.seeweb.it Subject: [LTP] [RFC PATCH 4/6] syscalls/alarm01: Remove X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" The test was simply wrong alarm() does not return a failure at all. Signed-off-by: Cyril Hrubis --- runtest/ltplite | 1 - runtest/quickhit | 2 - runtest/stress.part3 | 1 - runtest/syscalls | 1 - testcases/kernel/syscalls/.gitignore | 1 - testcases/kernel/syscalls/alarm/alarm01.c | 176 ------------------------------ 6 files changed, 182 deletions(-) delete mode 100644 testcases/kernel/syscalls/alarm/alarm01.c diff --git a/runtest/ltplite b/runtest/ltplite index 15dc0c20f..001325d65 100644 --- a/runtest/ltplite +++ b/runtest/ltplite @@ -71,7 +71,6 @@ acct01 acct01 adjtimex01 adjtimex01 adjtimex02 adjtimex02 -alarm01 alarm01 alarm02 alarm02 alarm03 alarm03 alarm05 alarm05 diff --git a/runtest/quickhit b/runtest/quickhit index 99e7c4779..2a1056971 100644 --- a/runtest/quickhit +++ b/runtest/quickhit @@ -3,8 +3,6 @@ access01 access01 # Basic test for access(2) using F_OK, R_OK, W_OK and X_OK arguments. access03 access03 # EFAULT error testing for access(2) -alarm01 alarm01 -# Basic test for alarm(2) alarm02 alarm02 # Boundary Value Test for alarm(2) # TEST CASES diff --git a/runtest/stress.part3 b/runtest/stress.part3 index 2a7747ce3..0d5951454 100644 --- a/runtest/stress.part3 +++ b/runtest/stress.part3 @@ -13,7 +13,6 @@ acct01 acct01 adjtimex01 adjtimex01 adjtimex02 adjtimex02 -alarm01 alarm01 alarm02 alarm02 alarm03 alarm03 alarm05 alarm05 diff --git a/runtest/syscalls b/runtest/syscalls index 76ab082be..71cfd2d6f 100644 --- a/runtest/syscalls +++ b/runtest/syscalls @@ -19,7 +19,6 @@ add_key04 add_key04 adjtimex01 adjtimex01 adjtimex02 adjtimex02 -alarm01 alarm01 alarm02 alarm02 alarm03 alarm03 alarm05 alarm05 diff --git a/testcases/kernel/syscalls/.gitignore b/testcases/kernel/syscalls/.gitignore index eea606e61..cd80cfc8f 100644 --- a/testcases/kernel/syscalls/.gitignore +++ b/testcases/kernel/syscalls/.gitignore @@ -12,7 +12,6 @@ /add_key/add_key04 /adjtimex/adjtimex01 /adjtimex/adjtimex02 -/alarm/alarm01 /alarm/alarm02 /alarm/alarm03 /alarm/alarm05 diff --git a/testcases/kernel/syscalls/alarm/alarm01.c b/testcases/kernel/syscalls/alarm/alarm01.c deleted file mode 100644 index f17207b0a..000000000 --- a/testcases/kernel/syscalls/alarm/alarm01.c +++ /dev/null @@ -1,176 +0,0 @@ -/* - * Copyright (c) 2000 Silicon Graphics, Inc. All Rights Reserved. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms of version 2 of the GNU General Public License as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it would be useful, but - * WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. - * - * Further, this software is distributed without any warranty that it is - * free of the rightful claim of any third person regarding infringement - * or the like. Any license provided herein, whether implied or - * otherwise, applies only to this software file. Patent licenses, if - * any, provided herein do not apply to combinations of this program with - * other software, or any other product whatsoever. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Contact information: Silicon Graphics, Inc., 1600 Amphitheatre Pkwy, - * Mountain View, CA 94043, or: - * - * http://www.sgi.com - * - * For further information regarding this notice, see: - * - * http://oss.sgi.com/projects/GenInfo/NoticeExplan/ - */ -/* $Id: alarm01.c,v 1.6 2009/08/28 10:57:29 vapier Exp $ */ -/********************************************************** - * - * OS Test - Silicon Graphics, Inc. - * - * TEST IDENTIFIER : alarm01 - * - * EXECUTED BY : anyone - * - * TEST TITLE : Basic test for alarm(2) - * - * PARENT DOCUMENT : usctpl01 - * - * TEST CASE TOTAL : 1 - * - * WALL CLOCK TIME : 1 - * - * CPU TYPES : ALL - * - * AUTHOR : William Roske - * - * CO-PILOT : Dave Fenner - * - * DATE STARTED : 03/30/92 - * - * INITIAL RELEASE : UNICOS 7.0 - * - * TEST CASES - * - * 1.) alarm(2) returns...(See Description) - * - * INPUT SPECIFICATIONS - * The standard options for system call tests are accepted. - * (See the parse_opts(3) man page). - * - * OUTPUT SPECIFICATIONS - *$ - * DURATION - * Terminates - with frequency and infinite modes. - * - * SIGNALS - * Uses SIGUSR1 to pause before test if option set. - * (See the parse_opts(3) man page). - * - * RESOURCES - * None - * - * ENVIRONMENTAL NEEDS - * The libcuts.a and libsys.a libraries must be included in - * the compilation of this test. - * - * SPECIAL PROCEDURAL REQUIREMENTS - * None - * - * INTERCASE DEPENDENCIES - * None - * - * DETAILED DESCRIPTION - * This is a Phase I test for the alarm(2) system call. It is intended - * to provide a limited exposure of the system call, for now. It - * should/will be extended when full functional tests are written for - * alarm(2). - * - * Setup: - * Setup signal handling. - * Pause for SIGUSR1 if option specified. - * - * Test: - * Loop if the proper options are given. - * Execute system call - * Check return code, if system call failed (return=-1) - * Log the errno and Issue a FAIL message. - * Otherwise, Issue a PASS message. - * - * Cleanup: - * Print errno log and/or timing stats if options given - * - * - *#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#**/ - -#include -#include -#include -#include "test.h" - -void setup(); -void cleanup(); - -char *TCID = "alarm01"; -int TST_TOTAL = 1; - -int main(int ac, char **av) -{ - int lc; - - tst_parse_opts(ac, av, NULL, NULL); - - setup(); - - for (lc = 0; TEST_LOOPING(lc); lc++) { - - tst_count = 0; - - /* - * Call alarm(2) - */ - TEST(alarm(1)); - - /* check return code */ - if (TEST_RETURN == -1) - tst_resm(TFAIL | TTERRNO, "alarm(1) failed"); - else { - tst_resm(TPASS, "alarm(1) returned %ld", - TEST_RETURN); - } - - } - - cleanup(); - tst_exit(); -} - -void setup(void) -{ - void trapper(); - - tst_sig(NOFORK, DEF_HANDLER, cleanup); - - signal(SIGALRM, trapper); - - TEST_PAUSE; -} - -/*************************************************************** - * cleanup() - performs all ONE TIME cleanup for this test at - * completion or premature exit. - ***************************************************************/ -void cleanup(void) -{ -} - -void trapper(int sig) -{ - signal(SIGALRM, trapper); -}