cifs: Use ULL suffix for 64-bit constant

Message ID 1522933031-25574-1-git-send-email-geert@linux-m68k.org
State New
Headers show
Series
  • cifs: Use ULL suffix for 64-bit constant
Related show

Commit Message

Geert Uytterhoeven April 5, 2018, 12:57 p.m.
On 32-bit (e.g. with m68k-linux-gnu-gcc-4.1):

    fs/cifs/inode.c: In function ‘simple_hashstr’:
    fs/cifs/inode.c:713: warning: integer constant is too large for ‘long’ type

Fixes: 7ea884c77e5c97f1 ("smb3: Fix root directory when server returns inode number of zero")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 fs/cifs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Aurélien Aptel April 10, 2018, 9:35 a.m. | #1
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> On 32-bit (e.g. with m68k-linux-gnu-gcc-4.1):
>
>     fs/cifs/inode.c: In function ‘simple_hashstr’:
>     fs/cifs/inode.c:713: warning: integer constant is too large for ‘long’ type
>
> Fixes: 7ea884c77e5c97f1 ("smb3: Fix root directory when server returns inode number of zero")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

this is already in Steve's for-next, marking as reviewed:

Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Steve French April 10, 2018, 12:51 p.m. | #2
Aurelien,
Added your reviewed-by and repushed to cifs-2.6.git for-next

On Tue, Apr 10, 2018 at 4:35 AM, Aurélien Aptel via samba-technical
<samba-technical@lists.samba.org> wrote:
> Geert Uytterhoeven <geert@linux-m68k.org> writes:
>> On 32-bit (e.g. with m68k-linux-gnu-gcc-4.1):
>>
>>     fs/cifs/inode.c: In function ‘simple_hashstr’:
>>     fs/cifs/inode.c:713: warning: integer constant is too large for ‘long’ type
>>
>> Fixes: 7ea884c77e5c97f1 ("smb3: Fix root directory when server returns inode number of zero")
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> this is already in Steve's for-next, marking as reviewed:
>
> Reviewed-by: Aurelien Aptel <aaptel@suse.com>
>
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
>

Patch

diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index f856df4adae3c8e8..3c371f7f5963e793 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -710,7 +710,7 @@  cifs_get_file_info(struct file *filp)
 /* Simple function to return a 64 bit hash of string.  Rarely called */
 static __u64 simple_hashstr(const char *str)
 {
-	const __u64 hash_mult =  1125899906842597L; /* a big enough prime */
+	const __u64 hash_mult =  1125899906842597ULL; /* a big enough prime */
 	__u64 hash = 0;
 
 	while (*str)