[1/2] lib/test_net.sh: lower default test parameters

Message ID 1522926355-18029-1-git-send-email-alexey.kodanev@oracle.com
State New
Delegated to: Alexey Kodanev
Headers show
Series
  • [1/2] lib/test_net.sh: lower default test parameters
Related show

Commit Message

Alexey Kodanev April 5, 2018, 11:05 a.m.
Default scenario should not take hours to complete.

Also export TST_NETLOAD_CLN_REQUESTS which is used by all
tst_netload tests and can control the test execution time.

Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
---
 testcases/lib/test_net.sh |   15 ++++++++-------
 1 files changed, 8 insertions(+), 7 deletions(-)

Comments

Petr Vorel April 5, 2018, 1:40 p.m. | #1
Hi Alexey,

> Default scenario should not take hours to complete.
Great, agree.

> Also export TST_NETLOAD_CLN_REQUESTS which is used by all
> tst_netload tests and can control the test execution time.

> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
> ---
>  testcases/lib/test_net.sh |   15 ++++++++-------
>  1 files changed, 8 insertions(+), 7 deletions(-)

> diff --git a/testcases/lib/test_net.sh b/testcases/lib/test_net.sh
> index 203464f..2f7668f 100644
> --- a/testcases/lib/test_net.sh
> +++ b/testcases/lib/test_net.sh
> @@ -651,20 +651,21 @@ if [ -z "$TST_PARSE_VARIABLES" ]; then
>  	export TST_PARSE_VARIABLES="yes"
>  fi

> +export TST_NETLOAD_CLN_REQUESTS="${TST_NETLOAD_CLN_REQUESTS:-10000}"
This variable is also in testcases/network/sockets/bind_noport01.sh, shouldn't you remove
it from there (it uses test_net.sh).

Also, why not to handle the same way TST_NETLOAD_CLN_NUMBER ?
(also used in tst_netload).

And I'd put it into separate commit.


Kind regards,
Petr
Alexey Kodanev April 12, 2018, 12:22 p.m. | #2
On 05.04.2018 16:40, Petr Vorel wrote:
> Hi Alexey,
> 
>> Default scenario should not take hours to complete.
> Great, agree.
> 
>> Also export TST_NETLOAD_CLN_REQUESTS which is used by all
>> tst_netload tests and can control the test execution time.
> 
...
>> +export TST_NETLOAD_CLN_REQUESTS="${TST_NETLOAD_CLN_REQUESTS:-10000}"
> This variable is also in testcases/network/sockets/bind_noport01.sh, shouldn't you remove
> it from there (it uses test_net.sh).
> 
> Also, why not to handle the same way TST_NETLOAD_CLN_NUMBER ?
> (also used in tst_netload).
> 
> And I'd put it into separate commit.

Applied, the changes with TST_NETLOAD_CLN* are in the separate commit.

Thanks,
Alexey

Patch

diff --git a/testcases/lib/test_net.sh b/testcases/lib/test_net.sh
index 203464f..2f7668f 100644
--- a/testcases/lib/test_net.sh
+++ b/testcases/lib/test_net.sh
@@ -651,20 +651,21 @@  if [ -z "$TST_PARSE_VARIABLES" ]; then
 	export TST_PARSE_VARIABLES="yes"
 fi
 
+export TST_NETLOAD_CLN_REQUESTS="${TST_NETLOAD_CLN_REQUESTS:-10000}"
 export HTTP_DOWNLOAD_DIR="${HTTP_DOWNLOAD_DIR:-/var/www/html}"
 export FTP_DOWNLOAD_DIR="${FTP_DOWNLOAD_DIR:-/var/ftp}"
 export FTP_UPLOAD_DIR="${FTP_UPLOAD_DIR:-/var/ftp/pub}"
 export FTP_UPLOAD_URLDIR="${FTP_UPLOAD_URLDIR:-pub}"
 
 # network/stress tests require additional parameters
-export NS_DURATION="${NS_DURATION:-720}"
-export NS_TIMES="${NS_TIMES:-2000}"
-export CONNECTION_TOTAL="${CONNECTION_TOTAL:-4000}"
-export IP_TOTAL="${IP_TOTAL:-2000}"
+export NS_DURATION="${NS_DURATION:-10}"
+export NS_TIMES="${NS_TIMES:-10}"
+export CONNECTION_TOTAL="${CONNECTION_TOTAL:-10}"
+export IP_TOTAL="${IP_TOTAL:-100}"
 export IP_TOTAL_FOR_TCPIP="${IP_TOTAL_FOR_TCPIP:-100}"
-export ROUTE_TOTAL="${ROUTE_TOTAL:-2000}"
-export MTU_CHANGE_TIMES="${MTU_CHANGE_TIMES:-1000}"
-export IF_UPDOWN_TIMES="${IF_UPDOWN_TIMES:-2000}"
+export ROUTE_TOTAL="${ROUTE_TOTAL:-100}"
+export MTU_CHANGE_TIMES="${MTU_CHANGE_TIMES:-100}"
+export IF_UPDOWN_TIMES="${IF_UPDOWN_TIMES:-100}"
 export DOWNLOAD_BIGFILESIZE="${DOWNLOAD_BIGFILESIZE:-2147483647}"
 export DOWNLOAD_REGFILESIZE="${DOWNLOAD_REGFILESIZE:-1048576}"
 export UPLOAD_BIGFILESIZE="${UPLOAD_BIGFILESIZE:-2147483647}"