Patchwork [testsuite,fortran] Compile gfortran.dg/bessel_[67].f90 with -mieee

login
register
mail settings
Submitter Tobias Burnus
Date April 3, 2011, 4:04 p.m.
Message ID <4D989AA7.9010607@net-b.de>
Download mbox | patch
Permalink /patch/89529/
State New
Headers show

Comments

Tobias Burnus - April 3, 2011, 4:04 p.m.
Regarding Bessel_6: I have committed the attached patch.

Rainer Orth wrote:
> What about the following patch that fixes at least bessel_7.f90?
>
> Tested with the appropriate runtest invocations on the 4.6 branch
> (couldn't test mainline since bootstrap was broken there).
>
> Ok for mainline, 4.6 and 4.5 branches once tested?

OK.

> I've also had a look at the other gfortran testsuite failures on Tru64
> UNIX V5.1B and IRIX 6.5 that couldn't be fixed that easily.
> How to best report them and have them investigated?  I suspect that
> there might be only a few common issues, so a PR per failing testcase
> might be overkill, while a single one for all failures is hard to deal with.

No idea. I would go for only one or few PRs, one can still extend it to 
several. Maybe one could also restrict one to few issues as a starter.

Tobias
Rainer Orth - April 4, 2011, 7:01 p.m.
Tobias Burnus <burnus@net-b.de> writes:

>> I've also had a look at the other gfortran testsuite failures on Tru64
>> UNIX V5.1B and IRIX 6.5 that couldn't be fixed that easily.
>> How to best report them and have them investigated?  I suspect that
>> there might be only a few common issues, so a PR per failing testcase
>> might be overkill, while a single one for all failures is hard to deal with.
>
> No idea. I would go for only one or few PRs, one can still extend it to
> several. Maybe one could also restrict one to few issues as a starter.

Ok, I've now filed

fortran/48438	Several gfortran tests FAIL on Tru64 UNIX

I can do similarly for IRIX if that's ok, though I'll have to complete
at least some initial investigation at the level of the Tru64 UNIX PR
before doing so.  You can see the IRIX results here:

	http://gcc.gnu.org/ml/gcc-testresults/2011-04/msg00289.html

Thanks.
	Rainer

Patch

Index: gcc/testsuite/gfortran.dg/bessel_6.f90
===================================================================
--- gcc/testsuite/gfortran.dg/bessel_6.f90	(Revision 171911)
+++ gcc/testsuite/gfortran.dg/bessel_6.f90	(Arbeitskopie)
@@ -16,7 +16,7 @@ 
 ! more tolerant
 !                  * [0, 5, 3, 4, 6, 7, 7, 5, 5, 6, 66, 4 ]
 integer,parameter :: mymax(size(values)) =  &
-                 [100, 17, 23, 21, 27, 28, 32, 35, 36, 41, 47, 37 ]
+                 [100, 17, 23, 21, 27, 28, 32, 35, 31, 41, 47, 37 ]
 integer, parameter :: Nmax = 100
 real :: rec(0:Nmax), lib(0:Nmax)
 integer :: i
@@ -39,8 +39,9 @@ 
 do i = 0, mymax
 !  print '(i2,2e17.9,e12.2,f18.10,2l3)', i, rec(i), lib(i), &
 !        rec(i)-lib(i),           ((rec(i)-lib(i))/rec(i))/epsilon(x), &
-!        rec(i) == lib(i) .or. abs((rec(i)-lib(i))/rec(i)) < myeps
-if (.not. (rec(i) == lib(i) .or. abs((rec(i)-lib(i))/rec(i)) < myeps)) &
+!        rec(i) == lib(i), abs((rec(i)-lib(i))/rec(i)) < myeps
+if (rec(i) == lib(i)) CYCLE
+if (abs((rec(i)-lib(i))/rec(i)) > myeps) &
   call abort()
 end do
 
Index: gcc/testsuite/ChangeLog
===================================================================
--- gcc/testsuite/ChangeLog	(Revision 171911)
+++ gcc/testsuite/ChangeLog	(Arbeitskopie)
@@ -1,3 +1,7 @@ 
+2011-04-03  Tobias Burnus  <burnus@net-b.de>
+
+	* gfortran.dg/bessel_6.f90: Reduce mymax for Tru64.
+
 2011-04-03  Richard Guenther  <rguenther@suse.de>
 	    Ira Rosen  <ira.rosen@linaro.org>