diff mbox series

[v2,3/4] memory: Fix memory_region 'priority' property sign

Message ID 20180405012241.25714-4-f4bug@amsat.org
State New
Headers show
Series memory: fix access_with_adjusted_size() and misc | expand

Commit Message

Philippe Mathieu-Daudé April 5, 2018, 1:22 a.m. UTC 
Priorities can be negative, fix this limitation.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé March 27, 2021, 1:57 p.m. UTC | #1 
ping?

On Thu, Apr 5, 2018 at 3:23 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Priorities can be negative, fix this limitation.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/memory.c b/memory.c
> index e77f9e4036..eaa5fa7f23 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -1258,7 +1258,7 @@ static void memory_region_initfn(Object *obj)
>                          memory_region_get_addr,
>                          NULL, /* memory_region_set_addr */
>                          NULL, NULL, &error_abort);
> -    object_property_add(OBJECT(mr), "priority", "uint32",
> +    object_property_add(OBJECT(mr), "priority", "int32",
>                          memory_region_get_priority,
>                          NULL, /* memory_region_set_priority */
>                          NULL, NULL, &error_abort);
> --
> 2.16.3
>
Philippe Mathieu-Daudé March 27, 2021, 2:30 p.m. UTC | #2 
On 3/27/21 2:57 PM, Philippe Mathieu-Daudé wrote:
> ping?

Bah this doesn't apply anymore (memory.c moved to softmmu/).

I'll respin.

> On Thu, Apr 5, 2018 at 3:23 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> Priorities can be negative, fix this limitation.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  memory.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/memory.c b/memory.c
>> index e77f9e4036..eaa5fa7f23 100644
>> --- a/memory.c
>> +++ b/memory.c
>> @@ -1258,7 +1258,7 @@ static void memory_region_initfn(Object *obj)
>>                          memory_region_get_addr,
>>                          NULL, /* memory_region_set_addr */
>>                          NULL, NULL, &error_abort);
>> -    object_property_add(OBJECT(mr), "priority", "uint32",
>> +    object_property_add(OBJECT(mr), "priority", "int32",
>>                          memory_region_get_priority,
>>                          NULL, /* memory_region_set_priority */
>>                          NULL, NULL, &error_abort);
>> --
>> 2.16.3
>>
>
diff mbox series

Patch

diff --git a/memory.c b/memory.c
index e77f9e4036..eaa5fa7f23 100644
--- a/memory.c
+++ b/memory.c
@@ -1258,7 +1258,7 @@  static void memory_region_initfn(Object *obj)
                         memory_region_get_addr,
                         NULL, /* memory_region_set_addr */
                         NULL, NULL, &error_abort);
-    object_property_add(OBJECT(mr), "priority", "uint32",
+    object_property_add(OBJECT(mr), "priority", "int32",
                         memory_region_get_priority,
                         NULL, /* memory_region_set_priority */
                         NULL, NULL, &error_abort);