Patchwork [U-Boot,1/2] MX31: mx31pdk: fix nand_spl

login
register
mail settings
Submitter Stefano Babic
Date April 3, 2011, 10:01 a.m.
Message ID <1301824909-26108-1-git-send-email-sbabic@denx.de>
Download mbox | patch
Permalink /patch/89504/
State Accepted
Commit 7f5b2bb79bc71d413a4f605b40a34751b2dac908
Delegated to: Albert ARIBAUD
Headers show

Comments

Stefano Babic - April 3, 2011, 10:01 a.m.
Commit f326cbba98bae21d41df8daac0bd78121d557af1 breaks mx31pdk,
as the _end section in u-boot.lds is missing for the nand_spl
production.

Signed-off-by: Stefano Babic <sbabic@denx.de>
CC: Fabio Estevam <fabio.estevam@freescale.com>
---
 nand_spl/board/freescale/mx31pdk/u-boot.lds |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Albert ARIBAUD - April 3, 2011, 12:08 p.m.
Hi Stefano,

Le 03/04/2011 12:01, Stefano Babic a écrit :
> Commit f326cbba98bae21d41df8daac0bd78121d557af1 breaks mx31pdk,
> as the _end section in u-boot.lds is missing for the nand_spl
> production.

What command line should one use to reproduce the issue? I just did a 
./MAKEALL mx31pdk from the current u-boot-arm master branch and it 
builds fine, which I suspect sould not be possible if it missed the _end 
symbol.

Amicalement,
Stefano Babic - April 3, 2011, 5:50 p.m.
On 04/03/2011 02:08 PM, Albert ARIBAUD wrote:
> Hi Stefano,
>

Hi Albert,

> Le 03/04/2011 12:01, Stefano Babic a écrit :
>> Commit f326cbba98bae21d41df8daac0bd78121d557af1 breaks mx31pdk,
>> as the _end section in u-boot.lds is missing for the nand_spl
>> production.
> 
> What command line should one use to reproduce the issue?

you should issue mx31pdk_nand. I do not know why there is a special
target in the Makefile, I do not think this is necessary and only
boards.cfg could be used. But this has nothing to do with the reported
error, answering your question I have seen something else strange ;-)

> I just did a 
> ./MAKEALL mx31pdk from the current u-boot-arm master branch and it 
> builds fine, which I suspect sould not be possible if it missed the _end 
> symbol.

The mx31pdk supports booting from NOR or from NAND, using two different
configuration. You compiled for NOR, and everything works fine - only
the nand_spl part has this issue.

Stefano
Fabio Estevam - April 3, 2011, 10:04 p.m.
Hi Stefano,

On 4/3/2011 7:01 AM, Stefano Babic wrote:
> Commit f326cbba98bae21d41df8daac0bd78121d557af1 breaks mx31pdk,
> as the _end section in u-boot.lds is missing for the nand_spl
> production.

After applying your patch I was able to build and boot MX31PDK from NAND,
so here goes my:
 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
Tested-by: Fabio Estevam <fabio.estevam@freescale.com>

Regards,

Fabio Estevam
Fabio Estevam - April 3, 2011, 10:27 p.m.
Hi Albert,

--- On Sun, 4/3/11, Albert ARIBAUD <albert.aribaud@free.fr> wrote:

> From: Albert ARIBAUD <albert.aribaud@free.fr>
> Subject: Re: [U-Boot] [PATCH 1/2] MX31: mx31pdk: fix nand_spl
> To: u-boot@lists.denx.de
> Date: Sunday, April 3, 2011, 9:08 AM
> Hi Stefano,
> 
> Le 03/04/2011 12:01, Stefano Babic a écrit :
> > Commit f326cbba98bae21d41df8daac0bd78121d557af1 breaks
> mx31pdk,
> > as the _end section in u-boot.lds is missing for the
> nand_spl
> > production.
> 
> What command line should one use to reproduce the issue? I

Please do a ´make mx31pdk_nand_config´

Regards,

Fabio Estevam
Albert ARIBAUD - April 4, 2011, 5:52 a.m.
Le 04/04/2011 00:04, Fabio Estevam a écrit :
> Hi Stefano,
>
> On 4/3/2011 7:01 AM, Stefano Babic wrote:
>> Commit f326cbba98bae21d41df8daac0bd78121d557af1 breaks mx31pdk,
>> as the _end section in u-boot.lds is missing for the nand_spl
>> production.
>
> After applying your patch I was able to build and boot MX31PDK from NAND,
> so here goes my:
>
>> Signed-off-by: Stefano Babic<sbabic@denx.de>
> Tested-by: Fabio Estevam<fabio.estevam@freescale.com>
>
> Regards,
>
> Fabio Estevam

Applied to u-boot-arm/master, thanks!

Amicalement,

Patch

diff --git a/nand_spl/board/freescale/mx31pdk/u-boot.lds b/nand_spl/board/freescale/mx31pdk/u-boot.lds
index 324a932..d2b08f6 100644
--- a/nand_spl/board/freescale/mx31pdk/u-boot.lds
+++ b/nand_spl/board/freescale/mx31pdk/u-boot.lds
@@ -63,6 +63,8 @@  SECTIONS
 		*(.dynsym)
 	}
 
+	_end = .;
+
 	.bss __rel_dyn_start (OVERLAY) : {
 		__bss_start = .;
 		*(.bss)