Use @AR@ instead of hardcoded 'ar'

Message ID 1522798223.13893.1.camel@gmail.com
State Accepted
Headers show
Series
  • Use @AR@ instead of hardcoded 'ar'
Related show

Commit Message

bjornpagen@gmail.com April 3, 2018, 11:30 p.m.
Hey all,

e2fsprogs currently hardcodes 'ar' in one of it's makefiles. This is
fixed with this patch:

Upstream: no
Author: Bjorn Pagen <bjornpagen@gmail.com>
Reason: e2fsprogs does not merge, calls blacklisted 'ar'
--

--
Thanks,
Bjorn Pagen

Comments

Theodore Y. Ts'o May 14, 2018, 2:12 a.m. | #1
On Tue, Apr 03, 2018 at 07:30:23PM -0400, bjornpagen@gmail.com wrote:
> Hey all,
> 
> e2fsprogs currently hardcodes 'ar' in one of it's makefiles. This is
> fixed with this patch:

Applied, thanks.  This is a simple enough patch that I'm not going to
insist on it, but please note: [1].  (In general, e2fsprogs uses patch
submission guidelines similar to the ones used by the kernel[2].)

	   	      	      	     - Ted

[1] https://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/tree/SUBMITTING-PATCHES
[2] https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Patch

diff --git a/intl/Makefile.in.old b/intl/Makefile.in
index 66d7512..3024494 100644
--- a/intl/Makefile.in
+++ b/intl/Makefile.in
@@ -81,7 +81,7 @@  mkinstalldirs = $(SHELL) $(MKINSTALLDIRS)
 
 l = @INTL_LIBTOOL_SUFFIX_PREFIX@
 
-AR = ar
+AR = @AR@
 CC = @CC@
 LIBTOOL = @LIBTOOL@
 RANLIB = @RANLIB@