| Message ID | 1522615975-20952-1-git-send-email-fransmeulenbroeks@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | fix typo in command value in drivers/net/phy/mdio-bitbang. | expand |
On Sun, Apr 01, 2018 at 10:52:55PM +0200, Frans Meulenbroeks wrote: > mdio-bitbang mentioned 10 for both read and write. > However mdio read opcode is 10 and write opcode is 01 > Fixed comment. > > Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: Frans Meulenbroeks <fransmeulenbroeks@gmail.com> Date: Sun, 1 Apr 2018 22:52:55 +0200 > mdio-bitbang mentioned 10 for both read and write. > However mdio read opcode is 10 and write opcode is 01 > Fixed comment. > > Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com> Applied.
diff --git a/drivers/net/phy/mdio-bitbang.c b/drivers/net/phy/mdio-bitbang.c index 61a543c..403b085 100644 --- a/drivers/net/phy/mdio-bitbang.c +++ b/drivers/net/phy/mdio-bitbang.c @@ -113,7 +113,7 @@ static void mdiobb_cmd(struct mdiobb_ctrl *ctrl, int op, u8 phy, u8 reg) for (i = 0; i < 32; i++) mdiobb_send_bit(ctrl, 1); - /* send the start bit (01) and the read opcode (10) or write (10). + /* send the start bit (01) and the read opcode (10) or write (01). Clause 45 operation uses 00 for the start and 11, 10 for read/write */ mdiobb_send_bit(ctrl, 0);
mdio-bitbang mentioned 10 for both read and write. However mdio read opcode is 10 and write opcode is 01 Fixed comment. Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com> --- drivers/net/phy/mdio-bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)