| Message ID | 20180401070337.18301-1-bernd.kuhls@t-online.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/4] package/kodi: remove libamcodec support | expand |
Greetings Bernd, > Sent: Sunday, April 01, 2018 at 10:03 AM > From: "Bernd Kuhls" <bernd.kuhls@t-online.de> > To: buildroot@buildroot.org > Cc: "Maxime Hadjinlian" <maxime.hadjinlian@gmail.com> > Subject: [Buildroot] [PATCH 1/4] package/kodi: remove libamcodec support > > Using the libamcodec package (-DENABLE_AML=ON) is not enough: > > -- Could NOT find OpenGLES (missing: OPENGLES_gl_LIBRARY OPENGLES_egl_LIBRARY OPENGLES_INCLUDE_DIR) > CMake Error at /usr/share/cmake-3.7/Modules/FindPackageHandleStandardArgs.cmake:138 (message): > Could NOT find EGL (missing: EGL_LIBRARY EGL_INCLUDE_DIR) > Call Stack (most recent call first): > /usr/share/cmake-3.7/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE) > modules/FindEGL.cmake:30 (find_package_handle_standard_args) > scripts/common/Macros.cmake:354 (find_package) > CMakeLists.txt:208 (core_require_dep) > > Libreelec provides pre-compiled OpenGL ES libraries for AML which are > not provided by buildroot: > https://github.com/LibreELEC/LibreELEC.tv/tree/master/packages/graphics/opengl-meson > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/kodi/kodi.mk | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk > index 9d3b65ae91..5af9fe180d 100644 > --- a/package/kodi/kodi.mk > +++ b/package/kodi/kodi.mk > @@ -72,6 +72,7 @@ KODI_CONF_OPTS += \ > -DLIBDVDCSS_URL=$(DL_DIR)/$(KODI_LIBDVDCSS_VERSION).tar.gz \ > -DLIBDVDNAV_URL=$(DL_DIR)/$(KODI_LIBDVDNAV_VERSION).tar.gz \ > -DLIBDVDREAD_URL=$(DL_DIR)/$(KODI_LIBDVDREAD_VERSION).tar.gz \ > + -DENABLE_AML=OFF \ > -DENABLE_IMX=OFF > > ifeq ($(BR2_ENABLE_LOCALE),) > @@ -186,12 +187,6 @@ else > # "linux" platforms. The "rpbi" platform has a different set of > # options, defined in project/cmake/scripts/rbpi/ > KODI_CONF_OPTS += -DENABLE_LDGOLD=OFF > -ifeq ($(BR2_PACKAGE_LIBAMCODEC),y) > -KODI_CONF_OPTS += -DENABLE_AML=ON > -KODI_DEPENDENCIES += libamcodec > -else > -KODI_CONF_OPTS += -DENABLE_AML=OFF > -endif > endif > > ifeq ($(BR2_PACKAGE_HAS_UDEV),y) > -- > 2.14.2 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot I'm trying to understand this change, does this means libamlogic is missing something or kodi doesn't supports gles anymore? also, can you explain how Libreelec provided pre-compiled OpenGL ES libraries for AML are related to this? the link you've added points to a systemd script Dagg.
> Sent: Sunday, April 01, 2018 at 10:17 AM > From: daggs <daggs@gmx.com> > To: "Bernd Kuhls" <bernd.kuhls@t-online.de> > Cc: "Maxime Hadjinlian" <maxime.hadjinlian@gmail.com>, buildroot@buildroot.org > Subject: Re: [Buildroot] [PATCH 1/4] package/kodi: remove libamcodec support > > Greetings Bernd, > > > Sent: Sunday, April 01, 2018 at 10:03 AM > > From: "Bernd Kuhls" <bernd.kuhls@t-online.de> > > To: buildroot@buildroot.org > > Cc: "Maxime Hadjinlian" <maxime.hadjinlian@gmail.com> > > Subject: [Buildroot] [PATCH 1/4] package/kodi: remove libamcodec support > > > > Using the libamcodec package (-DENABLE_AML=ON) is not enough: > > > > -- Could NOT find OpenGLES (missing: OPENGLES_gl_LIBRARY OPENGLES_egl_LIBRARY OPENGLES_INCLUDE_DIR) > > CMake Error at /usr/share/cmake-3.7/Modules/FindPackageHandleStandardArgs.cmake:138 (message): > > Could NOT find EGL (missing: EGL_LIBRARY EGL_INCLUDE_DIR) > > Call Stack (most recent call first): > > /usr/share/cmake-3.7/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE) > > modules/FindEGL.cmake:30 (find_package_handle_standard_args) > > scripts/common/Macros.cmake:354 (find_package) > > CMakeLists.txt:208 (core_require_dep) > > > > Libreelec provides pre-compiled OpenGL ES libraries for AML which are > > not provided by buildroot: > > https://github.com/LibreELEC/LibreELEC.tv/tree/master/packages/graphics/opengl-meson > > > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > > --- > > package/kodi/kodi.mk | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk > > index 9d3b65ae91..5af9fe180d 100644 > > --- a/package/kodi/kodi.mk > > +++ b/package/kodi/kodi.mk > > @@ -72,6 +72,7 @@ KODI_CONF_OPTS += \ > > -DLIBDVDCSS_URL=$(DL_DIR)/$(KODI_LIBDVDCSS_VERSION).tar.gz \ > > -DLIBDVDNAV_URL=$(DL_DIR)/$(KODI_LIBDVDNAV_VERSION).tar.gz \ > > -DLIBDVDREAD_URL=$(DL_DIR)/$(KODI_LIBDVDREAD_VERSION).tar.gz \ > > + -DENABLE_AML=OFF \ > > -DENABLE_IMX=OFF > > > > ifeq ($(BR2_ENABLE_LOCALE),) > > @@ -186,12 +187,6 @@ else > > # "linux" platforms. The "rpbi" platform has a different set of > > # options, defined in project/cmake/scripts/rbpi/ > > KODI_CONF_OPTS += -DENABLE_LDGOLD=OFF > > -ifeq ($(BR2_PACKAGE_LIBAMCODEC),y) > > -KODI_CONF_OPTS += -DENABLE_AML=ON > > -KODI_DEPENDENCIES += libamcodec > > -else > > -KODI_CONF_OPTS += -DENABLE_AML=OFF > > -endif > > endif > > > > ifeq ($(BR2_PACKAGE_HAS_UDEV),y) > > -- > > 2.14.2 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > I'm trying to understand this change, does this means libamlogic is missing something or kodi doesn't supports gles anymore? > also, can you explain how Libreelec provided pre-compiled OpenGL ES libraries for AML are related to this? the link you've added points to a systemd script > > Dagg. > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > ok, I understood the second part, the OpenGL ES libraries are part of buildroot, see odroid-mali which uses version r6p1. do you mean that they need to be upgraded? Dagg.
Hi daggs, Am Sun, 01 Apr 2018 09:17:59 +0200 schrieb daggs: > I'm trying to understand this change, does this means libamlogic is > missing something or kodi doesn't supports gles anymore? it means that buildroot does not provide the OpenGL ES libraries needed for amlogic support in Kodi. > also, can you explain how Libreelec provided pre-compiled OpenGL ES > libraries for AML are related to this? the link you've added points to a > systemd script Please have a look at https://github.com/LibreELEC/LibreELEC.tv/blob/ master/packages/graphics/opengl-meson/package.mk#L42, it states: "opengl-meson: OpenGL ES pre-compiled libraries for Mali GPUs found in Amlogic Meson SoCs" Atm these libraries are not provided by buildroot, so in the current state, buildroot can not build Kodi with amlogic support, this patch fixes the problem. If someone is interested in amlogic support in Kodi please send patches to provide the needed libraries. Regards, Bernd
Am Sun, 01 Apr 2018 09:25:57 +0200 schrieb daggs: > ok, I understood the second part, the OpenGL ES libraries are part of > buildroot, see odroid-mali which uses version r6p1. > do you mean that they need to be upgraded? Hi daggs, how are amlogic and odroid connected to each other? Please forgive me if I am asking stupid questions, but I never used hardware like this for Kodi. Regards, Bernd
Greetings Bernd, > Sent: Sunday, April 01, 2018 at 10:33 AM > From: "Bernd Kuhls" <bernd.kuhls@t-online.de> > To: buildroot@uclibc.org > Subject: Re: [Buildroot] [PATCH 1/4] package/kodi: remove libamcodec support > > Am Sun, 01 Apr 2018 09:25:57 +0200 schrieb daggs: > > > ok, I understood the second part, the OpenGL ES libraries are part of > > buildroot, see odroid-mali which uses version r6p1. > > do you mean that they need to be upgraded? > > Hi daggs, > > how are amlogic and odroid connected to each other? Please forgive me if > I am asking stupid questions, but I never used hardware like this for > Kodi. > > Regards, Bernd > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > odroidc2 boards use amlogic libs, infact I'm the maintainer of the libamlogic pkg and I've added the support to kodi. if it isn't needed to get hw decoding for kodi, I see no point in having that pkg in buildroot. afaik, it is needed, e,g, removing that pkg will result in no hw decoding support under kodi for the c2 boards (e.g. no x265) under kodi. Dagg. Dagg.
Am Sun, 01 Apr 2018 09:43:00 +0200 schrieb daggs: > odroidc2 boards use amlogic libs, infact I'm the maintainer of the > libamlogic pkg and I've added the support to kodi. Hi daggs, should the buildroot package libamcodec depend on odroid-mali? Regards, Bernd
Greetings Bernd, > Sent: Sunday, April 01, 2018 at 10:30 AM > From: "Bernd Kuhls" <bernd.kuhls@t-online.de> > To: buildroot@uclibc.org > Subject: Re: [Buildroot] [PATCH 1/4] package/kodi: remove libamcodec support > > Hi daggs, > > Am Sun, 01 Apr 2018 09:17:59 +0200 schrieb daggs: > > > I'm trying to understand this change, does this means libamlogic is > > missing something or kodi doesn't supports gles anymore? > > it means that buildroot does not provide the OpenGL ES libraries needed > for amlogic support in Kodi. > > > also, can you explain how Libreelec provided pre-compiled OpenGL ES > > libraries for AML are related to this? the link you've added points to a > > systemd script > > Please have a look at https://github.com/LibreELEC/LibreELEC.tv/blob/ > master/packages/graphics/opengl-meson/package.mk#L42, it states: > > "opengl-meson: OpenGL ES pre-compiled libraries for Mali GPUs found in > Amlogic Meson SoCs" > > Atm these libraries are not provided by buildroot, so in the current > state, buildroot can not build Kodi with amlogic support, this patch > fixes the problem. If someone is interested in amlogic support in Kodi > please send patches to provide the needed libraries. > > Regards, Bernd > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > the OpenGL ES libraries are part of buildroot, see odroid-mali which uses version r6p1. do you mean that they need to be upgraded? Dagg.
Greetings Bernd, > Sent: Sunday, April 01, 2018 at 10:55 AM > From: "Bernd Kuhls" <bernd.kuhls@t-online.de> > To: buildroot@uclibc.org > Subject: Re: [Buildroot] [PATCH 1/4] package/kodi: remove libamcodec support > > Am Sun, 01 Apr 2018 09:43:00 +0200 schrieb daggs: > > > odroidc2 boards use amlogic libs, infact I'm the maintainer of the > > libamlogic pkg and I've added the support to kodi. > > Hi daggs, > > should the buildroot package libamcodec depend on odroid-mali? > > Regards, Bernd > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > from what I understand, no. I'll try to ask in the vendor's forums to get a clearer layout on the matter, I'd be happy if you can put this patch on hold until they answer me. maybe it lib isn't needed and all what is needed is the mali lib. Dagg.
Hello, On Sun, 01 Apr 2018 09:55:16 +0200, Bernd Kuhls wrote: > Am Sun, 01 Apr 2018 09:43:00 +0200 schrieb daggs: > > > odroidc2 boards use amlogic libs, infact I'm the maintainer of the > > libamlogic pkg and I've added the support to kodi. > > Hi daggs, > > should the buildroot package libamcodec depend on odroid-mali? libamcodec is for the video decoding, odroid-mali is for the GPU. I don't think there's a reason for libamcodec to depend on odroid-mali. Best regards, Thomas
Am Sun, 01 Apr 2018 10:02:57 +0200 schrieb daggs: > Greetings Bernd, > >> Sent: Sunday, April 01, 2018 at 10:55 AM From: "Bernd Kuhls" >> <bernd.kuhls@t-online.de> To: >> buildroot@uclibc.org Subject: Re: >> [Buildroot] [PATCH 1/4] package/kodi: remove libamcodec support >> >> Am Sun, 01 Apr 2018 09:43:00 +0200 schrieb daggs: >> >> > odroidc2 boards use amlogic libs, infact I'm the maintainer of the >> > libamlogic pkg and I've added the support to kodi. >> >> Hi daggs, >> >> should the buildroot package libamcodec depend on odroid-mali? >> > from what I understand, no. Hi daggs, so you think it is possible to use libamcodec support in Kodi with OpenGL ES provided by, let's say, mesa3d with the DRI swrast driver? And even if there is no direct dependency between the libamcodoc and odroid-mali packages what about extending the ifeq ($(BR2_PACKAGE_LIBAMCODEC),y) check in kodi.mk to ifeq ($(BR2_PACKAGE_LIBAMCODEC)$(BR2_PACKAGE_ODROID_MALI),yy) to fix the build error? Regards, Bernd
Greetings Thomas, > Sent: Sunday, April 01, 2018 at 11:11 AM > From: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com> > To: "Bernd Kuhls" <bernd.kuhls@t-online.de> > Cc: buildroot@uclibc.org, daggs <daggs@gmx.com> > Subject: Re: [Buildroot] [PATCH 1/4] package/kodi: remove libamcodec support > > Hello, > > On Sun, 01 Apr 2018 09:55:16 +0200, Bernd Kuhls wrote: > > Am Sun, 01 Apr 2018 09:43:00 +0200 schrieb daggs: > > > > > odroidc2 boards use amlogic libs, infact I'm the maintainer of the > > > libamlogic pkg and I've added the support to kodi. > > > > Hi daggs, > > > > should the buildroot package libamcodec depend on odroid-mali? > > libamcodec is for the video decoding, odroid-mali is for the GPU. I > don't think there's a reason for libamcodec to depend on odroid-mali. > > Best regards, > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > https://bootlin.com > afaics, there is no such dependency. I agree, there shouldn't be one. Dagg.
Greetings Bernd, > Sent: Sunday, April 01, 2018 at 11:16 AM > From: "Bernd Kuhls" <bernd.kuhls@t-online.de> > To: buildroot@uclibc.org > Subject: Re: [Buildroot] [PATCH 1/4] package/kodi: remove libamcodec support > > Am Sun, 01 Apr 2018 10:02:57 +0200 schrieb daggs: > > > Greetings Bernd, > > > >> Sent: Sunday, April 01, 2018 at 10:55 AM From: "Bernd Kuhls" > >> <bernd.kuhls@t-online.de> To: > >> buildroot@uclibc.org Subject: Re: > >> [Buildroot] [PATCH 1/4] package/kodi: remove libamcodec support > >> > >> Am Sun, 01 Apr 2018 09:43:00 +0200 schrieb daggs: > >> > >> > odroidc2 boards use amlogic libs, infact I'm the maintainer of the > >> > libamlogic pkg and I've added the support to kodi. > >> > >> Hi daggs, > >> > >> should the buildroot package libamcodec depend on odroid-mali? > >> > > from what I understand, no. > > Hi daggs, > > so you think it is possible to use libamcodec support in Kodi with OpenGL > ES provided by, let's say, mesa3d with the DRI swrast driver? And even if > there is no direct dependency between the libamcodoc and odroid-mali > packages what about extending the > > ifeq ($(BR2_PACKAGE_LIBAMCODEC),y) > > check in kodi.mk to > > ifeq ($(BR2_PACKAGE_LIBAMCODEC)$(BR2_PACKAGE_ODROID_MALI),yy) > > to fix the build error? > > Regards, Bernd > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > as said by Thomas in another mail, there shouldn't be any dependency, what is the exact issue? compilation failure? what kodi version are you using? the answers for the two questions above will give me a lead on where to start looking. Thanks, Dagg.
Hello, On Sun, 1 Apr 2018 10:27:22 +0200, daggs wrote: > > so you think it is possible to use libamcodec support in Kodi with OpenGL > > ES provided by, let's say, mesa3d with the DRI swrast driver? And even if > > there is no direct dependency between the libamcodoc and odroid-mali > > packages what about extending the > > > > ifeq ($(BR2_PACKAGE_LIBAMCODEC),y) > > > > check in kodi.mk to > > > > ifeq ($(BR2_PACKAGE_LIBAMCODEC)$(BR2_PACKAGE_ODROID_MALI),yy) > > > > to fix the build error? > > > > Regards, Bernd > > > > _______________________________________________ > > buildroot mailing list > > buildroot@busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > > > as said by Thomas in another mail, there shouldn't be any dependency, what is the exact issue? compilation failure? what kodi version are you using? > the answers for the two questions above will give me a lead on where to start looking. Well, even though there is no dependency between libamcodec and odroid-mali, it is possible that Kodi needs both to enable the AML platform support. But indeed, it would be easier if Bernd could provide a .config file that allows to reproduce the build failure. Best regards, Thomas
Am Sun, 01 Apr 2018 10:27:22 +0200 schrieb daggs: > as said by Thomas in another mail, there shouldn't be any dependency, > what is the exact issue? compilation failure? what kodi version are you > using? Hi daggs, the following builds were all made with unpatched buildroot master branch. The only successful kodi build including libamcodec was made with odroid- mali using this defconfig: BR2_aarch64=y BR2_TOOLCHAIN_BUILDROOT_GLIBC=y BR2_TOOLCHAIN_BUILDROOT_CXX=y BR2_PACKAGE_KODI=y BR2_PACKAGE_ODROID_MALI=y BR2_PACKAGE_PYTHON=y BR2_PACKAGE_PYTHON_PY_ONLY=y BR2_PACKAGE_LIBAMCODEC=y -- Found OpenGLES: /home/buildroot/br2/output/host/aarch64-buildroot- linux-gnu/sysroot/usr/lib/libGLESv2.so -- Found EGL: /home/buildroot/br2/output/host/aarch64-buildroot-linux-gnu/ sysroot/usr/lib/libEGL.so (found version "r4p0") -- Found AML: /home/buildroot/br2/output/host/aarch64-buildroot-linux-gnu/ sysroot/usr/include/amcodec -- OPENGL enabled: No -- OPENGLES enabled: Yes -- X enabled: No -- LIBDRM enabled: No -- AML enabled: Yes Then I tried two builds with mesa3d & libamcodec, one where mesa3d provides opengl, in the second build mesa3d provides opengles, both failed: ------------------------------------------------------------------ BR2_aarch64=y BR2_TOOLCHAIN_BUILDROOT_WCHAR=y BR2_TOOLCHAIN_BUILDROOT_CXX=y BR2_PACKAGE_KODI=y BR2_PACKAGE_MESA3D=y BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y BR2_PACKAGE_MESA3D_OPENGL_EGL=y BR2_PACKAGE_XORG7=y BR2_PACKAGE_PYTHON=y BR2_PACKAGE_PYTHON_PY_ONLY=y BR2_PACKAGE_LIBAMCODEC=y -- Found OpenGl: /home/buildroot/br2/output/host/aarch64-buildroot-linux- uclibc/sysroot/usr/lib/libGL.so -- Found X: /home/buildroot/br2/output/host/aarch64-buildroot-linux- uclibc/sysroot/usr/lib/libX11.so (found version "1.6.5") -- Found LibDRM: /home/buildroot/br2/output/host/aarch64-buildroot-linux- uclibc/sysroot/usr/lib/libdrm.so (found version "2.4.91") -- Found XRandR: /home/buildroot/br2/output/host/aarch64-buildroot-linux- uclibc/sysroot/usr/lib/libXrandr.so (found version "1.5.1") -- Found EGL: /home/buildroot/br2/output/host/aarch64-buildroot-linux- uclibc/sysroot/usr/lib/libEGL.so (found version "18.0.0") -- Found AML: /home/buildroot/br2/output/host/aarch64-buildroot-linux- uclibc/sysroot/usr/include/amcodec -- OPENGL enabled: Yes -- X enabled: Yes -- LIBDRM enabled: Yes -- XRANDR enabled: Yes -- AML enabled: Yes [ 94%] Building CXX object build/cores/VideoPlayer/videorenderers/ CMakeFiles/videorenderers.dir/RenderManager.cpp.o /home/bernd/buildroot/br2/output/build/kodi-17.6-Krypton/xbmc/cores/ VideoPlayer/VideoRenderers/RenderManager.cpp: In member function 'void CRenderManager::CreateRenderer()': /home/bernd/buildroot/br2/output/build/kodi-17.6-Krypton/xbmc/cores/ VideoPlayer/VideoRenderers/RenderManager.cpp:582:25: error: 'CRendererAML' does not name a type m_pRenderer = new CRendererAML; ^~~~~~~~~~~~ ------------------------------------------------------------------ BR2_aarch64=y BR2_TOOLCHAIN_BUILDROOT_WCHAR=y BR2_TOOLCHAIN_BUILDROOT_CXX=y BR2_PACKAGE_KODI=y BR2_PACKAGE_MESA3D=y BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y BR2_PACKAGE_MESA3D_OPENGL_EGL=y BR2_PACKAGE_MESA3D_OPENGL_ES=y BR2_PACKAGE_PYTHON=y BR2_PACKAGE_PYTHON_PY_ONLY=y BR2_PACKAGE_LIBAMCODEC=y -- Found OpenGLES: /home/buildroot/br2/output/host/aarch64-buildroot- linux-uclibc/sysroot/usr/lib/libGLESv2.so -- Found EGL: /home/buildroot/br2/output/host/aarch64-buildroot-linux- uclibc/sysroot/usr/lib/libEGL.so (found version "18.0.0") -- Found AML: /home/buildroot/br2/output/host/aarch64-buildroot-linux- uclibc/sysroot/usr/include/amcodec -- OPENGL enabled: No -- OPENGLES enabled: Yes -- X enabled: No -- LIBDRM enabled: No -- AML enabled: Yes /bin/grep: /usr/lib/libgbm.la: No such file or directory /bin/sed: can't read /usr/lib/libgbm.la: No such file or directory libtool: error: '/usr/lib/libgbm.la' is not a valid libtool archive ------------------------------------------------------------------ Buildroot should not allow to use non-working combinations and here I think hardware-wise we should in some way connect libamcodec and odroid- mail to be used by Kodi. Besides the build errors it makes no sense to have software rendering provided by mesa3d when you have vendor-provided opengl libs. What do you think? Regards, Bernd
On 01-04-18 13:41, Bernd Kuhls wrote: > Am Sun, 01 Apr 2018 10:27:22 +0200 schrieb daggs: > >> as said by Thomas in another mail, there shouldn't be any dependency, >> what is the exact issue? compilation failure? what kodi version are you >> using? > > Hi daggs, > > the following builds were all made with unpatched buildroot master branch. > > The only successful kodi build including libamcodec was made with odroid- > mali using this defconfig: > > BR2_aarch64=y > BR2_TOOLCHAIN_BUILDROOT_GLIBC=y > BR2_TOOLCHAIN_BUILDROOT_CXX=y > BR2_PACKAGE_KODI=y > BR2_PACKAGE_ODROID_MALI=y > BR2_PACKAGE_PYTHON=y > BR2_PACKAGE_PYTHON_PY_ONLY=y > BR2_PACKAGE_LIBAMCODEC=y So, maybe the condition in kodi.mk should just change to: -ifeq ($(BR2_PACKAGE_LIBAMCODEC),y) +ifeq ($(BR2_PACKAGE_LIBAMCODEC)$(BR2_PACKAGE_ODROID_MALI),yy) KODI_CONF_OPTS += -DENABLE_AML=ON KODI_DEPENDENCIES += libamcodec else KODI_CONF_OPTS += -DENABLE_AML=OFF endif ? I guess Kodi's AML just works with OPENGLES, not with OPENGL. So the condition could maybe use BR2_PACKAGE_HAS_LIBGLES instead of BR2_PACKAGE_ODROID_MALI. But as you say in the end of this mail, Kodi still fails to build with mesa swrast and it doesn't make a lot of sense to combine swrast wit the binary mali driver. > > -- Found OpenGLES: /home/buildroot/br2/output/host/aarch64-buildroot- > linux-gnu/sysroot/usr/lib/libGLESv2.so > -- Found EGL: /home/buildroot/br2/output/host/aarch64-buildroot-linux-gnu/ > sysroot/usr/lib/libEGL.so (found version "r4p0") > -- Found AML: /home/buildroot/br2/output/host/aarch64-buildroot-linux-gnu/ > sysroot/usr/include/amcodec > > -- OPENGL enabled: No > -- OPENGLES enabled: Yes > -- X enabled: No > -- LIBDRM enabled: No > -- AML enabled: Yes > > Then I tried two builds with mesa3d & libamcodec, one where mesa3d > provides opengl, in the second build mesa3d provides opengles, both > failed: > > ------------------------------------------------------------------ > > BR2_aarch64=y > BR2_TOOLCHAIN_BUILDROOT_WCHAR=y > BR2_TOOLCHAIN_BUILDROOT_CXX=y > BR2_PACKAGE_KODI=y > BR2_PACKAGE_MESA3D=y > BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y > BR2_PACKAGE_MESA3D_OPENGL_EGL=y > BR2_PACKAGE_XORG7=y > BR2_PACKAGE_PYTHON=y > BR2_PACKAGE_PYTHON_PY_ONLY=y > BR2_PACKAGE_LIBAMCODEC=y > > -- Found OpenGl: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/lib/libGL.so > -- Found X: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/lib/libX11.so (found version "1.6.5") > -- Found LibDRM: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/lib/libdrm.so (found version "2.4.91") > -- Found XRandR: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/lib/libXrandr.so (found version "1.5.1") > -- Found EGL: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/lib/libEGL.so (found version "18.0.0") > -- Found AML: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/include/amcodec > > -- OPENGL enabled: Yes > -- X enabled: Yes > -- LIBDRM enabled: Yes > -- XRANDR enabled: Yes > -- AML enabled: Yes > > [ 94%] Building CXX object build/cores/VideoPlayer/videorenderers/ > CMakeFiles/videorenderers.dir/RenderManager.cpp.o > /home/bernd/buildroot/br2/output/build/kodi-17.6-Krypton/xbmc/cores/ > VideoPlayer/VideoRenderers/RenderManager.cpp: In member function 'void > CRenderManager::CreateRenderer()': > /home/bernd/buildroot/br2/output/build/kodi-17.6-Krypton/xbmc/cores/ > VideoPlayer/VideoRenderers/RenderManager.cpp:582:25: error: > 'CRendererAML' does not name a type > m_pRenderer = new CRendererAML; > ^~~~~~~~~~~~ > ------------------------------------------------------------------ > > BR2_aarch64=y > BR2_TOOLCHAIN_BUILDROOT_WCHAR=y > BR2_TOOLCHAIN_BUILDROOT_CXX=y > BR2_PACKAGE_KODI=y > BR2_PACKAGE_MESA3D=y > BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y > BR2_PACKAGE_MESA3D_OPENGL_EGL=y > BR2_PACKAGE_MESA3D_OPENGL_ES=y > BR2_PACKAGE_PYTHON=y > BR2_PACKAGE_PYTHON_PY_ONLY=y > BR2_PACKAGE_LIBAMCODEC=y > > -- Found OpenGLES: /home/buildroot/br2/output/host/aarch64-buildroot- > linux-uclibc/sysroot/usr/lib/libGLESv2.so > -- Found EGL: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/lib/libEGL.so (found version "18.0.0") > -- Found AML: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/include/amcodec > > -- OPENGL enabled: No > -- OPENGLES enabled: Yes > -- X enabled: No > -- LIBDRM enabled: No > -- AML enabled: Yes > > /bin/grep: /usr/lib/libgbm.la: No such file or directory > /bin/sed: can't read /usr/lib/libgbm.la: No such file or directory > libtool: error: '/usr/lib/libgbm.la' is not a valid libtool archive libgbm is enabled by BR2_PACKAGE_MESA3D_OPENGL_EGL, so it should be there. If Kodi looks for it in /usr/lib, sounds like a bug in Kodi... > ------------------------------------------------------------------ > > Buildroot should not allow to use non-working combinations and here I > think hardware-wise we should in some way connect libamcodec and odroid- > mail to be used by Kodi. Besides the build errors it makes no sense to > have software rendering provided by mesa3d when you have vendor-provided > opengl libs. I agree with that. Regards, Arnout
Greetings Bernd, > Sent: Sunday, April 01, 2018 at 2:41 PM > From: "Bernd Kuhls" <bernd.kuhls@t-online.de> > To: buildroot@uclibc.org > Subject: Re: [Buildroot] [PATCH 1/4] package/kodi: remove libamcodec support > > Am Sun, 01 Apr 2018 10:27:22 +0200 schrieb daggs: > > > as said by Thomas in another mail, there shouldn't be any dependency, > > what is the exact issue? compilation failure? what kodi version are you > > using? > > Hi daggs, > > the following builds were all made with unpatched buildroot master branch. > > The only successful kodi build including libamcodec was made with odroid- > mali using this defconfig: > > BR2_aarch64=y > BR2_TOOLCHAIN_BUILDROOT_GLIBC=y > BR2_TOOLCHAIN_BUILDROOT_CXX=y > BR2_PACKAGE_KODI=y > BR2_PACKAGE_ODROID_MALI=y > BR2_PACKAGE_PYTHON=y > BR2_PACKAGE_PYTHON_PY_ONLY=y > BR2_PACKAGE_LIBAMCODEC=y > > -- Found OpenGLES: /home/buildroot/br2/output/host/aarch64-buildroot- > linux-gnu/sysroot/usr/lib/libGLESv2.so > -- Found EGL: /home/buildroot/br2/output/host/aarch64-buildroot-linux-gnu/ > sysroot/usr/lib/libEGL.so (found version "r4p0") > -- Found AML: /home/buildroot/br2/output/host/aarch64-buildroot-linux-gnu/ > sysroot/usr/include/amcodec > > -- OPENGL enabled: No > -- OPENGLES enabled: Yes > -- X enabled: No > -- LIBDRM enabled: No > -- AML enabled: Yes > > Then I tried two builds with mesa3d & libamcodec, one where mesa3d > provides opengl, in the second build mesa3d provides opengles, both > failed: > > ------------------------------------------------------------------ > > BR2_aarch64=y > BR2_TOOLCHAIN_BUILDROOT_WCHAR=y > BR2_TOOLCHAIN_BUILDROOT_CXX=y > BR2_PACKAGE_KODI=y > BR2_PACKAGE_MESA3D=y > BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y > BR2_PACKAGE_MESA3D_OPENGL_EGL=y > BR2_PACKAGE_XORG7=y > BR2_PACKAGE_PYTHON=y > BR2_PACKAGE_PYTHON_PY_ONLY=y > BR2_PACKAGE_LIBAMCODEC=y > > -- Found OpenGl: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/lib/libGL.so > -- Found X: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/lib/libX11.so (found version "1.6.5") > -- Found LibDRM: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/lib/libdrm.so (found version "2.4.91") > -- Found XRandR: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/lib/libXrandr.so (found version "1.5.1") > -- Found EGL: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/lib/libEGL.so (found version "18.0.0") > -- Found AML: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/include/amcodec > > -- OPENGL enabled: Yes > -- X enabled: Yes > -- LIBDRM enabled: Yes > -- XRANDR enabled: Yes > -- AML enabled: Yes > > [ 94%] Building CXX object build/cores/VideoPlayer/videorenderers/ > CMakeFiles/videorenderers.dir/RenderManager.cpp.o > /home/bernd/buildroot/br2/output/build/kodi-17.6-Krypton/xbmc/cores/ > VideoPlayer/VideoRenderers/RenderManager.cpp: In member function 'void > CRenderManager::CreateRenderer()': > /home/bernd/buildroot/br2/output/build/kodi-17.6-Krypton/xbmc/cores/ > VideoPlayer/VideoRenderers/RenderManager.cpp:582:25: error: > 'CRendererAML' does not name a type > m_pRenderer = new CRendererAML; > ^~~~~~~~~~~~ > ------------------------------------------------------------------ > > BR2_aarch64=y > BR2_TOOLCHAIN_BUILDROOT_WCHAR=y > BR2_TOOLCHAIN_BUILDROOT_CXX=y > BR2_PACKAGE_KODI=y > BR2_PACKAGE_MESA3D=y > BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y > BR2_PACKAGE_MESA3D_OPENGL_EGL=y > BR2_PACKAGE_MESA3D_OPENGL_ES=y > BR2_PACKAGE_PYTHON=y > BR2_PACKAGE_PYTHON_PY_ONLY=y > BR2_PACKAGE_LIBAMCODEC=y > > -- Found OpenGLES: /home/buildroot/br2/output/host/aarch64-buildroot- > linux-uclibc/sysroot/usr/lib/libGLESv2.so > -- Found EGL: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/lib/libEGL.so (found version "18.0.0") > -- Found AML: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > uclibc/sysroot/usr/include/amcodec > > -- OPENGL enabled: No > -- OPENGLES enabled: Yes > -- X enabled: No > -- LIBDRM enabled: No > -- AML enabled: Yes > > /bin/grep: /usr/lib/libgbm.la: No such file or directory > /bin/sed: can't read /usr/lib/libgbm.la: No such file or directory > libtool: error: '/usr/lib/libgbm.la' is not a valid libtool archive > > ------------------------------------------------------------------ > > Buildroot should not allow to use non-working combinations and here I > think hardware-wise we should in some way connect libamcodec and odroid- > mail to be used by Kodi. Besides the build errors it makes no sense to > have software rendering provided by mesa3d when you have vendor-provided > opengl libs. > > What do you think? > > Regards, Bernd > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > I have an idea that can address this issue but first I'd like to get confirmation from the vendor's support team especially since libreelec doesn't seems to libamlogic compiled, ok? Dagg
Greetings Bernd, > Sent: Sunday, April 01, 2018 at 3:25 PM > From: daggs <daggs@gmx.com> > To: "Bernd Kuhls" <bernd.kuhls@t-online.de> > Cc: buildroot@uclibc.org > Subject: Re: [Buildroot] [PATCH 1/4] package/kodi: remove libamcodec support > > Greetings Bernd, > > > Sent: Sunday, April 01, 2018 at 2:41 PM > > From: "Bernd Kuhls" <bernd.kuhls@t-online.de> > > To: buildroot@uclibc.org > > Subject: Re: [Buildroot] [PATCH 1/4] package/kodi: remove libamcodec support > > > > Am Sun, 01 Apr 2018 10:27:22 +0200 schrieb daggs: > > > > > as said by Thomas in another mail, there shouldn't be any dependency, > > > what is the exact issue? compilation failure? what kodi version are you > > > using? > > > > Hi daggs, > > > > the following builds were all made with unpatched buildroot master branch. > > > > The only successful kodi build including libamcodec was made with odroid- > > mali using this defconfig: > > > > BR2_aarch64=y > > BR2_TOOLCHAIN_BUILDROOT_GLIBC=y > > BR2_TOOLCHAIN_BUILDROOT_CXX=y > > BR2_PACKAGE_KODI=y > > BR2_PACKAGE_ODROID_MALI=y > > BR2_PACKAGE_PYTHON=y > > BR2_PACKAGE_PYTHON_PY_ONLY=y > > BR2_PACKAGE_LIBAMCODEC=y > > > > -- Found OpenGLES: /home/buildroot/br2/output/host/aarch64-buildroot- > > linux-gnu/sysroot/usr/lib/libGLESv2.so > > -- Found EGL: /home/buildroot/br2/output/host/aarch64-buildroot-linux-gnu/ > > sysroot/usr/lib/libEGL.so (found version "r4p0") > > -- Found AML: /home/buildroot/br2/output/host/aarch64-buildroot-linux-gnu/ > > sysroot/usr/include/amcodec > > > > -- OPENGL enabled: No > > -- OPENGLES enabled: Yes > > -- X enabled: No > > -- LIBDRM enabled: No > > -- AML enabled: Yes > > > > Then I tried two builds with mesa3d & libamcodec, one where mesa3d > > provides opengl, in the second build mesa3d provides opengles, both > > failed: > > > > ------------------------------------------------------------------ > > > > BR2_aarch64=y > > BR2_TOOLCHAIN_BUILDROOT_WCHAR=y > > BR2_TOOLCHAIN_BUILDROOT_CXX=y > > BR2_PACKAGE_KODI=y > > BR2_PACKAGE_MESA3D=y > > BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y > > BR2_PACKAGE_MESA3D_OPENGL_EGL=y > > BR2_PACKAGE_XORG7=y > > BR2_PACKAGE_PYTHON=y > > BR2_PACKAGE_PYTHON_PY_ONLY=y > > BR2_PACKAGE_LIBAMCODEC=y > > > > -- Found OpenGl: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > > uclibc/sysroot/usr/lib/libGL.so > > -- Found X: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > > uclibc/sysroot/usr/lib/libX11.so (found version "1.6.5") > > -- Found LibDRM: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > > uclibc/sysroot/usr/lib/libdrm.so (found version "2.4.91") > > -- Found XRandR: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > > uclibc/sysroot/usr/lib/libXrandr.so (found version "1.5.1") > > -- Found EGL: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > > uclibc/sysroot/usr/lib/libEGL.so (found version "18.0.0") > > -- Found AML: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > > uclibc/sysroot/usr/include/amcodec > > > > -- OPENGL enabled: Yes > > -- X enabled: Yes > > -- LIBDRM enabled: Yes > > -- XRANDR enabled: Yes > > -- AML enabled: Yes > > > > [ 94%] Building CXX object build/cores/VideoPlayer/videorenderers/ > > CMakeFiles/videorenderers.dir/RenderManager.cpp.o > > /home/bernd/buildroot/br2/output/build/kodi-17.6-Krypton/xbmc/cores/ > > VideoPlayer/VideoRenderers/RenderManager.cpp: In member function 'void > > CRenderManager::CreateRenderer()': > > /home/bernd/buildroot/br2/output/build/kodi-17.6-Krypton/xbmc/cores/ > > VideoPlayer/VideoRenderers/RenderManager.cpp:582:25: error: > > 'CRendererAML' does not name a type > > m_pRenderer = new CRendererAML; > > ^~~~~~~~~~~~ > > ------------------------------------------------------------------ > > > > BR2_aarch64=y > > BR2_TOOLCHAIN_BUILDROOT_WCHAR=y > > BR2_TOOLCHAIN_BUILDROOT_CXX=y > > BR2_PACKAGE_KODI=y > > BR2_PACKAGE_MESA3D=y > > BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y > > BR2_PACKAGE_MESA3D_OPENGL_EGL=y > > BR2_PACKAGE_MESA3D_OPENGL_ES=y > > BR2_PACKAGE_PYTHON=y > > BR2_PACKAGE_PYTHON_PY_ONLY=y > > BR2_PACKAGE_LIBAMCODEC=y > > > > -- Found OpenGLES: /home/buildroot/br2/output/host/aarch64-buildroot- > > linux-uclibc/sysroot/usr/lib/libGLESv2.so > > -- Found EGL: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > > uclibc/sysroot/usr/lib/libEGL.so (found version "18.0.0") > > -- Found AML: /home/buildroot/br2/output/host/aarch64-buildroot-linux- > > uclibc/sysroot/usr/include/amcodec > > > > -- OPENGL enabled: No > > -- OPENGLES enabled: Yes > > -- X enabled: No > > -- LIBDRM enabled: No > > -- AML enabled: Yes > > > > /bin/grep: /usr/lib/libgbm.la: No such file or directory > > /bin/sed: can't read /usr/lib/libgbm.la: No such file or directory > > libtool: error: '/usr/lib/libgbm.la' is not a valid libtool archive > > > > ------------------------------------------------------------------ > > > > Buildroot should not allow to use non-working combinations and here I > > think hardware-wise we should in some way connect libamcodec and odroid- > > mail to be used by Kodi. Besides the build errors it makes no sense to > > have software rendering provided by mesa3d when you have vendor-provided > > opengl libs. > > > > What do you think? > > > > Regards, Bernd > > > > _______________________________________________ > > buildroot mailing list > > buildroot@busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > > > I have an idea that can address this issue but first I'd like to get confirmation from the vendor's support team especially since libreelec doesn't seems to libamlogic compiled, ok? > > Dagg I have the answer, I'll submit a patch after your latest changes will be committed to the repo. Dagg.
diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk index 9d3b65ae91..5af9fe180d 100644 --- a/package/kodi/kodi.mk +++ b/package/kodi/kodi.mk @@ -72,6 +72,7 @@ KODI_CONF_OPTS += \ -DLIBDVDCSS_URL=$(DL_DIR)/$(KODI_LIBDVDCSS_VERSION).tar.gz \ -DLIBDVDNAV_URL=$(DL_DIR)/$(KODI_LIBDVDNAV_VERSION).tar.gz \ -DLIBDVDREAD_URL=$(DL_DIR)/$(KODI_LIBDVDREAD_VERSION).tar.gz \ + -DENABLE_AML=OFF \ -DENABLE_IMX=OFF ifeq ($(BR2_ENABLE_LOCALE),) @@ -186,12 +187,6 @@ else # "linux" platforms. The "rpbi" platform has a different set of # options, defined in project/cmake/scripts/rbpi/ KODI_CONF_OPTS += -DENABLE_LDGOLD=OFF -ifeq ($(BR2_PACKAGE_LIBAMCODEC),y) -KODI_CONF_OPTS += -DENABLE_AML=ON -KODI_DEPENDENCIES += libamcodec -else -KODI_CONF_OPTS += -DENABLE_AML=OFF -endif endif ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
Using the libamcodec package (-DENABLE_AML=ON) is not enough: -- Could NOT find OpenGLES (missing: OPENGLES_gl_LIBRARY OPENGLES_egl_LIBRARY OPENGLES_INCLUDE_DIR) CMake Error at /usr/share/cmake-3.7/Modules/FindPackageHandleStandardArgs.cmake:138 (message): Could NOT find EGL (missing: EGL_LIBRARY EGL_INCLUDE_DIR) Call Stack (most recent call first): /usr/share/cmake-3.7/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE) modules/FindEGL.cmake:30 (find_package_handle_standard_args) scripts/common/Macros.cmake:354 (find_package) CMakeLists.txt:208 (core_require_dep) Libreelec provides pre-compiled OpenGL ES libraries for AML which are not provided by buildroot: https://github.com/LibreELEC/LibreELEC.tv/tree/master/packages/graphics/opengl-meson Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/kodi/kodi.mk | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)