phy: tegra: Remote self cast in tegra_xusb_port_find_lane

Message ID 20180401065743.GA30363@flashbox
State Deferred
Headers show
  • phy: tegra: Remote self cast in tegra_xusb_port_find_lane
Related show

Commit Message

Nathan Chancellor April 1, 2018, 6:57 a.m.
Clang warns about casting variables to themselves because it is rarely
necessary. Removing the cast should not change anything regarding the
code and silences the warning.

../drivers/phy/tegra/xusb.c:421:11: warning: explicitly assigning value
of variable of type 'const struct tegra_xusb_lane_map *' to itself
        for (map = map; map->type; map++) {
             ~~~ ^ ~~~

Signed-off-by: Nathan Chancellor <>
I am not entirely sure if this is the correct solution, especially since
I don't have the hardware and I am not too familiar with this code. If
there is a better solution, please let me know.

 drivers/phy/tegra/xusb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index 63e916d4d069..11aa5902a9ac 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -418,7 +418,7 @@  tegra_xusb_port_find_lane(struct tegra_xusb_port *port,
 	struct tegra_xusb_lane *lane, *match = ERR_PTR(-ENODEV);
-	for (map = map; map->type; map++) {
+	for (; map->type; map++) {
 		if (port->index != map->port)