diff mbox series

[U-Boot,v3,1/2] warp7: include/configs: use generic fs commands in CONFIG_EXTRA_ENV_SETTINGS

Message ID 1522536545-29492-1-git-send-email-texier.pj2@gmail.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show
Series [U-Boot,v3,1/2] warp7: include/configs: use generic fs commands in CONFIG_EXTRA_ENV_SETTINGS | expand

Commit Message

Pierre-Jean Texier March 31, 2018, 10:49 p.m. UTC
use the generic filesystem command 'load' rather
than 'fatload' to avoid per-fs specific commands.

Signed-off-by: Pierre-Jean TEXIER <texier.pj2@gmail.com>
---
Changes for v3:
	- None

 include/configs/warp7.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Fabio Estevam March 31, 2018, 11:01 p.m. UTC | #1
On Sat, Mar 31, 2018 at 7:49 PM, Pierre-Jean TEXIER
<texier.pj2@gmail.com> wrote:
> use the generic filesystem command 'load' rather
> than 'fatload' to avoid per-fs specific commands.
>
> Signed-off-by: Pierre-Jean TEXIER <texier.pj2@gmail.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Bryan O'Donoghue March 31, 2018, 11:10 p.m. UTC | #2
On 31/03/18 23:49, Pierre-Jean TEXIER wrote:
> use the generic filesystem command 'load' rather
> than 'fatload' to avoid per-fs specific commands.
> 
> Signed-off-by: Pierre-Jean TEXIER <texier.pj2@gmail.com>
> ---
> Changes for v3:
> 	- None
> 
>   include/configs/warp7.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/warp7.h b/include/configs/warp7.h
> index fe96988..82dc629 100644
> --- a/include/configs/warp7.h
> +++ b/include/configs/warp7.h
> @@ -45,11 +45,11 @@
>   	"mmcargs=setenv bootargs console=${console},${baudrate} " \
>   		"root=PARTUUID=${uuid} rootwait rw\0" \
>   	"loadbootscript=" \
> -		"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
> +		"load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
>   	"bootscript=echo Running bootscript from mmc ...; " \
>   		"source\0" \
> -	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
> -	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
> +	"loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
> +	"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
>   	"mmcboot=echo Booting from mmc ...; " \
>   		"run finduuid; " \
>   		"run mmcargs; " \
> 

Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Stefano Babic April 27, 2018, 8:47 a.m. UTC | #3
On 01/04/2018 00:49, Pierre-Jean TEXIER wrote:
> use the generic filesystem command 'load' rather
> than 'fatload' to avoid per-fs specific commands.
> 
> Signed-off-by: Pierre-Jean TEXIER <texier.pj2@gmail.com>
> ---
> Changes for v3:
> 	- None
> 
>  include/configs/warp7.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/warp7.h b/include/configs/warp7.h
> index fe96988..82dc629 100644
> --- a/include/configs/warp7.h
> +++ b/include/configs/warp7.h
> @@ -45,11 +45,11 @@
>  	"mmcargs=setenv bootargs console=${console},${baudrate} " \
>  		"root=PARTUUID=${uuid} rootwait rw\0" \
>  	"loadbootscript=" \
> -		"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
> +		"load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
>  	"bootscript=echo Running bootscript from mmc ...; " \
>  		"source\0" \
> -	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
> -	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
> +	"loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
> +	"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
>  	"mmcboot=echo Booting from mmc ...; " \
>  		"run finduuid; " \
>  		"run mmcargs; " \
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/include/configs/warp7.h b/include/configs/warp7.h
index fe96988..82dc629 100644
--- a/include/configs/warp7.h
+++ b/include/configs/warp7.h
@@ -45,11 +45,11 @@ 
 	"mmcargs=setenv bootargs console=${console},${baudrate} " \
 		"root=PARTUUID=${uuid} rootwait rw\0" \
 	"loadbootscript=" \
-		"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
+		"load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
 	"bootscript=echo Running bootscript from mmc ...; " \
 		"source\0" \
-	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
-	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
+	"loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
+	"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
 	"mmcboot=echo Booting from mmc ...; " \
 		"run finduuid; " \
 		"run mmcargs; " \