diff mbox series

[RFC] inet: frags: lowpan_rhash_params can be static

Message ID 20180331074707.GA123200@ivb42
State RFC, archived
Delegated to: David Miller
Headers show
Series [RFC] inet: frags: lowpan_rhash_params can be static | expand

Commit Message

kernel test robot March 31, 2018, 7:47 a.m. UTC
Fixes: b051dbce5e50 ("inet: frags: use rhashtables for reassembly units")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 reassembly.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eric Dumazet March 31, 2018, 1:46 p.m. UTC | #1
On 03/31/2018 12:47 AM, kbuild test robot wrote:
> 
> Fixes: b051dbce5e50 ("inet: frags: use rhashtables for reassembly units")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  reassembly.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ieee802154/6lowpan/reassembly.c b/net/ieee802154/6lowpan/reassembly.c
> index dd743c2..0fa0121 100644
> --- a/net/ieee802154/6lowpan/reassembly.c
> +++ b/net/ieee802154/6lowpan/reassembly.c
> @@ -597,7 +597,7 @@ static int lowpan_obj_cmpfn(struct rhashtable_compare_arg *arg, const void *ptr)
>  	return !!memcmp(&fq->key, key, sizeof(*key));
>  }
>  
> -const struct rhashtable_params lowpan_rhash_params = {
> +static const struct rhashtable_params lowpan_rhash_params = {
>  	.head_offset		= offsetof(struct inet_frag_queue, node),
>  	.hashfn			= lowpan_key_hashfn,
>  	.obj_hashfn		= lowpan_obj_hashfn,
> 

Thanks for the report/patch. I will squash this in the V4 submission.
diff mbox series

Patch

diff --git a/net/ieee802154/6lowpan/reassembly.c b/net/ieee802154/6lowpan/reassembly.c
index dd743c2..0fa0121 100644
--- a/net/ieee802154/6lowpan/reassembly.c
+++ b/net/ieee802154/6lowpan/reassembly.c
@@ -597,7 +597,7 @@  static int lowpan_obj_cmpfn(struct rhashtable_compare_arg *arg, const void *ptr)
 	return !!memcmp(&fq->key, key, sizeof(*key));
 }
 
-const struct rhashtable_params lowpan_rhash_params = {
+static const struct rhashtable_params lowpan_rhash_params = {
 	.head_offset		= offsetof(struct inet_frag_queue, node),
 	.hashfn			= lowpan_key_hashfn,
 	.obj_hashfn		= lowpan_obj_hashfn,