| Message ID | 20180330154648.GA13995@embeddedgus |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | ISDN: eicon: message: remove redundant check | expand |
On Fri, 2018-03-30 at 10:46 -0500, Gustavo A. R. Silva wrote:
> Check on plci->internal_command is unnecessary.
Probably all of these are unnecessary too:
$ for length in {7..2} ; do \
grep-2.5.4 -rP --include=*.[ch] -n "^\t{$length,$length}break;\n\t{$(($length-1)),$(($length-1))}break;" * ; \
done
drivers/staging/wilc1000/wilc_wlan.c:691: break;
break;
drivers/media/dvb-frontends/drxd_hard.c:2261: break;
break;
drivers/media/dvb-frontends/drxd_hard.c:2266: break;
break;
drivers/media/usb/gspca/sn9c20x.c:1860: break;
break;
drivers/isdn/i4l/isdn_common.c:624: break;
break;
drivers/isdn/i4l/isdn_common.c:642: break;
break;
drivers/isdn/i4l/isdn_common.c:654: break;
break;
drivers/isdn/hardware/eicon/message.c:13890: break;
break;
sound/usb/mixer_quirks.c:1832: break;
break;
On 03/30/2018 11:19 AM, Joe Perches wrote: > On Fri, 2018-03-30 at 10:46 -0500, Gustavo A. R. Silva wrote: >> Check on plci->internal_command is unnecessary. > > Probably all of these are unnecessary too: > > $ for length in {7..2} ; do \ > grep-2.5.4 -rP --include=*.[ch] -n "^\t{$length,$length}break;\n\t{$(($length-1)),$(($length-1))}break;" * ; \ > done > drivers/staging/wilc1000/wilc_wlan.c:691: break; > break; > drivers/media/dvb-frontends/drxd_hard.c:2261: break; > break; > drivers/media/dvb-frontends/drxd_hard.c:2266: break; > break; > drivers/media/usb/gspca/sn9c20x.c:1860: break; > break; > drivers/isdn/i4l/isdn_common.c:624: break; > break; > drivers/isdn/i4l/isdn_common.c:642: break; > break; > drivers/isdn/i4l/isdn_common.c:654: break; > break; > drivers/isdn/hardware/eicon/message.c:13890: break; > break; > sound/usb/mixer_quirks.c:1832: break; > break; > Oh, cool. I'll take a look at them. Thanks, Joe. -- Gustavo
diff --git a/drivers/isdn/hardware/eicon/message.c b/drivers/isdn/hardware/eicon/message.c index def7992..0ac18fc 100644 --- a/drivers/isdn/hardware/eicon/message.c +++ b/drivers/isdn/hardware/eicon/message.c @@ -13886,8 +13886,6 @@ static void adjust_b_restore(dword Id, PLCI *plci, byte Rc) dbug(1, dprintf("[%06lx] %s,%d: Adjust B restore failed", UnMapId(Id), (char *)(FILE_), __LINE__)); } - if (plci->internal_command) - break; break; } }
Check on plci->internal_command is unnecessary. Addresses-Coverity-ID: 1268778 ("Identical code for different branches") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/isdn/hardware/eicon/message.c | 2 -- 1 file changed, 2 deletions(-)