Patchwork Split up toplevel library-disabling cases

login
register
mail settings
Submitter Joseph S. Myers
Date April 1, 2011, 7:15 p.m.
Message ID <Pine.LNX.4.64.1104011914490.32286@digraph.polyomino.org.uk>
Download mbox | patch
Permalink /patch/89340/
State New
Headers show

Comments

Joseph S. Myers - April 1, 2011, 7:15 p.m.
On Fri, 1 Apr 2011, Michael Eager wrote:

> > Target maintainers: I'd like to understand why it is necessary to
> > disable libssp for AVR, AIX and Microblaze
> 
> I believe that at some time in the past libssp failed to build for
> MicroBlaze, but I don't recall the details.  It currently builds
> without error, so disabling it for MicroBlaze is no longer needed.

Thanks.  I've applied this patch to remove that disabling and add a 
comment about why it's disabled for AVR.

Patch

Index: configure.ac
===================================================================
--- configure.ac	(revision 171847)
+++ configure.ac	(working copy)
@@ -483,14 +483,12 @@ 
 # Disable libssp for some systems.
 case "${target}" in
   avr-*-*)
+    # No hosted I/O support.
     noconfigdirs="$noconfigdirs target-libssp"
     ;;
   powerpc-*-aix* | rs6000-*-aix*)
     noconfigdirs="$noconfigdirs target-libssp"
     ;;
-  microblaze*)
-    noconfigdirs="$noconfigdirs target-libssp"
-    ;;
 esac
 
 # Disable target libiberty for some systems.
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 171847)
+++ ChangeLog	(working copy)
@@ -1,5 +1,11 @@ 
 2011-04-01  Joseph Myers  <joseph@codesourcery.com>
 
+	* configure.ac (avr-*-*): Add comment about why libssp is disabled.
+	(microblaze*): Don't disable libssp.
+	* configure: Regenerate.
+
+2011-04-01  Joseph Myers  <joseph@codesourcery.com>
+
 	* configure.ac: Remove code setting CONFIG_SHELL, config_shell and
 	moveifchange.
 	* configure: Regenerate.
Index: configure
===================================================================
--- configure	(revision 171847)
+++ configure	(working copy)
@@ -3036,14 +3036,12 @@ 
 # Disable libssp for some systems.
 case "${target}" in
   avr-*-*)
+    # No hosted I/O support.
     noconfigdirs="$noconfigdirs target-libssp"
     ;;
   powerpc-*-aix* | rs6000-*-aix*)
     noconfigdirs="$noconfigdirs target-libssp"
     ;;
-  microblaze*)
-    noconfigdirs="$noconfigdirs target-libssp"
-    ;;
 esac
 
 # Disable target libiberty for some systems.