Patchwork [U-Boot] Provide pr_debug() and pr_info().

login
register
mail settings
Submitter Alexander Holler
Date April 1, 2011, 4:12 p.m.
Message ID <1301674331-7476-1-git-send-email-holler@ahsoftware.de>
Download mbox | patch
Permalink /patch/89304/
State Changes Requested
Headers show

Comments

Alexander Holler - April 1, 2011, 4:12 p.m.
Those are usefull for compatibility with the kernel.
Remove the locally defined pr_debug() in atmel_mci.c.

Signed-off-by: Alexander Holler <holler@ahsoftware.de>
---
 drivers/mmc/atmel_mci.c |    6 ------
 include/common.h        |    4 ++++
 2 files changed, 4 insertions(+), 6 deletions(-)
Wolfgang Denk - April 1, 2011, 5:56 p.m.
Dear Alexander Holler,

In message <1301674331-7476-1-git-send-email-holler@ahsoftware.de> you wrote:
> Those are usefull for compatibility with the kernel.
> Remove the locally defined pr_debug() in atmel_mci.c.
> 
> Signed-off-by: Alexander Holler <holler@ahsoftware.de>
> ---
>  drivers/mmc/atmel_mci.c |    6 ------
>  include/common.h        |    4 ++++
>  2 files changed, 4 insertions(+), 6 deletions(-)

NAK.  This is just adding redundant overhead.  I don;t want to have
yet another incarnation of macros which already exist.

Either replace the code in drivers/mmc/atmel_mci.c by a simple

	#define pr_debug(fmt, args...) debug(fmt, ##args)

or convert the code that uses this reference.

And pr_info() is completrely redundant and not used anywhere.


If you really think that pr_debug() is so much better than debug(),
then convert ALL code to use that.  But I am not a friend of such a
change.

Best regards,

Wolfgang Denk
Alexander Holler - April 1, 2011, 7:40 p.m.
Hello,

Am 01.04.2011 19:56, schrieb Wolfgang Denk:
> Dear Alexander Holler,
>
> In message<1301674331-7476-1-git-send-email-holler@ahsoftware.de>  you wrote:
>> Those are usefull for compatibility with the kernel.
>> Remove the locally defined pr_debug() in atmel_mci.c.
>>
>> Signed-off-by: Alexander Holler<holler@ahsoftware.de>
>> ---
>>   drivers/mmc/atmel_mci.c |    6 ------
>>   include/common.h        |    4 ++++
>>   2 files changed, 4 insertions(+), 6 deletions(-)
>
> NAK.  This is just adding redundant overhead.  I don;t want to have
> yet another incarnation of macros which already exist.
>
> Either replace the code in drivers/mmc/atmel_mci.c by a simple
>
> 	#define pr_debug(fmt, args...) debug(fmt, ##args)
>
> or convert the code that uses this reference.
>
> And pr_info() is completrely redundant and not used anywhere.
>
>
> If you really think that pr_debug() is so much better than debug(),
> then convert ALL code to use that.  But I am not a friend of such a
> change.

Than just forget this patch and someone else should add those macros to 
future imports of sources from the kernel. At least I will now do so.

Regards,

Alexander Holler

Patch

diff --git a/drivers/mmc/atmel_mci.c b/drivers/mmc/atmel_mci.c
index 3946ffe..9d798ca 100644
--- a/drivers/mmc/atmel_mci.c
+++ b/drivers/mmc/atmel_mci.c
@@ -32,12 +32,6 @@ 
 
 #include "atmel_mci.h"
 
-#ifdef DEBUG
-#define pr_debug(fmt, args...) printf(fmt, ##args)
-#else
-#define pr_debug(...) do { } while(0)
-#endif
-
 #ifndef CONFIG_SYS_MMC_CLK_OD
 #define CONFIG_SYS_MMC_CLK_OD		150000
 #endif
diff --git a/include/common.h b/include/common.h
index 893af5c..a1fe8df 100644
--- a/include/common.h
+++ b/include/common.h
@@ -119,11 +119,15 @@  typedef volatile unsigned char	vu_char;
 #ifdef	DEBUG
 #define debug(fmt,args...)	printf (fmt ,##args)
 #define debugX(level,fmt,args...) if (DEBUG>=level) printf(fmt,##args);
+#define pr_debug(fmt, args...) printf(fmt, ##args)
 #else
 #define debug(fmt,args...)
 #define debugX(level,fmt,args...)
+#define pr_debug(fmt, args...)
 #endif	/* DEBUG */
 
+#define pr_info(fmt, args...)	printf (fmt, ##args)
+
 #define error(fmt, args...) do {					\
 		printf("ERROR: " fmt "\nat %s:%d/%s()\n",		\
 			##args, __FILE__, __LINE__, __func__);		\