Patchwork [PR43920,3/9] Cleanup.

login
register
mail settings
Submitter Tom de Vries
Date April 1, 2011, 3:15 p.m.
Message ID <4D95EC07.60807@codesourcery.com>
Download mbox | patch
Permalink /patch/89287/
State New
Headers show

Comments

Tom de Vries - April 1, 2011, 3:15 p.m.
On 04/01/2011 05:01 PM, Jakub Jelinek wrote:
> On Fri, Apr 01, 2011 at 04:56:10PM +0200, Tom de Vries wrote:
>> Reposting, with ChangeLog.
>
> Similarly one of your patches had
> 	* gcc/cfgcleanup.c (whatever): Whatever.
> in the ChangeLog, should be just
> 	* cfgcleanup.c (whatever): Whatever.
>
> 	Jakub

Fixed ChangeLog.

Thanks,
- Tom
Jeff Law - April 4, 2011, 6:25 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/01/11 09:15, Tom de Vries wrote:
> On 04/01/2011 05:01 PM, Jakub Jelinek wrote:
>> On Fri, Apr 01, 2011 at 04:56:10PM +0200, Tom de Vries wrote:
>>> Reposting, with ChangeLog.
>>
>> Similarly one of your patches had
>> 	* gcc/cfgcleanup.c (whatever): Whatever.
>> in the ChangeLog, should be just
>> 	* cfgcleanup.c (whatever): Whatever.
>>
>> 	Jakub
> 
> Fixed ChangeLog.
OK.  Though I don't think you need to mention 43920 in this specific
hunk.  It's a mere cleanup and won't effect the PR at all.

Anyway, please go ahead and install this patch.

Thanks,
jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNmg0pAAoJEBRtltQi2kC7ex8H/3M0G8uXjO7kVhQpuF9RN4sE
4MZ/+0+pYH+mQ8UPzBp7+/YexyDcF5pJErZS3kp9J45JZhm+iWT5sUT5JDs8XeXb
Ye4tBvyCItPGy1M6/Vi7ycSm84dCLK1SKsZcA9Nggjy/C6BIuHNKB0B3Lw+ljOtc
gOXlIJZZH7DT1pIOR2j1Lh7FcuuESxE718kvW+Jakp6vTB454ZJz1yzcvoSC66bK
Y74zqjO0JyZVt+iNx/pfsqPvhhmKVp0M6+J6vLZKQx/4VIQOTKC4fi0bSyJK94ec
4JG3idbM0K6lhr/xNxq4IWNutwDsiitYEZw8fb4wA+l8yoTGxuyR5fFa1qQIjNw=
=iXl3
-----END PGP SIGNATURE-----

Patch

2011-04-01  Tom de Vries  <tom@codesourcery.com>

	PR target/43920
	* cfgcleanup.c (try_crossjump_bb): Remove 2 superfluous variables.

diff -u gcc/cfgcleanup.c gcc/cfgcleanup.c
--- gcc/cfgcleanup.c	(working copy)
+++ gcc/cfgcleanup.c	(working copy)
@@ -1961,7 +1961,6 @@ 
   edge e, e2, fallthru;
   bool changed;
   unsigned max, ix, ix2;
-  basic_block ev, ev2;
 
   /* Nothing to do if there is not at least two incoming edges.  */
   if (EDGE_COUNT (bb->preds) < 2)
@@ -2001,9 +2000,9 @@ 
   fallthru = find_fallthru_edge (bb->preds);
 
   changed = false;
-  for (ix = 0, ev = bb; ix < EDGE_COUNT (ev->preds); )
+  for (ix = 0; ix < EDGE_COUNT (bb->preds);)
     {
-      e = EDGE_PRED (ev, ix);
+      e = EDGE_PRED (bb, ix);
       ix++;
 
       /* As noted above, first try with the fallthru predecessor (or, a
@@ -2021,7 +2020,6 @@ 
 	    {
 	      changed = true;
 	      ix = 0;
-	      ev = bb;
 	      continue;
 	    }
 	}
@@ -2045,10 +2043,9 @@ 
       if (EDGE_SUCC (e->src, 0) != e)
 	continue;
 
-      for (ix2 = 0, ev2 = bb; ix2 < EDGE_COUNT (ev2->preds); )
+      for (ix2 = 0; ix2 < EDGE_COUNT (bb->preds); ix2++)
 	{
-	  e2 = EDGE_PRED (ev2, ix2);
-	  ix2++;
+	  e2 = EDGE_PRED (bb, ix2);
 
 	  if (e2 == e)
 	    continue;
@@ -2071,7 +2068,6 @@ 
 	  if (try_crossjump_to_edge (mode, e, e2))
 	    {
 	      changed = true;
-	      ev2 = bb;
 	      ix = 0;
 	      break;
 	    }