Message ID | 152234048028.19153.843006403471156320.stgit@localhost.localdomain |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=virtuozzo.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="PKQ0pDUM"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40Bqkq32B1z9s1c for <patchwork-incoming-netdev@ozlabs.org>; Fri, 30 Mar 2018 03:21:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752629AbeC2QVe (ORCPT <rfc822;patchwork-incoming-netdev@ozlabs.org>); Thu, 29 Mar 2018 12:21:34 -0400 Received: from mail-he1eur01on0111.outbound.protection.outlook.com ([104.47.0.111]:59470 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751714AbeC2QVa (ORCPT <rfc822;netdev@vger.kernel.org>); Thu, 29 Mar 2018 12:21:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=nxUwgyNxUh3tfTpypU3K6PYcwjCHAjqafbaLzZxuVMY=; b=PKQ0pDUMJjo91eNPjHYaaXAOPE35ZKeegWtgPdu82dzdhtpPT8Is8c6InW09V4OFE4ojbCCn82pqDpfgGAy5UV1sTTCAGTA+GYupmXauVnbDl8RjD3FUHCrJCCuPDFCnLJ4LAjJ20pM7XfaxSEZMSD8/5jBWFhJQLAaaYszdcRo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ktkhai@virtuozzo.com; Received: from localhost.localdomain (195.214.232.6) by HE1PR0801MB1338.eurprd08.prod.outlook.com (2603:10a6:3:39::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.609.10; Thu, 29 Mar 2018 16:21:22 +0000 Subject: [PATCH net-next 5/5] net: Remove rtnl_lock() in nf_ct_iterate_destroy() From: Kirill Tkhai <ktkhai@virtuozzo.com> To: dledford@redhat.com, jgg@ziepe.ca, davem@davemloft.net, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, pshelar@ovn.org, johannes@sipsolutions.net, paul@paul-moore.com, sds@tycho.nsa.gov, eparis@parisplace.org, jmorris@namei.org, serge@hallyn.com, leon@kernel.org, yuval.shaia@oracle.com, parav@mellanox.com, danielj@mellanox.com, ktkhai@virtuozzo.com, majd@mellanox.com, nicolas.dichtel@6wind.com, vyasevic@redhat.com, paulmck@linux.vnet.ibm.com, vyasevich@gmail.com, gregkh@linuxfoundation.org, daniel@iogearbox.net, jakub.kicinski@netronome.com, ast@kernel.org, brouer@redhat.com, linux@rasmusvillemoes.dk, john.fastabend@gmail.com, dsahern@gmail.com, jiri@mellanox.com, idosch@mellanox.com, vvs@virtuozzo.com, avagin@virtuozzo.com, roman.kapl@sysgo.com, lucien.xin@gmail.com, christian.brauner@ubuntu.com, jbenc@redhat.com, pombredanne@nexb.com, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, dev@openvswitch.org, linux-wireless@vger.kernel.org, selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org Date: Thu, 29 Mar 2018 19:21:20 +0300 Message-ID: <152234048028.19153.843006403471156320.stgit@localhost.localdomain> In-Reply-To: <152234005959.19153.17907173734141707348.stgit@localhost.localdomain> References: <152234005959.19153.17907173734141707348.stgit@localhost.localdomain> User-Agent: StGit/0.18 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1PR0701CA0045.eurprd07.prod.outlook.com (2603:10a6:3:9e::13) To HE1PR0801MB1338.eurprd08.prod.outlook.com (2603:10a6:3:39::28) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f67dfd1-5cb3-4d40-0c09-08d595911d77 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0801MB1338; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1338; 3:4JnkbppO6wQN6/OsLwTl1WJqgu4TXdavQNRL8HaB3/jt22hse6YVqXYKHnolzHfhvyYE1EnQKiWG6Y93UVKk02xpaedsi24pSOP1sLk2XN3t5ecm1woh/3JMjjsQtR02MZgM13FkS+0a6GDdJPBuI7BGxcHE2SZDMMICJ0oj1n7AuRX5JtucH43o8MbmNme0KXYM5jXW/y+JHRnV3xzcD24R1gnCIXPrbhwq3tSLTKAoOf4bUpw88y2rVI9PUM+1; 25:9Bj65RPuw3fY1LSugZxkZRW8DHQP64GjEiriBE6nMhum8t16fDbJMgCDyR1PeEKc/HxHBkKAtCbCH5oUrx+8M11+aVnHek8qdKheH6drE7wMlrrCrdJaF2hrRHfyGK5BgJPEbfO9e5osOBKjdR0x2tuiJ/4gzP49pEVgNmtcIdxB/iue+AdfFwqUh/IAUcXDIdNwvzVwmCjmjXZFGKZHr/tOs8jNP3/PRrvKbjxdxnLEf7R1v9wVefynnW7jh70HUqXDle1HSQb0B3uAwg2d/stwqd+ZWw+HqLio1H2aOtz9o0OSMLSNxkULUZDFYB05ddPFVlICWuMyN9vyAzhluQ==; 31:gbpUfq2O3PKkkfVU19Rshg+wJPfzVCMsyoBq0BLkf4DfaZQtl4/xQps3pBi4HKBY/ZV1/QC/G1nqKJm002Rpk/WQ+OY1xI1iIY+jN3bps5u9/u1gYkOz07+INorCygOx+vKjCwi++VbK2pJdG+30AznRK1pmQ1mFMkkNZpE/bLbIOtv8PsQuY+Ah30o0VFJhLSj0peJ+4GILz9VdwKjQOowyzV2nWCPMhlRI9ykk+44= X-MS-TrafficTypeDiagnostic: HE1PR0801MB1338: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1338; 20:/l4JVsP13uPPGvr6LHB8FmaEmIYjwwpmlhgN+LTXpTJPv3pzp8zBkUdh4Jf35kLx6OfPO3GZjZ89+7nmfH/njt+IgTGaSkAfRvouFUSUnRjEeBAI6tmZYtIocpIGloSksvm0HxiQOWuF3BYFWvsnInyp4UnHnZ3V7iDd7j9NIgNYFIRDWtr1m0+g69jd843+y1JbWWy5qVXKal9FI2lRlt2/7zzef20BQr5lRIYjoNchUoNmYGtnoM1/LJdhCKLAB5Kkwlm1uyKCfAMqcePAF43BTHL1U4++yuK1LJam6XZm70ZgQ+HCcb5cXhaY1034MOv2dDEGvj7kfw9W6AMjMTziZhg8H7mUGGVrOtel7qLRwAlzmqeXOsSt82W5e776c91lddtgbK42eVLhMXgXj1lyJ/zlFD0NdpR8qaLO3NXTBZdSYXioQ4UAYATrLOG/ndDE8MhQlU58KKXeABxQ+Wa/VKAniguZgwaVZqk4lvu3T6T6Bg2j0ovbJKbKtAmn; 4:OHRHqPLTK2Qain4/4L4DYx9j+2D2MfDGf7xcCeI267aal7Rw5h/OXLQS5G4vHuOm0mEt224o3w771v4I7R0yKbjrbsvbB28dVkGDBDwLUKHHJ2fx9M+BaMnDcigEESDlF4d5YXCJ5ItqOagdPdzNV3ROy6KE7AhsKUIwzKU9mFKyDOnfyasJxlHjxrpncx0HyYqswscPSBUzWP4dMe3aIh3dNrl2BgRKAvcR4A0VFcTNiP7VEjOA0gawI5NZ+qbL/StNZQpOUL8sQjLLr7vdJw== X-Microsoft-Antispam-PRVS: <HE1PR0801MB13386748C395481308B803E9CDA20@HE1PR0801MB1338.eurprd08.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3231221)(944501327)(52105095)(93006095)(93001095)(3002001)(10201501046)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:HE1PR0801MB1338; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0801MB1338; X-Forefront-PRVS: 0626C21B10 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6069001)(39380400002)(366004)(39850400004)(346002)(396003)(376002)(189003)(199004)(386003)(316002)(6506007)(105586002)(25786009)(61506002)(7696005)(50466002)(7406005)(39060400002)(103116003)(7416002)(305945005)(5660300001)(33896004)(478600001)(8936002)(97736004)(52116002)(76176011)(68736007)(476003)(58126008)(59450400001)(81166006)(446003)(11346002)(81156014)(55016002)(6116002)(7736002)(26005)(55236004)(66066001)(106356001)(53936002)(23676004)(2906002)(186003)(9686003)(8676002)(3846002)(486005)(86362001)(956004)(47776003)(16526019)(2486003)(230700001)(486005)(921003)(1121003); DIR:OUT; SFP:1102; SCL:1; SRVR:HE1PR0801MB1338; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BHE1PR0801MB1338=3B23=3AFL?= =?utf-8?q?FT8Tiz14bD2B3xlMek1gK3rL+1Lcobkz8DyirT8/iYEe6IsBDpXUhiNS?= =?utf-8?q?4N79FcGHzSk9KjWztAGR7a4G9nyIRCyWHZmodUU6YXPqJaMRyRi6oVW8?= =?utf-8?q?dkTnruVfDYQiIoig6zxHhuVPzCU6GFp+WMR6aay+zkYqTAygEpXpmlqo?= =?utf-8?q?koEtXJdXDkqQ6fw65h4/WmdjI6Q4II6c1atJHwsqF14rXEn0muoguHq6?= =?utf-8?q?tPr/wQoxaQMxrWiKSTxDc1EZtvi3pBYArWkKkMyDMQ9Ey5tKYiWN/cxk?= =?utf-8?q?vOg2zRKK8HTCFLuUElVyyV9wUUwqZ1A0WJggTBnw/gNl9bHnpQhIgkV4?= =?utf-8?q?qvthZTzQ/JnhpFJlmOAeNa9ToyIUz/J90gCccueTmiLdS2CeMnF3A6hK?= =?utf-8?q?zSd4FguWspESbsHCZ89afRdxk6pLMaXlgYhNV4E/npDZw7aVlJ2CVPHQ?= =?utf-8?q?j3eUAOSmx8Ik475EfsPsaK+HmNp5074C4oUYT6NHPJVTKNNg1lngJcGL?= =?utf-8?q?DavmrzHfwPEAbY+i1/gmjO5LW37RnMKAGxt+dvL+apeJlxIRHJIMQv8q?= =?utf-8?q?Cr+BYGlD10i+IPiYx4eTZQyzhAam8TRvjX+9UhFRH4d4/DMDmvKp2WlA?= =?utf-8?q?bsh/03EUVm2D/tqEZc32KFOJSLFDDIV9QfpTu/JT1QIJ6Fy8sKTl1S26?= =?utf-8?q?9XRICytIrwQKvhM9wRSAWFDULVNR0wq9udS1rrAd7a+FUFcV4a0sWsP4?= =?utf-8?q?imWwsmBeozxQLT1dzyeFEPg8w5IzMAiVS1VQhQR/l+C+6P303iFVxeeR?= =?utf-8?q?kBZ94TzHqv25ZJvf8+Pb7gw1ew+K11EsVFe2xBXQseZJMjbXXWbI/RAj?= =?utf-8?q?UOdshyiXfyi6jHPrhvUNW4JDoBiV6dp5YefDmcW9cibSlfs484HpbEiN?= =?utf-8?q?K72fhSzNsLCzRJCmqALFE1ZNYozptZ7UkF2r68e4fkK2cFosO5b49rCP?= =?utf-8?q?4x48N4KLODzxYn2a1o5eI3HxjbA2zCqSgCMoj/LXGduBoulMcZegkf6g?= =?utf-8?q?zXbV0WclunrZJd6QukPUumKlRp7P7Zs1o+YRrFvDIjTPPAQeGEW0yGIu?= =?utf-8?q?4wWtZIq0ffldaQGWfmz4bseyFhurAEOs13LcCw6z+yC7zB6nYeQRCuQH?= =?utf-8?q?02D/8i6fUq/5nj8bqMdcY4AsaK/yEXUZCW8ke5HlNqOxJPIZzOJSC5m8?= =?utf-8?q?gjzlcB7HNGp9jv950PVLrwN93XzaRgI5FnzDC79dM6u290CpHmYfXVjd?= =?utf-8?q?wEGVjtj11gIEvlF8BKrbWfqbiRxYuZ8bCn9/HrMU60h1OPf3p5hYlt8y?= =?utf-8?q?3m9YDdprhVpGXb3yI8xQku4N53p82GtohLCznOLx/xUjiJnJsW1EnNv1?= =?utf-8?q?TK+TVSdQdhF1R+WnJn4w=3D=3D?= X-Microsoft-Antispam-Message-Info: sCh7zVjIzHeEOPY0hdIo1g6kZDQq4IteGWGt1GNQVorkxYNLzhBbGW8kbJZ0FJOylEutqrMQ1/HgQ8zFnPvEkGTk074thUmxVHzWpVKlM7XtuUb59ZcBlmgMZlQH/CS//+ys+Cw/NXrMUOssyaQnsrlgNKezLYwdc0oj6bgTbV02R2nWEDW5oS4XfvF/+JV2 X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1338; 6:16XK9PVGlAukLM6XUKA1PffFLNmT4EMShEiskMUNyW66WvK/67x4BVrVnOqzJCypqXz7DGEZd1myoONGjwIGOd9GjOi++ChNnkAFg/RM8XWBz/0NKl1kxc+vjpfDsIgRdYfzpW7/QF4m1u4H0UrvOs9oYpnfnPE9xXdg8k1aCfU8oahJuCjTEsBir7vRRUkc3rUf3CEIy6CKTspqw4Mn0WY87kwpBAZNvO4MbtAnpKErEAKVbQSgKcW1EfmPH+/B9jDZu6FjKRVF0EgTiCsFzzFue+JZTvRVMpq/g0E+K++xCcPwmV/TuFcv7x689Th89iZB0N/x7XihpzzHrT7b90yD5x4Kd8xDWKcaToMWYvCz/an2mpHvptbBNtHB4w5c4OSEoiP21vFFpDIMCc0wESwkTyiVf6eKwKlp8oBzo3DfhTfgkmBDZ8Gqo8uC/gg/S5nsohLhRi3EVA8W0+88mQ==; 5:VGuMmSTRd8fFo/d4h+jQViscYmOjTBqrDXDL2thoYor5VTMFKUUEpMkKCJooewg+fhSoReATWJliPHxbPIxDqgWiOOhuN/x5Xugz40aAm/01xZq7P+M1SfzNvxJcoMMo8tljNEeaBh3s6X+kNzBTPUPLZO9xXCA4/NpBQTXEXyc=; 24:vOVYPWPKmtM085LA6UsEtjtBd4uXKuu86aftEnNuSZ1OH25uGuyptJT6COiystU9kifWoO1YLi2XLlZ4d4+kqFpOVoREzBVpuBomzCJw7yI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1338; 7:uXcl2n07zPMhmrwbr/HT9D0jlBKXVjw/rIs1OA8reYBKvegm888qu0+0MDSo7MlEaleAM+x6vLVPwJkkPIUdO6xkvXQFj+TW1slIVSHcH99f2ZyHjd9+BM3Rc0tbtyn9wwHfMcgXEES21etGy8uEI9AJRkUgbd+EUO14rEIV1VV6jNdMTn/zgJxoLBjkDQBq1hpyPIuJowbcQZOEAxyjrsY8f3teFovkbK2L81TArArYa6sQn78rY6LFk50KqiWx; 20:BZUBTw55BzihnIzyEj325vEK6ucLiDoVChkAMr4ksDv9NTgYYtTnfh7xInDs4yBXv7d4WuzapTWh2b7cWvNIjpPH2qw34T1B4VLiu9GhG26bZSsn8mxCu4bvmHHAMPAlbo7dHDfCYHdDG9p7zlthU7csTxGtDz4PeYdWVvw3YIQ= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2018 16:21:22.5711 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f67dfd1-5cb3-4d40-0c09-08d595911d77 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1338 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
Series |
Introduce net_rwsem to protect net_namespace_list
|
expand
|
diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c index 370f9b7f051b..41ff04ee2554 100644 --- a/net/netfilter/nf_conntrack_core.c +++ b/net/netfilter/nf_conntrack_core.c @@ -1763,7 +1763,6 @@ nf_ct_iterate_destroy(int (*iter)(struct nf_conn *i, void *data), void *data) { struct net *net; - rtnl_lock(); down_read(&net_rwsem); for_each_net(net) { if (atomic_read(&net->ct.count) == 0) @@ -1772,7 +1771,6 @@ nf_ct_iterate_destroy(int (*iter)(struct nf_conn *i, void *data), void *data) nf_queue_nf_hook_drop(net); } up_read(&net_rwsem); - rtnl_unlock(); /* Need to wait for netns cleanup worker to finish, if its * running -- it might have deleted a net namespace from
rtnl_lock() doesn't protect net::ct::count, and it's not needed for__nf_ct_unconfirmed_destroy() and for nf_queue_nf_hook_drop(). Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com> --- net/netfilter/nf_conntrack_core.c | 2 -- 1 file changed, 2 deletions(-)