| Message ID | 1522268824-2098-1-git-send-email-texier.pj2@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot,v2,1/2] warp7: configs: enable CONFIG_CMD_FS_GENERIC | expand |
On Wed, Mar 28, 2018 at 5:27 PM, Pierre-Jean TEXIER <texier.pj2@gmail.com> wrote: > This enable generic file system commands (load, ls). > > Signed-off-by: Pierre-Jean TEXIER <texier.pj2@gmail.com> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
On 28/03/18 21:27, Pierre-Jean TEXIER wrote: > This enable generic file system commands (load, ls). > > Signed-off-by: Pierre-Jean TEXIER <texier.pj2@gmail.com> > --- > Changes for v2: > - None > > configs/warp7_defconfig | 1 + > configs/warp7_secure_defconfig | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig > index 29c4512..3856918 100644 > --- a/configs/warp7_defconfig > +++ b/configs/warp7_defconfig > @@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y > CONFIG_CMD_EXT4=y > CONFIG_CMD_EXT4_WRITE=y > CONFIG_CMD_FAT=y > +CONFIG_CMD_FS_GENERIC=y > CONFIG_NET_RANDOM_ETHADDR=y > CONFIG_DFU_MMC=y > CONFIG_USB=y > diff --git a/configs/warp7_secure_defconfig b/configs/warp7_secure_defconfig > index 7310855..e894578 100644 > --- a/configs/warp7_secure_defconfig > +++ b/configs/warp7_secure_defconfig > @@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y > CONFIG_CMD_EXT4=y > CONFIG_CMD_EXT4_WRITE=y > CONFIG_CMD_FAT=y > +CONFIG_CMD_FS_GENERIC=y > CONFIG_DFU_MMC=y > CONFIG_USB=y > CONFIG_USB_EHCI_HCD=y > Pierre, Myself and Fabio have discussed dropping warp7_secure_defconfig. I've tested your change and it works well for the patchset I have in flight. https://patchwork.ozlabs.org/patch/893882/ Could you drop the part of this patch for warp7_secure_defconfig - in a v3 ? That way my patch and your patch can apply independently and in any order Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- bod
Hi Bryan, 2018-04-01 0:21 GMT+02:00 Bryan O'Donoghue <bryan.odonoghue@linaro.org>: > > > On 28/03/18 21:27, Pierre-Jean TEXIER wrote: > >> This enable generic file system commands (load, ls). >> >> Signed-off-by: Pierre-Jean TEXIER <texier.pj2@gmail.com> >> --- >> Changes for v2: >> - None >> >> configs/warp7_defconfig | 1 + >> configs/warp7_secure_defconfig | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig >> index 29c4512..3856918 100644 >> --- a/configs/warp7_defconfig >> +++ b/configs/warp7_defconfig >> @@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y >> CONFIG_CMD_EXT4=y >> CONFIG_CMD_EXT4_WRITE=y >> CONFIG_CMD_FAT=y >> +CONFIG_CMD_FS_GENERIC=y >> CONFIG_NET_RANDOM_ETHADDR=y >> CONFIG_DFU_MMC=y >> CONFIG_USB=y >> diff --git a/configs/warp7_secure_defconfig >> b/configs/warp7_secure_defconfig >> index 7310855..e894578 100644 >> --- a/configs/warp7_secure_defconfig >> +++ b/configs/warp7_secure_defconfig >> @@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y >> CONFIG_CMD_EXT4=y >> CONFIG_CMD_EXT4_WRITE=y >> CONFIG_CMD_FAT=y >> +CONFIG_CMD_FS_GENERIC=y >> CONFIG_DFU_MMC=y >> CONFIG_USB=y >> CONFIG_USB_EHCI_HCD=y >> >> > Pierre, > > Myself and Fabio have discussed dropping warp7_secure_defconfig. I've > tested your change and it works well for the patchset I have in flight. > > https://patchwork.ozlabs.org/patch/893882/ > > Could you drop the part of this patch for warp7_secure_defconfig - in a v3 > ? > No problem, I will send a v3. > > That way my patch and your patch can apply independently and in any order > > Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > > --- > bod > --- Pierre-Jean
diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig index 29c4512..3856918 100644 --- a/configs/warp7_defconfig +++ b/configs/warp7_defconfig @@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y CONFIG_CMD_EXT4=y CONFIG_CMD_EXT4_WRITE=y CONFIG_CMD_FAT=y +CONFIG_CMD_FS_GENERIC=y CONFIG_NET_RANDOM_ETHADDR=y CONFIG_DFU_MMC=y CONFIG_USB=y diff --git a/configs/warp7_secure_defconfig b/configs/warp7_secure_defconfig index 7310855..e894578 100644 --- a/configs/warp7_secure_defconfig +++ b/configs/warp7_secure_defconfig @@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y CONFIG_CMD_EXT4=y CONFIG_CMD_EXT4_WRITE=y CONFIG_CMD_FAT=y +CONFIG_CMD_FS_GENERIC=y CONFIG_DFU_MMC=y CONFIG_USB=y CONFIG_USB_EHCI_HCD=y
This enable generic file system commands (load, ls). Signed-off-by: Pierre-Jean TEXIER <texier.pj2@gmail.com> --- Changes for v2: - None configs/warp7_defconfig | 1 + configs/warp7_secure_defconfig | 1 + 2 files changed, 2 insertions(+)