diff mbox series

[U-Boot,V3,6/6] net: fec: Fix issue in DM probe timeout

Message ID 20180328125416.28056-6-peng.fan@nxp.com
State Accepted
Commit 2087eac25709071e5e4f32706db91a257160ef36
Delegated to: Joe Hershberger
Headers show
Series [U-Boot,V3,1/6] net: fec_mxc: Fix DM driver issue in recv | expand

Commit Message

Peng Fan March 28, 2018, 12:54 p.m. UTC 
From: Ye Li <ye.li@nxp.com>

Since the probe function has changed to reset FEC controller prior than
setup PHY. If reset FEC controller timeout, the priv->phydev is not
initialized, so can't free it.

Signed-off-by: Ye Li <ye.li@nxp.com>
---

V3: New

 drivers/net/fec_mxc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Joe Hershberger March 29, 2018, 3:36 a.m. UTC | #1 
On Wed, Mar 28, 2018 at 7:54 AM, Peng Fan <peng.fan@nxp.com> wrote:
> From: Ye Li <ye.li@nxp.com>
>
> Since the probe function has changed to reset FEC controller prior than
> setup PHY. If reset FEC controller timeout, the priv->phydev is not
> initialized, so can't free it.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Joe Hershberger April 15, 2018, 4:16 a.m. UTC | #2 
Hi Peng,

https://patchwork.ozlabs.org/patch/892217/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe
diff mbox series

Patch

diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index 765226e3ab..4caeddb34d 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -1291,12 +1291,11 @@  static int fecmxc_probe(struct udevice *dev)
 
 	return 0;
 
-err_timeout:
-	free(priv->phydev);
 err_phy:
 	mdio_unregister(bus);
 	free(bus);
 err_mii:
+err_timeout:
 	fec_free_descs(priv);
 	return ret;
 }