diff mbox series

[U-Boot] warp7: configs: enable CONFIG_CMD_FS_GENERIC

Message ID 1522180233-27887-1-git-send-email-texier.pj2@gmail.com
State Superseded
Delegated to: Stefano Babic
Headers show
Series [U-Boot] warp7: configs: enable CONFIG_CMD_FS_GENERIC | expand

Commit Message

Pierre-Jean Texier March 27, 2018, 7:50 p.m. UTC
This enable generic file system commands (load, ls).

Signed-off-by: Pierre-Jean TEXIER <texier.pj2@gmail.com>
---
 configs/warp7_defconfig        | 1 +
 configs/warp7_secure_defconfig | 1 +
 2 files changed, 2 insertions(+)

Comments

Fabio Estevam March 28, 2018, 1:02 a.m. UTC | #1
Hi Pierre-Jean,

On Tue, Mar 27, 2018 at 4:50 PM, Pierre-Jean TEXIER
<texier.pj2@gmail.com> wrote:
> This enable generic file system commands (load, ls).
>
> Signed-off-by: Pierre-Jean TEXIER <texier.pj2@gmail.com>
> ---
>  configs/warp7_defconfig        | 1 +
>  configs/warp7_secure_defconfig | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig
> index 29c4512..3856918 100644
> --- a/configs/warp7_defconfig
> +++ b/configs/warp7_defconfig
> @@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
>  CONFIG_CMD_EXT4=y
>  CONFIG_CMD_EXT4_WRITE=y
>  CONFIG_CMD_FAT=y
> +CONFIG_CMD_FS_GENERIC=y

It is OK to make this change, but please also change
include/configs/warp.h so that is uses 'load' instead of 'fatload'.

Also, please run ./scripts/get_maintainer.pl so that you do not miss
to Cc the board maintainer and also Stefano Babic.

Thanks
Pierre-Jean Texier March 28, 2018, 4:34 p.m. UTC | #2
Hi Fabio


Le 28/03/2018 à 03:02, Fabio Estevam a écrit :
> Hi Pierre-Jean,
>
> On Tue, Mar 27, 2018 at 4:50 PM, Pierre-Jean TEXIER
> <texier.pj2@gmail.com> wrote:
>> This enable generic file system commands (load, ls).
>>
>> Signed-off-by: Pierre-Jean TEXIER <texier.pj2@gmail.com>
>> ---
>>   configs/warp7_defconfig        | 1 +
>>   configs/warp7_secure_defconfig | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig
>> index 29c4512..3856918 100644
>> --- a/configs/warp7_defconfig
>> +++ b/configs/warp7_defconfig
>> @@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
>>   CONFIG_CMD_EXT4=y
>>   CONFIG_CMD_EXT4_WRITE=y
>>   CONFIG_CMD_FAT=y
>> +CONFIG_CMD_FS_GENERIC=y
> It is OK to make this change, but please also change

Ok thanks !

> include/configs/warp.h so that is uses 'load' instead of 'fatload'.

No problem, I will submit a patch for this part.

>
> Also, please run ./scripts/get_maintainer.pl so that you do not miss
> to Cc the board maintainer and also Stefano Babic.

Indeed, sorry for that, this is an oversight.

>
> Thanks

Thanks

---
Pierre-Jean
diff mbox series

Patch

diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig
index 29c4512..3856918 100644
--- a/configs/warp7_defconfig
+++ b/configs/warp7_defconfig
@@ -26,6 +26,7 @@  CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DFU_MMC=y
 CONFIG_USB=y
diff --git a/configs/warp7_secure_defconfig b/configs/warp7_secure_defconfig
index 7310855..e894578 100644
--- a/configs/warp7_secure_defconfig
+++ b/configs/warp7_secure_defconfig
@@ -26,6 +26,7 @@  CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
 CONFIG_DFU_MMC=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y