diff mbox series

[U-Boot,08/36] rockchip: rk322x: remove use rockchip timer as sys timer

Message ID 1522142971-20739-9-git-send-email-kever.yang@rock-chips.com
State Changes Requested
Delegated to: Philipp Tomsich
Headers show
Series rockchip: clean up board file for rockchip SoCs | expand

Commit Message

Kever Yang March 27, 2018, 9:29 a.m. UTC
We can use arch timer instead of rockchip timer.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

 include/configs/rk322x_common.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Philipp Tomsich April 1, 2018, 8:21 p.m. UTC | #1
> We can use arch timer instead of rockchip timer.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  include/configs/rk322x_common.h | 3 ---
>  1 file changed, 3 deletions(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich April 1, 2018, 9:03 p.m. UTC | #2
On Tue, 27 Mar 2018, Kever Yang wrote:

> We can use arch timer instead of rockchip timer.

A slightly more enlightening commit message would be great.

> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

These changes for (for the timer) should go into a separate series.
Also: you should refactor these patches in such a way that the tree (after 
every patch that is applied) this builds.  A good way to do so is to do 
one device after another per patch.

> ---
>
> include/configs/rk322x_common.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/configs/rk322x_common.h b/include/configs/rk322x_common.h
> index 832f037..29e222a 100644
> --- a/include/configs/rk322x_common.h
> +++ b/include/configs/rk322x_common.h
> @@ -14,9 +14,6 @@
> #define CONFIG_SYS_CBSIZE		1024
> #define CONFIG_SYS_BOOTM_LEN	(64 << 20)	/*  64M */
>
> -#define CONFIG_SYS_TIMER_RATE		(24 * 1000 * 1000)
> -#define CONFIG_SYS_TIMER_BASE		0x110c00a0 /* TIMER5 */
> -#define CONFIG_SYS_TIMER_COUNTER	(CONFIG_SYS_TIMER_BASE + 8)
>
> #define CONFIG_SYS_INIT_SP_ADDR		0x60100000
> #define CONFIG_SYS_LOAD_ADDR		0x60800800
>
diff mbox series

Patch

diff --git a/include/configs/rk322x_common.h b/include/configs/rk322x_common.h
index 832f037..29e222a 100644
--- a/include/configs/rk322x_common.h
+++ b/include/configs/rk322x_common.h
@@ -14,9 +14,6 @@ 
 #define CONFIG_SYS_CBSIZE		1024
 #define CONFIG_SYS_BOOTM_LEN	(64 << 20)	/*  64M */
 
-#define CONFIG_SYS_TIMER_RATE		(24 * 1000 * 1000)
-#define CONFIG_SYS_TIMER_BASE		0x110c00a0 /* TIMER5 */
-#define CONFIG_SYS_TIMER_COUNTER	(CONFIG_SYS_TIMER_BASE + 8)
 
 #define CONFIG_SYS_INIT_SP_ADDR		0x60100000
 #define CONFIG_SYS_LOAD_ADDR		0x60800800