From patchwork Thu Mar 31 19:44:06 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 89120 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8821AB6EDD for ; Fri, 1 Apr 2011 06:46:04 +1100 (EST) Received: from localhost ([127.0.0.1]:36721 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5NoL-0007RI-Cd for incoming@patchwork.ozlabs.org; Thu, 31 Mar 2011 15:45:41 -0400 Received: from [140.186.70.92] (port=56414 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5Nn9-0007Pb-4V for qemu-devel@nongnu.org; Thu, 31 Mar 2011 15:44:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5Nn8-0001cn-35 for qemu-devel@nongnu.org; Thu, 31 Mar 2011 15:44:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5Nn7-0001cX-OU for qemu-devel@nongnu.org; Thu, 31 Mar 2011 15:44:26 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2VJiMZE023558 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 31 Mar 2011 15:44:22 -0400 Received: from localhost (ovpn-113-107.phx2.redhat.com [10.3.113.107]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2VJiISj019705; Thu, 31 Mar 2011 15:44:19 -0400 From: Amit Shah To: qemu list Date: Fri, 1 Apr 2011 01:14:06 +0530 Message-Id: <2a24c3a3e75c383de13b87d064fb958ea9f268ff.1301600598.git.amit.shah@redhat.com> In-Reply-To: <20110331095325.GA13226@amit-x200.redhat.com> References: <20110331095325.GA13226@amit-x200.redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Gleb Natapov , Juan Quintela , Stefan Hajnoczi , Markus Armbruster , Amit Shah Subject: [Qemu-devel] [RFC PATCH 1/3] ide: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This makes the code more readable. Also, there's a block like: if () { ... } else { ... } Split that into if () { ... return; } ... Signed-off-by: Amit Shah --- hw/ide/core.c | 37 ++++++++++++++++++++++++------------- 1 files changed, 24 insertions(+), 13 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 007a4ee..e14f2d3 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1084,6 +1084,29 @@ static int ide_dvd_read_structure(IDEState *s, int format, } } +static void handle_get_event_status_notification(IDEState *s, + uint8_t *buf, + const uint8_t *packet) +{ + unsigned int max_len; + + max_len = ube16_to_cpu(packet + 7); + + if (!(packet[1] & 0x01)) { /* asynchronous mode */ + /* Only polling is supported, asynchronous mode is not. */ + ide_atapi_cmd_error(s, SENSE_ILLEGAL_REQUEST, + ASC_INV_FIELD_IN_CMD_PACKET); + return; + } + + /* polling */ + /* We don't support any event class (yet). */ + cpu_to_ube16(buf, 0x00); /* No event descriptor returned */ + buf[2] = 0x80; /* No Event Available (NEA) */ + buf[3] = 0x00; /* Empty supported event classes */ + ide_atapi_cmd_reply(s, 4, max_len); +} + static void ide_atapi_cmd(IDEState *s) { const uint8_t *packet; @@ -1522,19 +1545,7 @@ static void ide_atapi_cmd(IDEState *s) break; } case GPCMD_GET_EVENT_STATUS_NOTIFICATION: - max_len = ube16_to_cpu(packet + 7); - - if (packet[1] & 0x01) { /* polling */ - /* We don't support any event class (yet). */ - cpu_to_ube16(buf, 0x00); /* No event descriptor returned */ - buf[2] = 0x80; /* No Event Available (NEA) */ - buf[3] = 0x00; /* Empty supported event classes */ - ide_atapi_cmd_reply(s, 4, max_len); - } else { /* asynchronous mode */ - /* Only polling is supported, asynchronous mode is not. */ - ide_atapi_cmd_error(s, SENSE_ILLEGAL_REQUEST, - ASC_INV_FIELD_IN_CMD_PACKET); - } + handle_get_event_status_notification(s, buf, packet); break; default: ide_atapi_cmd_error(s, SENSE_ILLEGAL_REQUEST,