| Message ID | 20180326172041.21009-1-marcandre.lureau@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qmp-test: fix response leak | expand |
On 03/26/2018 12:20 PM, Marc-André Lureau wrote: > Apparently introduced in commit a4f90923b520f1dc0a768634877eb412e5052c26. > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > tests/qmp-test.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake <eblake@redhat.com> I'll queue this through my qapi tree, unless applying Peter's for-2.12 patches fixes it differently. > > diff --git a/tests/qmp-test.c b/tests/qmp-test.c > index 558e83540c..8de99a4727 100644 > --- a/tests/qmp-test.c > +++ b/tests/qmp-test.c > @@ -90,6 +90,7 @@ static void test_qmp_protocol(void) > test_version(qdict_get(q, "version")); > capabilities = qdict_get_qlist(q, "capabilities"); > g_assert(capabilities && qlist_empty(capabilities)); > + QDECREF(resp); > > /* Test valid command before handshake */ > resp = qtest_qmp(qts, "{ 'execute': 'query-version' }"); >
On 03/26/2018 01:33 PM, Eric Blake wrote: > On 03/26/2018 12:20 PM, Marc-André Lureau wrote: >> Apparently introduced in commit a4f90923b520f1dc0a768634877eb412e5052c26. >> >> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> >> --- >> tests/qmp-test.c | 1 + >> 1 file changed, 1 insertion(+) > > Reviewed-by: Eric Blake <eblake@redhat.com> > > I'll queue this through my qapi tree, unless applying Peter's for-2.12 > patches fixes it differently. Okay, it's needed, and I'm queuing it.
diff --git a/tests/qmp-test.c b/tests/qmp-test.c index 558e83540c..8de99a4727 100644 --- a/tests/qmp-test.c +++ b/tests/qmp-test.c @@ -90,6 +90,7 @@ static void test_qmp_protocol(void) test_version(qdict_get(q, "version")); capabilities = qdict_get_qlist(q, "capabilities"); g_assert(capabilities && qlist_empty(capabilities)); + QDECREF(resp); /* Test valid command before handshake */ resp = qtest_qmp(qts, "{ 'execute': 'query-version' }");
Apparently introduced in commit a4f90923b520f1dc0a768634877eb412e5052c26. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- tests/qmp-test.c | 1 + 1 file changed, 1 insertion(+)