Patchwork [PR43920,3/9] Cleanup.

login
register
mail settings
Submitter Tom de Vries
Date March 31, 2011, 6:29 p.m.
Message ID <4D94C80C.10100@codesourcery.com>
Download mbox | patch
Permalink /patch/89107/
State New
Headers show

Comments

Tom de Vries - March 31, 2011, 6:29 p.m.
Cleans up some code.

Thanks,
- Tom
Jeff Law - March 31, 2011, 6:40 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/31/11 12:29, Tom de Vries wrote:
> Cleans up some code.
OK.  Note that it would have helped if you mentioned that "bb" was a
loop invariant and thus "ev" and "ev2" were loop invariants that could
be replaced by "bb".

Please install..  Thanks,

jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNlMqtAAoJEBRtltQi2kC7AVYIAIWNzXn/51nk+xp4ZE+PS3T6
NU/y9m0q3x/hU+SpSzFX5l+hw/+mT+WQou9fU/Gzf9CQlWLk4i+6cXLbG60vGmFo
b38R4R7qnPpAI1OiHddaoh5eGzYHWkZQdgtYxLkJv6oqwF0EzSMg7/F7lXkaPsZK
agSSQBNFNTWFV3jD+YeplioAWphzbWeQf+d5glNuc5sP+ImUU/Mpg5Sh1WC3n1C3
i9XBwSczwzikHyvrmGJQcdcv3NL9MkazcMSbCD7jg32Zx/bXqdtlJ+qzkQGv1PAt
VQMzna8mqm3YDd4yOUo3xzJBA1SQM8Ff8xd1dVm4QL8WUPDBNZztobQ5f2U4Zi4=
=bDHO
-----END PGP SIGNATURE-----

Patch

diff -u gcc/cfgcleanup.c gcc/cfgcleanup.c
--- gcc/cfgcleanup.c	(working copy)
+++ gcc/cfgcleanup.c	(working copy)
@@ -1961,7 +1961,6 @@ 
   edge e, e2, fallthru;
   bool changed;
   unsigned max, ix, ix2;
-  basic_block ev, ev2;
 
   /* Nothing to do if there is not at least two incoming edges.  */
   if (EDGE_COUNT (bb->preds) < 2)
@@ -2001,9 +2000,9 @@ 
   fallthru = find_fallthru_edge (bb->preds);
 
   changed = false;
-  for (ix = 0, ev = bb; ix < EDGE_COUNT (ev->preds); )
+  for (ix = 0; ix < EDGE_COUNT (bb->preds);)
     {
-      e = EDGE_PRED (ev, ix);
+      e = EDGE_PRED (bb, ix);
       ix++;
 
       /* As noted above, first try with the fallthru predecessor (or, a
@@ -2021,7 +2020,6 @@ 
 	    {
 	      changed = true;
 	      ix = 0;
-	      ev = bb;
 	      continue;
 	    }
 	}
@@ -2045,10 +2043,9 @@ 
       if (EDGE_SUCC (e->src, 0) != e)
 	continue;
 
-      for (ix2 = 0, ev2 = bb; ix2 < EDGE_COUNT (ev2->preds); )
+      for (ix2 = 0; ix2 < EDGE_COUNT (bb->preds); ix2++)
 	{
-	  e2 = EDGE_PRED (ev2, ix2);
-	  ix2++;
+	  e2 = EDGE_PRED (bb, ix2);
 
 	  if (e2 == e)
 	    continue;
@@ -2071,7 +2068,6 @@ 
 	  if (try_crossjump_to_edge (mode, e, e2))
 	    {
 	      changed = true;
-	      ev2 = bb;
 	      ix = 0;
 	      break;
 	    }