| Message ID | 1521874181-13648-1-git-send-email-andy.yan@rock-chips.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Philipp Tomsich |
| Headers | show |
| Series | [U-Boot] sysreset: rockchip: use dev_read_addr_ptr get cru base | expand |
> On 24 Mar 2018, at 07:49, Andy Yan <andy.yan@rock-chips.com> wrote: > > Use system api dev_read_addr_ptr to get cru reg base, > rather than rockchip private api rockchip_get_cru, which > will be cleanup later. > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Andy, > On 24 Mar 2018, at 11:50, Dr. Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote: > > >> On 24 Mar 2018, at 07:49, Andy Yan <andy.yan@rock-chips.com> wrote: >> >> Use system api dev_read_addr_ptr to get cru reg base, >> rather than rockchip private api rockchip_get_cru, which >> will be cleanup later. >> >> Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> This one breaks the build: https://travis-ci.org/ptomsich/u-boot-rockchip/builds/371147039 Please revise accordingly. Always ensure that a submitted series does not cause any build failures as this is a major distraction when trying to process multiple series… Thanks, Philipp.
diff --git a/drivers/sysreset/sysreset_rockchip.c b/drivers/sysreset/sysreset_rockchip.c index 894975f..6c584d0 100644 --- a/drivers/sysreset/sysreset_rockchip.c +++ b/drivers/sysreset/sysreset_rockchip.c @@ -10,14 +10,12 @@ #include <sysreset.h> #include <asm/io.h> #include <asm/arch/clock.h> -#include <asm/arch/cru_rk3328.h> -#include <asm/arch/hardware.h> #include <linux/err.h> int rockchip_sysreset_request(struct udevice *dev, enum sysreset_t type) { struct sysreset_reg *offset = dev_get_priv(dev); - unsigned long cru_base = (unsigned long)rockchip_get_cru(); + unsigned long cru_base = (unsigned long)dev_read_addr_ptr(dev->parent); if (IS_ERR_VALUE(cru_base)) return (int)cru_base;
Use system api dev_read_addr_ptr to get cru reg base, rather than rockchip private api rockchip_get_cru, which will be cleanup later. Signed-off-by: Andy Yan <andy.yan@rock-chips.com> --- drivers/sysreset/sysreset_rockchip.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)