[05/14] fscrypt: don't clear flags on crypto transform

Message ID 20180323192358.95691-6-ebiggers3@gmail.com
State Not Applicable, archived
Headers show
  • fscrypt: improved logging and other cleanups
Related show

Commit Message

Eric Biggers March 23, 2018, 7:23 p.m.
From: Eric Biggers <ebiggers@google.com>

fscrypt is clearing the flags on the crypto_skcipher it allocates for
each inode.  But, this is unnecessary and may cause problems in the
future because it will even clear flags that are meant to be internal to
the crypto API, e.g. CRYPTO_TFM_NEED_KEY.

Remove the unnecessary flag clearing.

Signed-off-by: Eric Biggers <ebiggers@google.com>
 fs/crypto/keyinfo.c | 1 -
 1 file changed, 1 deletion(-)


diff --git a/fs/crypto/keyinfo.c b/fs/crypto/keyinfo.c
index 8099388f5581..1435a1c81010 100644
--- a/fs/crypto/keyinfo.c
+++ b/fs/crypto/keyinfo.c
@@ -327,7 +327,6 @@  int fscrypt_get_encryption_info(struct inode *inode)
 		goto out;
 	crypt_info->ci_ctfm = ctfm;
-	crypto_skcipher_clear_flags(ctfm, ~0);
 	crypto_skcipher_set_flags(ctfm, CRYPTO_TFM_REQ_WEAK_KEY);
 	 * if the provided key is longer than keysize, we use the first