| Message ID | 1521785487-29866-6-git-send-email-mgautam@codeaurora.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | phy: qcom: Updates for USB PHYs on SDM845 | expand |
On Fri, Mar 23, 2018 at 11:41:26AM +0530, Manu Gautam wrote: > Update compatible strings for USB2 PHYs on sdm845. > There are two QUSB2 PHYs present on sdm845. Few PHY registers > programming is different for these PHYs related to electrical > parameters, otherwise both are same. > > Signed-off-by: Manu Gautam <mgautam@codeaurora.org> > --- > Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Thu, Mar 22, 2018 at 11:11 PM, Manu Gautam <mgautam@codeaurora.org> wrote: > Update compatible strings for USB2 PHYs on sdm845. > There are two QUSB2 PHYs present on sdm845. Few PHY registers > programming is different for these PHYs related to electrical > parameters, otherwise both are same. > > Signed-off-by: Manu Gautam <mgautam@codeaurora.org> > --- > Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > index 42c9742..b99a57f 100644 > --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > @@ -6,7 +6,9 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. > Required properties: > - compatible: compatible list, contains > "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, > - "qcom,qusb2-v2-phy" for QUSB2 V2 PHY. > + "qcom,qusb2-v2-phy" for QUSB2 V2 PHY, > + "qcom,sdm845-qusb2-phy-1" for primary PHY on sdm845, > + "qcom,sdm845-qusb2-phy-2" for secondary PHY on sdm845. Similar question to the one I posed on <https://patchwork.kernel.org/patch/10302761/> for the QMP PHY. What is "qcom,qusb2-v2-phy"? Is it some ideal abstract version of the PHY? Do we expect that anyone would actually use that compatible string? In this case in <https://patchwork.kernel.org/patch/10302755/> it looks as if you're using the same settings as "qcom,sdm845-qusb2-phy-2", so presumably "qcom,qusb2-v2-phy" should just be deleted. -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 3/28/2018 3:27 AM, Doug Anderson wrote: > Hi, > > On Thu, Mar 22, 2018 at 11:11 PM, Manu Gautam <mgautam@codeaurora.org> wrote: >> Update compatible strings for USB2 PHYs on sdm845. >> There are two QUSB2 PHYs present on sdm845. Few PHY registers >> programming is different for these PHYs related to electrical >> parameters, otherwise both are same. >> >> Signed-off-by: Manu Gautam <mgautam@codeaurora.org> >> --- >> Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt >> index 42c9742..b99a57f 100644 >> --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt >> +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt >> @@ -6,7 +6,9 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. >> Required properties: >> - compatible: compatible list, contains >> "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, >> - "qcom,qusb2-v2-phy" for QUSB2 V2 PHY. >> + "qcom,qusb2-v2-phy" for QUSB2 V2 PHY, >> + "qcom,sdm845-qusb2-phy-1" for primary PHY on sdm845, >> + "qcom,sdm845-qusb2-phy-2" for secondary PHY on sdm845. > Similar question to the one I posed on > <https://patchwork.kernel.org/patch/10302761/> for the QMP PHY. What > is "qcom,qusb2-v2-phy"? Is it some ideal abstract version of the PHY? > Do we expect that anyone would actually use that compatible string? > > In this case in <https://patchwork.kernel.org/patch/10302755/> it > looks as if you're using the same settings as > "qcom,sdm845-qusb2-phy-2", so presumably "qcom,qusb2-v2-phy" should > just be deleted. > I will remove "qcom,qusb2-v2-phy". > -Doug
diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt index 42c9742..b99a57f 100644 --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt @@ -6,7 +6,9 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. Required properties: - compatible: compatible list, contains "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, - "qcom,qusb2-v2-phy" for QUSB2 V2 PHY. + "qcom,qusb2-v2-phy" for QUSB2 V2 PHY, + "qcom,sdm845-qusb2-phy-1" for primary PHY on sdm845, + "qcom,sdm845-qusb2-phy-2" for secondary PHY on sdm845. - reg: offset and length of the PHY register set. - #phy-cells: must be 0.
Update compatible strings for USB2 PHYs on sdm845. There are two QUSB2 PHYs present on sdm845. Few PHY registers programming is different for these PHYs related to electrical parameters, otherwise both are same. Signed-off-by: Manu Gautam <mgautam@codeaurora.org> --- Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)