From patchwork Thu Mar 22 20:19:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mathieu Malaterre X-Patchwork-Id: 889611 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=kvm-ppc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LyGdHKzv"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 406dS635Cmz9s27 for ; Fri, 23 Mar 2018 07:24:22 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751776AbeCVUYH (ORCPT ); Thu, 22 Mar 2018 16:24:07 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:37902 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbeCVUUv (ORCPT ); Thu, 22 Mar 2018 16:20:51 -0400 Received: by mail-wr0-f194.google.com with SMTP id l8so9997928wrg.5; Thu, 22 Mar 2018 13:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JQ6049q67KytLvrXqlWXomfh7HkoBlYVuvRLVwiuXP4=; b=LyGdHKzv44nBVQZ0YPlK1f8WQGL5sBKFBVJO7AOW08C4lNZwral6BNFwlpQ1aeaQ/1 Ga38UTbH8/zjHOb3cno8e16mSvboXybQSdGyaIvfWF/NTI5awYH103Wx+uDMQQqghGrb 7y7zdSVfreQPr0UTUbKBARg3nH88TA3xNmVUCrjaRZbrYHtru31XLtsbInYGP83tEhxF bm+kdmMJc3KrwxN96JW6LV/y1Y4yMRp0Ypu+8Jy8Wv/0DWdcHm7xCnZFgYL8W9FOLbGq 8hL6ZnSCxAbFji/uCjM4jDhOULnIQc+zkwgbcd5g/ccgE5fZVau+UVQayYnsX3peIhT5 TTuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=JQ6049q67KytLvrXqlWXomfh7HkoBlYVuvRLVwiuXP4=; b=TD5lGZAv6NrLbMtrVfRhqRrfzqm3EQulIPgamMRp9B8kFAEkCNvXVejQ17izsRnsyP pRFTXAW7EaFAXXy+aRH2lUuotEFSFT7befvj/KiUbp9MirnIoLU5r8S8kaPlOR1JNnxQ aedAtuIdt8Cy9mUq/YP9wGBiyUdRitnYU7ay55A26SUkkFlOOvF4YmraS5UXlID+82Tn AktImje2QYo3FKUtV4XtBmbgt6AqprVvb1Q30nEkQK6+d7/uEj2x+cVjeGyV2nOcDhTL pioPjDAgNt+3hwrpNQGnFa7QZd041xnLuYkKf3ajdG5D1jUyekQUNwdtu8g0SVcNaaQO KoPg== X-Gm-Message-State: AElRT7FhQxfANE2Oo/+V3gQZ2ol+YAG00lNl1NvHJfe3T3fyCXCQVZhQ JEkb5Hc8C9xmH7psEed1seo= X-Google-Smtp-Source: AG47ELs3AC5PoMo9c6IAgSo4ZC+8/6huh4yK24FaADxxTnAyXWtJElcxr1Y5HDtylRdoP75il7zHeQ== X-Received: by 10.223.159.79 with SMTP id f15mr21798277wrg.115.1521750050049; Thu, 22 Mar 2018 13:20:50 -0700 (PDT) Received: from macbookpro.malat.net (bru31-1-78-225-226-121.fbx.proxad.net. [78.225.226.121]) by smtp.gmail.com with ESMTPSA id o11sm7761574wrg.91.2018.03.22.13.20.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Mar 2018 13:20:49 -0700 (PDT) Received: by macbookpro.malat.net (Postfix, from userid 1000) id 8606410C03A5; Thu, 22 Mar 2018 21:20:48 +0100 (CET) From: Mathieu Malaterre To: Michael Ellerman Cc: Mathieu Malaterre , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org Subject: [PATCH 07/19] powerpc/powermac: Make some functions static Date: Thu, 22 Mar 2018 21:19:53 +0100 Message-Id: <20180322202007.23088-8-malat@debian.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180322202007.23088-1-malat@debian.org> References: <20180322202007.23088-1-malat@debian.org> MIME-Version: 1.0 Sender: kvm-ppc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm-ppc@vger.kernel.org These functions can all be static, make it so. Fix warnings treated as errors with W=1: arch/powerpc/platforms/powermac/pci.c:1022:6: error: no previous prototype for ‘pmac_pci_fixup_ohci’ [-Werror=missing-prototypes] arch/powerpc/platforms/powermac/pci.c:1057:6: error: no previous prototype for ‘pmac_pci_fixup_cardbus’ [-Werror=missing-prototypes] arch/powerpc/platforms/powermac/pci.c:1094:6: error: no previous prototype for ‘pmac_pci_fixup_pciata’ [-Werror=missing-prototypes] Also add gcc attribute unused to fix a warning treated as error with W=1: arch/powerpc/platforms/powermac/pci.c:784:19: error: variable ‘has_address’ set but not used [-Werror=unused-but-set-variable] arch/powerpc/platforms/powermac/pci.c:907:22: error: variable ‘ht’ set but not used [-Werror=unused-but-set-variable] Signed-off-by: Mathieu Malaterre --- arch/powerpc/platforms/powermac/pci.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/platforms/powermac/pci.c b/arch/powerpc/platforms/powermac/pci.c index 0b8174a79993..d3b9818dd880 100644 --- a/arch/powerpc/platforms/powermac/pci.c +++ b/arch/powerpc/platforms/powermac/pci.c @@ -781,7 +781,7 @@ static int __init pmac_add_bridge(struct device_node *dev) struct resource rsrc; char *disp_name; const int *bus_range; - int primary = 1, has_address = 0; + int primary = 1, has_address __maybe_unused = 0; DBG("Adding PCI host bridge %pOF\n", dev); @@ -904,7 +904,7 @@ static int pmac_pci_root_bridge_prepare(struct pci_host_bridge *bridge) void __init pmac_pci_init(void) { struct device_node *np, *root; - struct device_node *ht = NULL; + struct device_node *ht __maybe_unused = NULL; pci_set_flags(PCI_CAN_SKIP_ISA_ALIGN); @@ -1019,7 +1019,7 @@ static bool pmac_pci_enable_device_hook(struct pci_dev *dev) return true; } -void pmac_pci_fixup_ohci(struct pci_dev *dev) +static void pmac_pci_fixup_ohci(struct pci_dev *dev) { struct device_node *node = pci_device_to_OF_node(dev); @@ -1054,7 +1054,7 @@ void __init pmac_pcibios_after_init(void) } } -void pmac_pci_fixup_cardbus(struct pci_dev* dev) +static void pmac_pci_fixup_cardbus(struct pci_dev *dev) { if (!machine_is(powermac)) return; @@ -1091,7 +1091,7 @@ void pmac_pci_fixup_cardbus(struct pci_dev* dev) DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_TI, PCI_ANY_ID, pmac_pci_fixup_cardbus); -void pmac_pci_fixup_pciata(struct pci_dev* dev) +static void pmac_pci_fixup_pciata(struct pci_dev *dev) { u8 progif = 0;