From patchwork Wed Mar 30 18:27:00 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Kaiser X-Patchwork-Id: 88950 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pw0-f56.google.com (mail-pw0-f56.google.com [209.85.160.56]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 87C3FB6EF0 for ; Thu, 31 Mar 2011 05:28:18 +1100 (EST) Received: by pwj9 with SMTP id 9sf243581pwj.11 for ; Wed, 30 Mar 2011 11:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:x-beenthere:received-spf:date:from:to:cc :subject:message-id:in-reply-to:references:organization:face :x-mailer:mime-version:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=49EsVN4F8hOb7z3nAewI/quqSI4hsZI+Xv52MroZmhg=; b=xBtPX2Y3dHJEJvcyjhUtB5156mqJx3l2HnbkQRQAZ25S+hOBK/aFXu093nVHbcfIej UYKDbCH+BJfNSNUuCWrn6yRD4CPvkrbxKD1cccXqKJuwfllgu7M2tL3+bc92FogrJzs9 eHiqffxHCJdQFQ7t+63qIp9Ya6JNQhuKkXH/I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:date:from:to:cc:subject:message-id :in-reply-to:references:organization:face:x-mailer:mime-version :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type; b=k+DdJ5nQzLRRp95LMt27HLCWcW2mSU8AVOtLbepoep4fjQddutbPLl4qmRQyHEqcdK /uJAA5bBeKTDtHevQ+kgi2ZzN6uCRrhsxQoEppY/9JISXo5bnJfzpWD+2HpV6rnsB3C/ WagnF7xHIJ9MRSdUgR7psVDia3874qFThM7Fo= Received: by 10.142.171.2 with SMTP id t2mr173270wfe.23.1301509695114; Wed, 30 Mar 2011 11:28:15 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.142.97.18 with SMTP id u18ls920173wfb.2.p; Wed, 30 Mar 2011 11:28:14 -0700 (PDT) Received: by 10.142.195.3 with SMTP id s3mr1128503wff.22.1301509694330; Wed, 30 Mar 2011 11:28:14 -0700 (PDT) Received: by 10.142.195.3 with SMTP id s3mr1128502wff.22.1301509694304; Wed, 30 Mar 2011 11:28:14 -0700 (PDT) Received: from webhosting01.bon.m2soft.com (webhosting01.bon.m2soft.com [195.38.20.32]) by gmr-mx.google.com with ESMTPS id k41si291216wfa.7.2011.03.30.11.28.13 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 30 Mar 2011 11:28:13 -0700 (PDT) Received-SPF: pass (google.com: domain of nikai@nikai.net designates 195.38.20.32 as permitted sender) client-ip=195.38.20.32; Received: from absol.kitzblitz (85-127-39-214.dynamic.xdsl-line.inode.at [85.127.39.214]) (authenticated bits=0) by webhosting01.bon.m2soft.com (8.13.8/8.13.8) with ESMTP id p2UI50js020814; Wed, 30 Mar 2011 20:05:00 +0200 Date: Wed, 30 Mar 2011 20:27:00 +0200 From: Nicolas Kaiser To: Lars-Peter Clausen Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] [PATCH] drivers/rtc/rtc-jz4740.c: fix error check v2 Message-ID: <20110330202700.7d8142e8@absol.kitzblitz> In-Reply-To: <4D935C56.4060903@metafoo.de> References: <20110330181201.29e473bf@absol.kitzblitz> <4D935C56.4060903@metafoo.de> Organization: - Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAQMAAABtzGvEAAAAAXNSR0IArs4c6QAAAAZQTFRF AJnV/f/88sgWwwAAAKNJREFUGNM10LENwyAQheFHKCgZgTVSRHI2gy5reROTDSiREvnyHhdXnwXS+ T+ACJgBYTiGSmDDOTdR7XDeTi9ksxEcoKFcTOCJLO7kC5SWFjPZCR69nI9+x5u6OJM1RN5UYUiNKa ZRpHHUoqh1v8hKEZ1FSGCrYOvgVmxd9DIXcSJwLTycm7bj0e4wkJGB48w/FckAwUKl/OGDZAcqItk BU+wHXLqKsjYyPeMAAAAASUVORK5CYII= X-Mailer: Claws Mail (Linux) Mime-Version: 1.0 X-Original-Sender: nikai@nikai.net X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of nikai@nikai.net designates 195.38.20.32 as permitted sender) smtp.mail=nikai@nikai.net Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Checking 'rtc->irq < 0' doesn't work because 'rtc->irq' is unsigned. v2: return error code from platform_get_irq() instead of -ENOENT. Signed-off-by: Nicolas Kaiser Acked-by: Wan ZongShun --- drivers/rtc/rtc-jz4740.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c index b647363..efd9691 100644 --- a/drivers/rtc/rtc-jz4740.c +++ b/drivers/rtc/rtc-jz4740.c @@ -220,12 +220,12 @@ static int __devinit jz4740_rtc_probe(struct platform_device *pdev) if (!rtc) return -ENOMEM; - rtc->irq = platform_get_irq(pdev, 0); - if (rtc->irq < 0) { - ret = -ENOENT; + ret = platform_get_irq(pdev, 0); + if (ret < 0) { dev_err(&pdev->dev, "Failed to get platform irq\n"); goto err_free; } + rtc->irq = ret; rtc->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!rtc->mem) {