From patchwork Wed Mar 30 18:27:00 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: drivers/rtc/rtc-jz4740.c: fix error check v2 Date: Wed, 30 Mar 2011 08:27:00 -0000 From: Nicolas Kaiser X-Patchwork-Id: 88950 Message-Id: <20110330202700.7d8142e8@absol.kitzblitz> To: Lars-Peter Clausen Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Checking 'rtc->irq < 0' doesn't work because 'rtc->irq' is unsigned. v2: return error code from platform_get_irq() instead of -ENOENT. Signed-off-by: Nicolas Kaiser Acked-by: Wan ZongShun --- drivers/rtc/rtc-jz4740.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c index b647363..efd9691 100644 --- a/drivers/rtc/rtc-jz4740.c +++ b/drivers/rtc/rtc-jz4740.c @@ -220,12 +220,12 @@ static int __devinit jz4740_rtc_probe(struct platform_device *pdev) if (!rtc) return -ENOMEM; - rtc->irq = platform_get_irq(pdev, 0); - if (rtc->irq < 0) { - ret = -ENOENT; + ret = platform_get_irq(pdev, 0); + if (ret < 0) { dev_err(&pdev->dev, "Failed to get platform irq\n"); goto err_free; } + rtc->irq = ret; rtc->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!rtc->mem) {