| Message ID | CAKdteOb_1s27kLfyAiM1wo_pGy8voU5FcSETTPJeaNLSTnfSCA@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [testsuite] Fix order of dg-do and dg-require-effective-target directives | expand |
Hi Christophe, On 22/03/18 16:31, Christophe Lyon wrote: > Hi, > > I've noticed 3 tests where dg-do appears after dg-require-effective-target. > This small patch fixes that. > > OK for stage4? > Ok for the arm tests. I would argue that these changes are obvious though. Thanks, Kyrill > Thanks, > > Christophe
On 22 March 2018 at 17:33, Kyrill Tkachov <kyrylo.tkachov@foss.arm.com> wrote: > Hi Christophe, > > On 22/03/18 16:31, Christophe Lyon wrote: >> >> Hi, >> >> I've noticed 3 tests where dg-do appears after >> dg-require-effective-target. >> This small patch fixes that. >> >> OK for stage4? >> > > Ok for the arm tests. > I would argue that these changes are obvious though. > OK, I went ahead and committed it. Thanks, Christophe > Thanks, > Kyrill > >> Thanks, >> >> Christophe > >
diff --git a/gcc/testsuite/gcc.target/arm/addr-modes-float.c b/gcc/testsuite/gcc.target/arm/addr-modes-float.c index 5ffbcb1..4527dd3 100644 --- a/gcc/testsuite/gcc.target/arm/addr-modes-float.c +++ b/gcc/testsuite/gcc.target/arm/addr-modes-float.c @@ -1,7 +1,7 @@ +/* { dg-do compile } */ /* { dg-options "-O2" } */ /* { dg-require-effective-target arm_neon_ok } */ /* { dg-add-options arm_neon } */ -/* { dg-do compile } */ #include <arm_neon.h> diff --git a/gcc/testsuite/gcc.target/arm/addr-modes-int.c b/gcc/testsuite/gcc.target/arm/addr-modes-int.c index 90b7425..faedca0 100644 --- a/gcc/testsuite/gcc.target/arm/addr-modes-int.c +++ b/gcc/testsuite/gcc.target/arm/addr-modes-int.c @@ -1,7 +1,7 @@ +/* { dg-do compile } */ /* { dg-options "-O2 -march=armv7-a" } */ -/* { dg-add-options arm_neon } */ /* { dg-require-effective-target arm_neon_ok } */ -/* { dg-do compile } */ +/* { dg-add-options arm_neon } */ #include "addr-modes.h" diff --git a/gcc/testsuite/gcc.target/nios2/lo-addr-tls.c b/gcc/testsuite/gcc.target/nios2/lo-addr-tls.c index d56fbc2..53060a1 100644 --- a/gcc/testsuite/gcc.target/nios2/lo-addr-tls.c +++ b/gcc/testsuite/gcc.target/nios2/lo-addr-tls.c @@ -1,5 +1,5 @@ -/* { dg-require-effective-target tls } */ /* { dg-do compile } */ +/* { dg-require-effective-target tls } */ /* { dg-options "-O2" } */ /* { dg-final { scan-assembler-not "ldw\tr., %lo" } } */ /* { dg-final { scan-assembler-not "stw\tr., %lo" } } */
Hi, I've noticed 3 tests where dg-do appears after dg-require-effective-target. This small patch fixes that. OK for stage4? Thanks, Christophe commit 068c140ced3946c477a92b145ced33c0c045b4db Author: Christophe Lyon <christophe.lyon@linaro.org> Date: Thu Mar 22 16:04:39 2018 +0000 [testsuite] Make sure dg-do is before dg-require-effective-target. 2018-03-22 Christophe Lyon <christophe.lyon@linaro.org> * gcc.target/arm/addr-modes-float.c: Move dg-do before dg-require-effective-target. * gcc.target/arm/addr-modes-int.c: Likewise. * gcc.target/nios2/lo-addr-tls.c: Likewise. Change-Id: Ie2e7eea647fddbf15c4c7adec24e3e561dca42da