From patchwork Wed Mar 30 16:12:01 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Kaiser X-Patchwork-Id: 88936 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-px0-f184.google.com (mail-px0-f184.google.com [209.85.212.184]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 2C052B6F12 for ; Thu, 31 Mar 2011 03:14:05 +1100 (EST) Received: by pxi4 with SMTP id 4sf211238pxi.11 for ; Wed, 30 Mar 2011 09:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:x-beenthere:received-spf:date:from:to:cc :subject:message-id:organization:face:x-mailer:mime-version :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type; bh=CSW4/ES6wQm/qWe19dFlGTe/Jdq5vT7aOX5jDJJHud4=; b=TTMVggAi9U0IO/QboPDwuFKNTPIkhFgZ0QnbDq/hsXfzpDKMnJM2xUyDXsj4tDcU3S aAJu2f0IVxldIxUS3xx/jlrAREpEQFD4nkrS+HwU9jUKMnPsFZyatkm+e3GdellfLW1x QxKBJH6/Bt5JsJUTz+CNDR5s3Kx2D7deyj6rk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:date:from:to:cc:subject:message-id :organization:face:x-mailer:mime-version:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; b=bqtq5AIZDCOF6iI/cx9l8ssO3VNsqJ344hRl/igyIZZKQ9yZ7zoq91I697WRsaDnuH g8baQ0DUSw8W8Jl92pS+0k9H4p9YWj0I9pSUTqrZ4Ar3qq/YM3hCIlGCSRRS5RHOSrZg jEqdZw35RqkyKULJRsFD0j0EEvuTs5Nm0Y0sw= Received: by 10.142.201.4 with SMTP id y4mr144780wff.44.1301501643263; Wed, 30 Mar 2011 09:14:03 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.142.44.4 with SMTP id r4ls836640wfr.1.p; Wed, 30 Mar 2011 09:14:02 -0700 (PDT) Received: by 10.142.250.24 with SMTP id x24mr970435wfh.29.1301501642449; Wed, 30 Mar 2011 09:14:02 -0700 (PDT) Received: by 10.142.250.24 with SMTP id x24mr970434wfh.29.1301501642427; Wed, 30 Mar 2011 09:14:02 -0700 (PDT) Received: from webhosting01.bon.m2soft.com (webhosting01.bon.m2soft.com [195.38.20.32]) by gmr-mx.google.com with ESMTPS id k41si199409wfa.7.2011.03.30.09.14.00 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 30 Mar 2011 09:14:00 -0700 (PDT) Received-SPF: pass (google.com: domain of nikai@nikai.net designates 195.38.20.32 as permitted sender) client-ip=195.38.20.32; Received: from absol.kitzblitz (85-127-39-214.dynamic.xdsl-line.inode.at [85.127.39.214]) (authenticated bits=0) by webhosting01.bon.m2soft.com (8.13.8/8.13.8) with ESMTP id p2UFol2C013113; Wed, 30 Mar 2011 17:50:50 +0200 Date: Wed, 30 Mar 2011 18:12:01 +0200 From: Nicolas Kaiser To: Alessandro Zummo Cc: Lars-Peter Clausen , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] [PATCH] drivers/rtc/rtc-jz4740.c: fix error check Message-ID: <20110330181201.29e473bf@absol.kitzblitz> Organization: - Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAQMAAABtzGvEAAAAAXNSR0IArs4c6QAAAAZQTFRF AJnV/f/88sgWwwAAAKNJREFUGNM10LENwyAQheFHKCgZgTVSRHI2gy5reROTDSiREvnyHhdXnwXS+ T+ACJgBYTiGSmDDOTdR7XDeTi9ksxEcoKFcTOCJLO7kC5SWFjPZCR69nI9+x5u6OJM1RN5UYUiNKa ZRpHHUoqh1v8hKEZ1FSGCrYOvgVmxd9DIXcSJwLTycm7bj0e4wkJGB48w/FckAwUKl/OGDZAcqItk BU+wHXLqKsjYyPeMAAAAASUVORK5CYII= X-Mailer: Claws Mail (Linux) Mime-Version: 1.0 X-Original-Sender: nikai@nikai.net X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of nikai@nikai.net designates 195.38.20.32 as permitted sender) smtp.mail=nikai@nikai.net Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Checking 'rtc->irq < 0' doesn't work because 'rtc->irq' is unsigned. Signed-off-by: Nicolas Kaiser Acked-by: Lars-Peter Clausen --- Untested. drivers/rtc/rtc-jz4740.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c index b647363..ba91bc6 100644 --- a/drivers/rtc/rtc-jz4740.c +++ b/drivers/rtc/rtc-jz4740.c @@ -220,12 +220,13 @@ static int __devinit jz4740_rtc_probe(struct platform_device *pdev) if (!rtc) return -ENOMEM; - rtc->irq = platform_get_irq(pdev, 0); - if (rtc->irq < 0) { + ret = platform_get_irq(pdev, 0); + if (ret < 0) { ret = -ENOENT; dev_err(&pdev->dev, "Failed to get platform irq\n"); goto err_free; } + rtc->irq = ret; rtc->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!rtc->mem) {