From patchwork Wed Mar 30 16:12:01 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: drivers/rtc/rtc-jz4740.c: fix error check Date: Wed, 30 Mar 2011 06:12:01 -0000 From: Nicolas Kaiser X-Patchwork-Id: 88936 Message-Id: <20110330181201.29e473bf@absol.kitzblitz> To: Alessandro Zummo Cc: Lars-Peter Clausen , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Checking 'rtc->irq < 0' doesn't work because 'rtc->irq' is unsigned. Signed-off-by: Nicolas Kaiser Acked-by: Lars-Peter Clausen --- Untested. drivers/rtc/rtc-jz4740.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c index b647363..ba91bc6 100644 --- a/drivers/rtc/rtc-jz4740.c +++ b/drivers/rtc/rtc-jz4740.c @@ -220,12 +220,13 @@ static int __devinit jz4740_rtc_probe(struct platform_device *pdev) if (!rtc) return -ENOMEM; - rtc->irq = platform_get_irq(pdev, 0); - if (rtc->irq < 0) { + ret = platform_get_irq(pdev, 0); + if (ret < 0) { ret = -ENOENT; dev_err(&pdev->dev, "Failed to get platform irq\n"); goto err_free; } + rtc->irq = ret; rtc->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!rtc->mem) {