[PULL,14/24] RISC-V: Use memory_region_is_ram in pte update

Message ID	1521665220-3869-15-git-send-email-mjc@sifive.com
State	New
Headers	show Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> From: Michael Clark <mjc@sifive.com> To: qemu-devel@nongnu.org Date: Wed, 21 Mar 2018 13:46:50 -0700 Message-Id: <1521665220-3869-15-git-send-email-mjc@sifive.com> In-Reply-To: <1521665220-3869-1-git-send-email-mjc@sifive.com> References: <1521665220-3869-1-git-send-email-mjc@sifive.com> Subject: [Qemu-devel] [PULL 14/24] RISC-V: Use memory_region_is_ram in pte update Precedence: list Cc: patches@groups.riscv.org, Michael Clark <mjc@sifive.com>, Palmer Dabbelt <palmer@sifive.com>, Sagar Karandikar <sagark@eecs.berkeley.edu>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>
Series	[PULL,01/24] RISC-V: Make virt create_fdt interface consistent \| expand [PULL,01/24] RISC-V: Make virt create_fdt interface consistent [PULL,02/24] RISC-V: Replace hardcoded constants with enum values [PULL,03/24] RISC-V: Make virt board description match spike [PULL,04/24] RISC-V: Use ROM base address and size from memmap [PULL,05/24] RISC-V: Remove identity_translate from load_elf [PULL,06/24] RISC-V: Mark ROM read-only after copying in code [PULL,07/24] RISC-V: Remove unused class definitions [PULL,08/24] RISC-V: Make sure rom has space for fdt [PULL,09/24] RISC-V: Include intruction hex in disassembly [PULL,10/24] RISC-V: Improve page table walker spec compliance [PULL,11/24] RISC-V: Update E order and I extension order [PULL,12/24] RISC-V: Make some header guards more specific [PULL,13/24] RISC-V: Make virt header comment title consistent [PULL,14/24] RISC-V: Use memory_region_is_ram in pte update [PULL,15/24] RISC-V: Remove EM_RISCV ELF_MACHINE indirection [PULL,16/24] RISC-V: Hardwire satp to 0 for no-mmu case [PULL,17/24] RISC-V: Remove braces from satp case statement [PULL,18/24] RISC-V: riscv-qemu port supports sv39 and sv48 [PULL,19/24] RISC-V: vectored traps are optional [PULL,20/24] RISC-V: No traps on writes to misa, minstret, mcycle [PULL,21/24] RISC-V: Remove support for adhoc X_COP interrupt [PULL,22/24] RISC-V: Convert cpu definition towards future model [PULL,23/24] RISC-V: Clear mtval/stval on exceptions without info [PULL,24/24] RISC-V: Remove erroneous comment from translate.c

Message ID

1521665220-3869-15-git-send-email-mjc@sifive.com

State

New

Headers

From: Michael Clark <mjc@sifive.com>
To: qemu-devel@nongnu.org
Date: Wed, 21 Mar 2018 13:46:50 -0700
Message-Id: <1521665220-3869-15-git-send-email-mjc@sifive.com>
In-Reply-To: <1521665220-3869-1-git-send-email-mjc@sifive.com>
References: <1521665220-3869-1-git-send-email-mjc@sifive.com>
Subject: [Qemu-devel] [PULL 14/24] RISC-V: Use memory_region_is_ram in pte
	update
Precedence: list
Cc: patches@groups.riscv.org, Michael Clark <mjc@sifive.com>,
	Palmer Dabbelt <palmer@sifive.com>,
	Sagar Karandikar <sagark@eecs.berkeley.edu>,
	Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org
Sender: "Qemu-devel"
	<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>

Series

[PULL,01/24] RISC-V: Make virt create_fdt interface consistent | expand

Commit Message

Michael Clark March 21, 2018, 8:46 p.m. UTC

After reading cpu_physical_memory_write and friends, it seems
that memory_region_is_ram is a more appropriate interface,
and matches the intent of the code that is calling it.

Cc: Sagar Karandikar <sagark@eecs.berkeley.edu>
Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Signed-off-by: Michael Clark <mjc@sifive.com>
Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
---
 target/riscv/helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/riscv/helper.c b/target/riscv/helper.c
index 9010620..b2e3f45 100644
--- a/target/riscv/helper.c
+++ b/target/riscv/helper.c
@@ -234,7 +234,7 @@  restart:
                 hwaddr l = sizeof(target_ulong), addr1;
                 mr = address_space_translate(cs->as, pte_addr,
                     &addr1, &l, false);
-                if (memory_access_is_direct(mr, true)) {
+                if (memory_region_is_ram(mr)) {
                     target_ulong *pte_pa =
                         qemu_map_ram_ptr(mr->ram_block, addr1);
 #if TCG_OVERSIZED_GUEST

[PULL,14/24] RISC-V: Use memory_region_is_ram in pte update

Commit Message

Patch