| Message ID | 20180321053720.12780-3-cang@codeaurora.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Support for Qualcomm UFS QMP PHY on SDM845 | expand |
On 3/21/2018 11:07 AM, Can Guo wrote: > Update the compatible string for UFS QMP PHY on SDM845. > > Signed-off-by: Can Guo <cang@codeaurora.org> > --- > Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt > index cef8765..6e68a6d 100644 > --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt > +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt > @@ -11,7 +11,8 @@ Required properties: > "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996, > "qcom,qmp-v3-usb3-phy" for USB3 QMP V3 phy, > "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845, > - "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845. > + "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845, > + "qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845. We also need an entry for 'ref_aux' clock in the clock names for this phy. Please add that. With that, Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org> Thanks Vivek. > > - reg: offset and length of register set for PHY's common serdes block. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 21, 2018 at 01:37:20PM +0800, Can Guo wrote: > Update the compatible string for UFS QMP PHY on SDM845. typo in the subject. > > Signed-off-by: Can Guo <cang@codeaurora.org> > --- > Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Otherwise, Reviewed-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2018-03-26 23:00, Vivek Gautam wrote: > On 3/21/2018 11:07 AM, Can Guo wrote: >> Update the compatible string for UFS QMP PHY on SDM845. >> >> Signed-off-by: Can Guo <cang@codeaurora.org> >> --- >> Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt >> b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt >> index cef8765..6e68a6d 100644 >> --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt >> +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt >> @@ -11,7 +11,8 @@ Required properties: >> "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996, >> "qcom,qmp-v3-usb3-phy" for USB3 QMP V3 phy, >> "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845, >> - "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on >> sdm845. >> + "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on >> sdm845, >> + "qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845. > > We also need an entry for 'ref_aux' clock in the clock names for this > phy. > Please add that. > With that, > Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org> > > Thanks > Vivek. > I realized that 'ref_aux' is not needed in the driver, shall remove it from the PHY driver. Thanks Can. >> - reg: offset and length of register set for PHY's common serdes >> block. >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2018-03-27 06:24, Rob Herring wrote: > On Wed, Mar 21, 2018 at 01:37:20PM +0800, Can Guo wrote: >> Update the compatible string for UFS QMP PHY on SDM845. > > typo in the subject. > Thank you Rob, shall correct it in the next patch series. Thanks Can. >> >> Signed-off-by: Can Guo <cang@codeaurora.org> >> --- >> Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > Otherwise, > > Reviewed-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt index cef8765..6e68a6d 100644 --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt @@ -11,7 +11,8 @@ Required properties: "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996, "qcom,qmp-v3-usb3-phy" for USB3 QMP V3 phy, "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845, - "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845. + "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845, + "qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845. - reg: offset and length of register set for PHY's common serdes block.
Update the compatible string for UFS QMP PHY on SDM845. Signed-off-by: Can Guo <cang@codeaurora.org> --- Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)