diff mbox series

[2/2] qemu: add libssh2 optional dependency

Message ID 29cf408194b46abbbb75c15a833197b226477246.1521571596.git.baruch@tkos.co.il
State Accepted
Commit d769377a41e172e1963351c168c97a1212561133
Headers show
Series [1/2] libssh2: fix pkg-config info for mbedtls backend | expand

Commit Message

Baruch Siach March 20, 2018, 6:46 p.m. UTC
Make sure that qemu uses libssh2 when libssh2 is enabled, for build
consistency.

Cc: Francois Perrad <francois.perrad@gadz.org>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/qemu/qemu.mk | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Romain Naour March 24, 2018, 7:41 p.m. UTC | #1
Hi Baruch,

Le 20/03/2018 à 19:46, Baruch Siach a écrit :
> Make sure that qemu uses libssh2 when libssh2 is enabled, for build
> consistency.
> 
> Cc: Francois Perrad <francois.perrad@gadz.org>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Reviewed-by: Romain Naour <romain.naour@gmail.com>

Best regards,
Romain

> ---
>  package/qemu/qemu.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index 345ef526681a..c3a7e7738ee6 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -212,6 +212,13 @@ else
>  QEMU_OPTS += --disable-tools
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBSSH2),y)
> +QEMU_OPTS += --enable-libssh2
> +QEMU_DEPENDENCIES += libssh2
> +else
> +QEMU_OPTS += --disable-libssh2
> +endif
> +
>  # Override CPP, as it expects to be able to call it like it'd
>  # call the compiler.
>  define QEMU_CONFIGURE_CMDS
>
Peter Korsgaard March 24, 2018, 8:40 p.m. UTC | #2
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > Make sure that qemu uses libssh2 when libssh2 is enabled, for build
 > consistency.

 > Cc: Francois Perrad <francois.perrad@gadz.org>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed, thanks.
Peter Korsgaard April 6, 2018, 4:58 p.m. UTC | #3
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > Make sure that qemu uses libssh2 when libssh2 is enabled, for build
 > consistency.

 > Cc: Francois Perrad <francois.perrad@gadz.org>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>


Committed to 2018.02.x, thanks.
diff mbox series

Patch

diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 345ef526681a..c3a7e7738ee6 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -212,6 +212,13 @@  else
 QEMU_OPTS += --disable-tools
 endif
 
+ifeq ($(BR2_PACKAGE_LIBSSH2),y)
+QEMU_OPTS += --enable-libssh2
+QEMU_DEPENDENCIES += libssh2
+else
+QEMU_OPTS += --disable-libssh2
+endif
+
 # Override CPP, as it expects to be able to call it like it'd
 # call the compiler.
 define QEMU_CONFIGURE_CMDS